Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1272841 > unrolled thread
| Started by | Tomasz Figa <tomasz.figa@gmail.com> |
|---|---|
| First post | 2015-11-19 05:30 +0100 |
| Last post | 2015-11-19 05:40 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 2/2] arm64: EXYNOS: Consolidate ARCH_EXYNOS7 symbol into ARCH_EXYNOS Tomasz Figa <tomasz.figa@gmail.com> - 2015-11-19 05:30 +0100
Re: [PATCH 2/2] arm64: EXYNOS: Consolidate ARCH_EXYNOS7 symbol into ARCH_EXYNOS Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-19 05:40 +0100
| From | Tomasz Figa <tomasz.figa@gmail.com> |
|---|---|
| Date | 2015-11-19 05:30 +0100 |
| Subject | Re: [PATCH 2/2] arm64: EXYNOS: Consolidate ARCH_EXYNOS7 symbol into ARCH_EXYNOS |
| Message-ID | <qwp18-4sf-17@gated-at.bofh.it> |
Hi Krzysztof, 2015-11-16 10:36 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@samsung.com>: > The ARMv8 Exynos family SoCs in Linux kernel are currently: > - Exynos5433 (controlled by ARCH_EXYNOS), > - Exynos7 (controlled by ARCH_EXYNOS7). > > It duplicates Kconfig symbols unnecessarily, so consolidate them into > one ARCH_EXYNOS. Future SoCs could fall also under the ARCH_EXYNOS > symbol. > > The commit should not bring any visible functional change. I think this basically matches the general recommendation for ARM64, so excluding the single nitpick inline and assuming that, after this patch, grep ARCH_EXYNOS7 gives no results: Reviewed-by: Tomasz Figa <tomasz.figa@gmail.com> > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- > arch/arm64/Kconfig.platforms | 11 ++--------- > arch/arm64/boot/dts/exynos/Makefile | 2 +- > arch/arm64/configs/defconfig | 2 +- > 3 files changed, 4 insertions(+), 11 deletions(-) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index 4043c35962cc..afa19baca94e 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -13,21 +13,14 @@ config ARCH_BERLIN > This enables support for Marvell Berlin SoC Family > > config ARCH_EXYNOS > - bool > - help > - This enables support for Samsung Exynos SoC family > - > -config ARCH_EXYNOS7 > - bool "ARMv8 based Samsung Exynos7" > - select ARCH_EXYNOS > + bool "ARMv8 based Samsung Exynos SoC family" > select COMMON_CLK_SAMSUNG > select HAVE_S3C2410_WATCHDOG if WATCHDOG > select HAVE_S3C_RTC if RTC_CLASS > select PINCTRL > select PINCTRL_EXYNOS > - > help > - This enables support for Samsung Exynos7 SoC family > + This enables support for Samsung Exynos ARMv8 SoC family nit: Sounds a little bit strange. Maybe "This enables support for ARMv8 based Samsung Exynos SoC family"? Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2015-11-19 05:40 +0100 |
| Subject | Re: [PATCH 2/2] arm64: EXYNOS: Consolidate ARCH_EXYNOS7 symbol into ARCH_EXYNOS |
| Message-ID | <qwpaO-4vn-3@gated-at.bofh.it> |
| In reply to | #1272841 |
On 19.11.2015 13:23, Tomasz Figa wrote: > Hi Krzysztof, > > 2015-11-16 10:36 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@samsung.com>: >> The ARMv8 Exynos family SoCs in Linux kernel are currently: >> - Exynos5433 (controlled by ARCH_EXYNOS), >> - Exynos7 (controlled by ARCH_EXYNOS7). >> >> It duplicates Kconfig symbols unnecessarily, so consolidate them into >> one ARCH_EXYNOS. Future SoCs could fall also under the ARCH_EXYNOS >> symbol. >> >> The commit should not bring any visible functional change. > > I think this basically matches the general recommendation for ARM64, > so excluding the single nitpick inline and assuming that, after this > patch, grep ARCH_EXYNOS7 gives no results: > > Reviewed-by: Tomasz Figa <tomasz.figa@gmail.com> > >> >> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> >> --- >> arch/arm64/Kconfig.platforms | 11 ++--------- >> arch/arm64/boot/dts/exynos/Makefile | 2 +- >> arch/arm64/configs/defconfig | 2 +- >> 3 files changed, 4 insertions(+), 11 deletions(-) >> >> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms >> index 4043c35962cc..afa19baca94e 100644 >> --- a/arch/arm64/Kconfig.platforms >> +++ b/arch/arm64/Kconfig.platforms >> @@ -13,21 +13,14 @@ config ARCH_BERLIN >> This enables support for Marvell Berlin SoC Family >> >> config ARCH_EXYNOS >> - bool >> - help >> - This enables support for Samsung Exynos SoC family >> - >> -config ARCH_EXYNOS7 >> - bool "ARMv8 based Samsung Exynos7" >> - select ARCH_EXYNOS >> + bool "ARMv8 based Samsung Exynos SoC family" >> select COMMON_CLK_SAMSUNG >> select HAVE_S3C2410_WATCHDOG if WATCHDOG >> select HAVE_S3C_RTC if RTC_CLASS >> select PINCTRL >> select PINCTRL_EXYNOS >> - >> help >> - This enables support for Samsung Exynos7 SoC family >> + This enables support for Samsung Exynos ARMv8 SoC family > > nit: Sounds a little bit strange. Maybe "This enables support for > ARMv8 based Samsung Exynos SoC family"? Sure, sounds better. Thanks for feedback! BR, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web