Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1271819 > unrolled thread
| Started by | Nicolas Boichat <drinkcat@chromium.org> |
|---|---|
| First post | 2015-11-18 03:50 +0100 |
| Last post | 2015-11-20 18:00 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] watchdog: mtk_wdt: Use MODE_KEY when stopping the watchdog Nicolas Boichat <drinkcat@chromium.org> - 2015-11-18 03:50 +0100
Re: [PATCH] watchdog: mtk_wdt: Use MODE_KEY when stopping the watchdog Guenter Roeck <linux@roeck-us.net> - 2015-11-18 17:30 +0100
Re: [PATCH] watchdog: mtk_wdt: Use MODE_KEY when stopping the watchdog Matthias Brugger <matthias.bgg@gmail.com> - 2015-11-20 18:00 +0100
| From | Nicolas Boichat <drinkcat@chromium.org> |
|---|---|
| Date | 2015-11-18 03:50 +0100 |
| Subject | [PATCH] watchdog: mtk_wdt: Use MODE_KEY when stopping the watchdog |
| Message-ID | <qw0YN-55X-1@gated-at.bofh.it> |
WDT_MODE value need to be or-ed with MODE_KEY when setting watchdog mode. Add it to mtk_wdt_stop function, so that the watchdog can be stopped (e.g. during suspend). Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> --- drivers/watchdog/mtk_wdt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c index 6ad9df9..b751f43 100644 --- a/drivers/watchdog/mtk_wdt.c +++ b/drivers/watchdog/mtk_wdt.c @@ -123,6 +123,7 @@ static int mtk_wdt_stop(struct watchdog_device *wdt_dev) reg = readl(wdt_base + WDT_MODE); reg &= ~WDT_MODE_EN; + reg |= WDT_MODE_KEY; iowrite32(reg, wdt_base + WDT_MODE); return 0; -- 2.6.0.rc2.230.g3dd15c0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Date | 2015-11-18 17:30 +0100 |
| Subject | Re: [PATCH] watchdog: mtk_wdt: Use MODE_KEY when stopping the watchdog |
| Message-ID | <qwdMl-5n6-3@gated-at.bofh.it> |
| In reply to | #1271819 |
On 11/17/2015 06:45 PM, Nicolas Boichat wrote: > WDT_MODE value need to be or-ed with MODE_KEY when setting > watchdog mode. Add it to mtk_wdt_stop function, so that the > watchdog can be stopped (e.g. during suspend). > > Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/watchdog/mtk_wdt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c > index 6ad9df9..b751f43 100644 > --- a/drivers/watchdog/mtk_wdt.c > +++ b/drivers/watchdog/mtk_wdt.c > @@ -123,6 +123,7 @@ static int mtk_wdt_stop(struct watchdog_device *wdt_dev) > > reg = readl(wdt_base + WDT_MODE); > reg &= ~WDT_MODE_EN; > + reg |= WDT_MODE_KEY; > iowrite32(reg, wdt_base + WDT_MODE); > > return 0; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Matthias Brugger <matthias.bgg@gmail.com> |
|---|---|
| Date | 2015-11-20 18:00 +0100 |
| Subject | Re: [PATCH] watchdog: mtk_wdt: Use MODE_KEY when stopping the watchdog |
| Message-ID | <qwXct-1li-3@gated-at.bofh.it> |
| In reply to | #1272348 |
On 18/11/15 17:24, Guenter Roeck wrote: > On 11/17/2015 06:45 PM, Nicolas Boichat wrote: >> WDT_MODE value need to be or-ed with MODE_KEY when setting >> watchdog mode. Add it to mtk_wdt_stop function, so that the >> watchdog can be stopped (e.g. during suspend). >> >> Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> > > Reviewed-by: Guenter Roeck <linux@roeck-us.net> Acked-by: Matthias Brugger <matthias.bgg@gmail.com> > >> --- >> drivers/watchdog/mtk_wdt.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c >> index 6ad9df9..b751f43 100644 >> --- a/drivers/watchdog/mtk_wdt.c >> +++ b/drivers/watchdog/mtk_wdt.c >> @@ -123,6 +123,7 @@ static int mtk_wdt_stop(struct watchdog_device >> *wdt_dev) >> >> reg = readl(wdt_base + WDT_MODE); >> reg &= ~WDT_MODE_EN; >> + reg |= WDT_MODE_KEY; >> iowrite32(reg, wdt_base + WDT_MODE); >> >> return 0; >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web