Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1273541 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2015-11-19 23:10 +0100 |
| Last post | 2015-11-20 17:50 +0100 |
| Articles | 5 — 5 participants |
Back to article view | Back to linux.kernel
[PATCH] scsi: hpsa: select CONFIG_SCSI_SAS_ATTR Arnd Bergmann <arnd@arndb.de> - 2015-11-19 23:10 +0100
Re: [PATCH] scsi: hpsa: select CONFIG_SCSI_SAS_ATTR Christoph Hellwig <hch@infradead.org> - 2015-11-20 11:40 +0100
Re: [PATCH] scsi: hpsa: select CONFIG_SCSI_SAS_ATTR Don Brace <brace77070@gmail.com> - 2015-11-20 17:10 +0100
Re: [PATCH] scsi: hpsa: select CONFIG_SCSI_SAS_ATTR James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-11-20 17:30 +0100
Re: [PATCH] scsi: hpsa: select CONFIG_SCSI_SAS_ATTR "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-11-20 17:50 +0100
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2015-11-19 23:10 +0100 |
| Subject | [PATCH] scsi: hpsa: select CONFIG_SCSI_SAS_ATTR |
| Message-ID | <qwFyW-6U7-11@gated-at.bofh.it> |
The hpsa driver recently started using the sas transport class, but it
does not ensure that the corresponding code is actually built, which
may lead to a link error:
drivers/built-in.o: In function `hpsa_free_sas_phy':
(.text+0x1ce874): undefined reference to `sas_port_delete_phy'
(.text+0x1ce87c): undefined reference to `sas_phy_free'
drivers/built-in.o: In function `hpsa_alloc_sas_port':
(.text+0x1ceb9c): undefined reference to `sas_port_alloc_num'
(.text+0x1ceba8): undefined reference to `sas_port_add'
drivers/built-in.o: In function `hpsa_init':
(.init.text+0x8838): undefined reference to `sas_attach_transport'
(.init.text+0x8868): undefined reference to `sas_release_transport
This adds 'select SCSI_SAS_ATTR' in the Kconfig entry, just like we do
for all other drivers using those functions.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: d04e62b9d63a ("hpsa: add in sas transport class")
---
This showed up on the ARM randconfig builds today for the first time.
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 04a720686516..64eed87d34a8 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -364,6 +364,7 @@ config SCSI_HPSA
tristate "HP Smart Array SCSI driver"
depends on PCI && SCSI
select CHECK_SIGNATURE
+ select SCSI_SAS_ATTRS
help
This driver supports HP Smart Array Controllers (circa 2009).
It is a SCSI alternative to the cciss driver, which is a block
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Christoph Hellwig <hch@infradead.org> |
|---|---|
| Date | 2015-11-20 11:40 +0100 |
| Message-ID | <qwRgJ-60g-11@gated-at.bofh.it> |
| In reply to | #1273541 |
Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Don Brace <brace77070@gmail.com> |
|---|---|
| Date | 2015-11-20 17:10 +0100 |
| Message-ID | <qwWq6-11X-11@gated-at.bofh.it> |
| In reply to | #1273541 |
Signed-off-by: Don Brace <don.brace@pmcs.com>
And...Thanks!
On 11/19/2015 04:04 PM, Arnd Bergmann wrote:
> The hpsa driver recently started using the sas transport class, but it
> does not ensure that the corresponding code is actually built, which
> may lead to a link error:
>
> drivers/built-in.o: In function `hpsa_free_sas_phy':
> (.text+0x1ce874): undefined reference to `sas_port_delete_phy'
> (.text+0x1ce87c): undefined reference to `sas_phy_free'
> drivers/built-in.o: In function `hpsa_alloc_sas_port':
> (.text+0x1ceb9c): undefined reference to `sas_port_alloc_num'
> (.text+0x1ceba8): undefined reference to `sas_port_add'
> drivers/built-in.o: In function `hpsa_init':
> (.init.text+0x8838): undefined reference to `sas_attach_transport'
> (.init.text+0x8868): undefined reference to `sas_release_transport
>
> This adds 'select SCSI_SAS_ATTR' in the Kconfig entry, just like we do
> for all other drivers using those functions.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: d04e62b9d63a ("hpsa: add in sas transport class")
> ---
> This showed up on the ARM randconfig builds today for the first time.
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 04a720686516..64eed87d34a8 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -364,6 +364,7 @@ config SCSI_HPSA
> tristate "HP Smart Array SCSI driver"
> depends on PCI && SCSI
> select CHECK_SIGNATURE
> + select SCSI_SAS_ATTRS
> help
> This driver supports HP Smart Array Controllers (circa 2009).
> It is a SCSI alternative to the cciss driver, which is a block
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | James Bottomley <James.Bottomley@HansenPartnership.com> |
|---|---|
| Date | 2015-11-20 17:30 +0100 |
| Message-ID | <qwWJs-1a6-27@gated-at.bofh.it> |
| In reply to | #1274216 |
On Fri, 2015-11-20 at 10:09 -0600, Don Brace wrote:
> Signed-off-by: Don Brace <don.brace@pmcs.com>
You mean acked-by ... it can only be signed-off-by if *you* resend the
patch because signoffs track the patch transmission path.
James
> And...Thanks!
>
>
> On 11/19/2015 04:04 PM, Arnd Bergmann wrote:
> > The hpsa driver recently started using the sas transport class, but it
> > does not ensure that the corresponding code is actually built, which
> > may lead to a link error:
> >
> > drivers/built-in.o: In function `hpsa_free_sas_phy':
> > (.text+0x1ce874): undefined reference to `sas_port_delete_phy'
> > (.text+0x1ce87c): undefined reference to `sas_phy_free'
> > drivers/built-in.o: In function `hpsa_alloc_sas_port':
> > (.text+0x1ceb9c): undefined reference to `sas_port_alloc_num'
> > (.text+0x1ceba8): undefined reference to `sas_port_add'
> > drivers/built-in.o: In function `hpsa_init':
> > (.init.text+0x8838): undefined reference to `sas_attach_transport'
> > (.init.text+0x8868): undefined reference to `sas_release_transport
> >
> > This adds 'select SCSI_SAS_ATTR' in the Kconfig entry, just like we do
> > for all other drivers using those functions.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: d04e62b9d63a ("hpsa: add in sas transport class")
> > ---
> > This showed up on the ARM randconfig builds today for the first time.
> >
> > diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> > index 04a720686516..64eed87d34a8 100644
> > --- a/drivers/scsi/Kconfig
> > +++ b/drivers/scsi/Kconfig
> > @@ -364,6 +364,7 @@ config SCSI_HPSA
> > tristate "HP Smart Array SCSI driver"
> > depends on PCI && SCSI
> > select CHECK_SIGNATURE
> > + select SCSI_SAS_ATTRS
> > help
> > This driver supports HP Smart Array Controllers (circa 2009).
> > It is a SCSI alternative to the cciss driver, which is a block
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Martin K. Petersen" <martin.petersen@oracle.com> |
|---|---|
| Date | 2015-11-20 17:50 +0100 |
| Message-ID | <qwX2N-1hA-7@gated-at.bofh.it> |
| In reply to | #1273541 |
>>>>> "Arnd" == Arnd Bergmann <arnd@arndb.de> writes: Arnd> The hpsa driver recently started using the sas transport class, Arnd> but it does not ensure that the corresponding code is actually Arnd> built, which may lead to a link error: Applied. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web