Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1273691 > unrolled thread

[PATCH 1/4] spi: mediatek: update document devicetree bindings to fix syntax error

Started byLeilk Liu <leilk.liu@mediatek.com>
First post2015-11-20 03:30 +0100
Last post2015-11-20 15:20 +0100
Articles 6 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/4] spi: mediatek: update document devicetree bindings to fix syntax error Leilk Liu <leilk.liu@mediatek.com> - 2015-11-20 03:30 +0100
    [PATCH 2/4] spi: mediatek: remove unrequired description Leilk Liu <leilk.liu@mediatek.com> - 2015-11-20 03:30 +0100
      Re: [PATCH 2/4] spi: mediatek: remove unrequired description Rob Herring <robh@kernel.org> - 2015-11-20 15:30 +0100
    [PATCH 3/4] spi: mediatek: remove needless pair of writel()/readl() Leilk Liu <leilk.liu@mediatek.com> - 2015-11-20 03:30 +0100
      Re: [PATCH 3/4] spi: mediatek: remove needless pair of  writel()/readl() Matthias Brugger <matthias.bgg@gmail.com> - 2015-11-20 18:00 +0100
    Re: [PATCH 1/4] spi: mediatek: update document devicetree bindings  to fix syntax error Rob Herring <robh@kernel.org> - 2015-11-20 15:20 +0100

#1273691 — [PATCH 1/4] spi: mediatek: update document devicetree bindings to fix syntax error

FromLeilk Liu <leilk.liu@mediatek.com>
Date2015-11-20 03:30 +0100
Subject[PATCH 1/4] spi: mediatek: update document devicetree bindings to fix syntax error
Message-ID<qwJCx-10e-7@gated-at.bofh.it>
This patch updates document devicetree bindings
to fix syntax error.

Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>
---
 .../devicetree/bindings/spi/spi-mt65xx.txt         |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
index ce363c923f..fba8334 100644
--- a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
+++ b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
@@ -32,7 +32,7 @@ Optional properties:
 -cs-gpios: see spi-bus.txt, only required for MT8173.
 
 - mediatek,pad-select: specify which pins group(ck/mi/mo/cs) spi
-  controller used. This is a array, the element value should be 0~3,
+  controller used. This is an array, the element value should be 0~3,
   only required for MT8173.
     0: specify GPIO69,70,71,72 for spi pins.
     1: specify GPIO102,103,104,105 for spi pins.
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1273692 — [PATCH 2/4] spi: mediatek: remove unrequired description

FromLeilk Liu <leilk.liu@mediatek.com>
Date2015-11-20 03:30 +0100
Subject[PATCH 2/4] spi: mediatek: remove unrequired description
Message-ID<qwJCy-10e-13@gated-at.bofh.it>
In reply to#1273691
cs-gpios isn't required with patch "spi: mediatek: single
device does not require cs_gpios", so modify the description.

Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>
---
 .../devicetree/bindings/spi/spi-mt65xx.txt         |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
index fba8334..60a183c 100644
--- a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
+++ b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
@@ -29,7 +29,7 @@ Required properties:
   muxes clock, and "spi-clk" for the clock gate.
 
 Optional properties:
--cs-gpios: see spi-bus.txt, only required for MT8173.
+-cs-gpios: see spi-bus.txt.
 
 - mediatek,pad-select: specify which pins group(ck/mi/mo/cs) spi
   controller used. This is an array, the element value should be 0~3,
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1274100 — Re: [PATCH 2/4] spi: mediatek: remove unrequired description

FromRob Herring <robh@kernel.org>
Date2015-11-20 15:30 +0100
SubjectRe: [PATCH 2/4] spi: mediatek: remove unrequired description
Message-ID<qwURj-8na-9@gated-at.bofh.it>
In reply to#1273692
On Fri, Nov 20, 2015 at 10:21:17AM +0800, Leilk Liu wrote:
> cs-gpios isn't required with patch "spi: mediatek: single
> device does not require cs_gpios", so modify the description.
> 
> Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>

This could use a better subject. Try to make subjects specific enough 
they would only ever apply to the change.

Acked-by: Rob Herring <robh@kernel.org>

> ---
>  .../devicetree/bindings/spi/spi-mt65xx.txt         |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> index fba8334..60a183c 100644
> --- a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> +++ b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> @@ -29,7 +29,7 @@ Required properties:
>    muxes clock, and "spi-clk" for the clock gate.
>  
>  Optional properties:
> --cs-gpios: see spi-bus.txt, only required for MT8173.
> +-cs-gpios: see spi-bus.txt.
>  
>  - mediatek,pad-select: specify which pins group(ck/mi/mo/cs) spi
>    controller used. This is an array, the element value should be 0~3,
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1273694 — [PATCH 3/4] spi: mediatek: remove needless pair of writel()/readl()

FromLeilk Liu <leilk.liu@mediatek.com>
Date2015-11-20 03:30 +0100
Subject[PATCH 3/4] spi: mediatek: remove needless pair of writel()/readl()
Message-ID<qwJCy-10e-17@gated-at.bofh.it>
In reply to#1273691
It's not need to re-read and re-write SPI_CMD_REG, so remove it.

Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>
---
 drivers/spi/spi-mt65xx.c |    3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/spi/spi-mt65xx.c b/drivers/spi/spi-mt65xx.c
index 7840067..6c1a96e 100644
--- a/drivers/spi/spi-mt65xx.c
+++ b/drivers/spi/spi-mt65xx.c
@@ -154,9 +154,6 @@ static int mtk_spi_prepare_message(struct spi_master *master,
 		reg_val |= SPI_CMD_CPOL;
 	else
 		reg_val &= ~SPI_CMD_CPOL;
-	writel(reg_val, mdata->base + SPI_CMD_REG);
-
-	reg_val = readl(mdata->base + SPI_CMD_REG);
 
 	/* set the mlsbx and mlsbtx */
 	if (chip_config->tx_mlsb)
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1274264 — Re: [PATCH 3/4] spi: mediatek: remove needless pair of writel()/readl()

FromMatthias Brugger <matthias.bgg@gmail.com>
Date2015-11-20 18:00 +0100
SubjectRe: [PATCH 3/4] spi: mediatek: remove needless pair of writel()/readl()
Message-ID<qwXcu-1li-11@gated-at.bofh.it>
In reply to#1273694

On 20/11/15 03:21, Leilk Liu wrote:
> It's not need to re-read and re-write SPI_CMD_REG, so remove it.
>
> Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>
> ---
>   drivers/spi/spi-mt65xx.c |    3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/spi/spi-mt65xx.c b/drivers/spi/spi-mt65xx.c
> index 7840067..6c1a96e 100644
> --- a/drivers/spi/spi-mt65xx.c
> +++ b/drivers/spi/spi-mt65xx.c
> @@ -154,9 +154,6 @@ static int mtk_spi_prepare_message(struct spi_master *master,
>   		reg_val |= SPI_CMD_CPOL;
>   	else
>   		reg_val &= ~SPI_CMD_CPOL;
> -	writel(reg_val, mdata->base + SPI_CMD_REG);
> -
> -	reg_val = readl(mdata->base + SPI_CMD_REG);
>
>   	/* set the mlsbx and mlsbtx */
>   	if (chip_config->tx_mlsb)
>

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1274096 — Re: [PATCH 1/4] spi: mediatek: update document devicetree bindings to fix syntax error

FromRob Herring <robh@kernel.org>
Date2015-11-20 15:20 +0100
SubjectRe: [PATCH 1/4] spi: mediatek: update document devicetree bindings to fix syntax error
Message-ID<qwUHE-8jx-35@gated-at.bofh.it>
In reply to#1273691
On Fri, Nov 20, 2015 at 10:21:16AM +0800, Leilk Liu wrote:
> This patch updates document devicetree bindings
> to fix syntax error.
> 
> Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>

Acked-by: Rob Herring <robh@kernel.org>

> ---
>  .../devicetree/bindings/spi/spi-mt65xx.txt         |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> index ce363c923f..fba8334 100644
> --- a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> +++ b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> @@ -32,7 +32,7 @@ Optional properties:
>  -cs-gpios: see spi-bus.txt, only required for MT8173.
>  
>  - mediatek,pad-select: specify which pins group(ck/mi/mo/cs) spi
> -  controller used. This is a array, the element value should be 0~3,
> +  controller used. This is an array, the element value should be 0~3,
>    only required for MT8173.
>      0: specify GPIO69,70,71,72 for spi pins.
>      1: specify GPIO102,103,104,105 for spi pins.
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web