Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1273603 > unrolled thread
| Started by | Heinrich Schuchardt <xypron.glpk@gmx.de> |
|---|---|
| First post | 2015-11-20 00:50 +0100 |
| Last post | 2015-11-20 07:10 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/1] usb: phy: omap-otg: do not write to unallocated memory Heinrich Schuchardt <xypron.glpk@gmx.de> - 2015-11-20 00:50 +0100
Re: [PATCH 1/1] usb: phy: omap-otg: do not write to unallocated memory Chanwoo Choi <cw00.choi@samsung.com> - 2015-11-20 07:10 +0100
| From | Heinrich Schuchardt <xypron.glpk@gmx.de> |
|---|---|
| Date | 2015-11-20 00:50 +0100 |
| Subject | [PATCH 1/1] usb: phy: omap-otg: do not write to unallocated memory |
| Message-ID | <qwH7I-7KF-15@gated-at.bofh.it> |
The current coding writes to memory before allocating it. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- drivers/usb/phy/phy-omap-otg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-omap-otg.c b/drivers/usb/phy/phy-omap-otg.c index 1270906..8bbf121 100644 --- a/drivers/usb/phy/phy-omap-otg.c +++ b/drivers/usb/phy/phy-omap-otg.c @@ -105,12 +105,13 @@ static int omap_otg_probe(struct platform_device *pdev) extcon = extcon_get_extcon_dev(config->extcon); if (!extcon) return -EPROBE_DEFER; - otg_dev->extcon = extcon; otg_dev = devm_kzalloc(&pdev->dev, sizeof(*otg_dev), GFP_KERNEL); if (!otg_dev) return -ENOMEM; + otg_dev->extcon = extcon; + otg_dev->base = devm_ioremap_resource(&pdev->dev, &pdev->resource[0]); if (IS_ERR(otg_dev->base)) return PTR_ERR(otg_dev->base); -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2015-11-20 07:10 +0100 |
| Message-ID | <qwN3r-3oE-1@gated-at.bofh.it> |
| In reply to | #1273603 |
Hi, The same patch was already reviewed and applied on usb.git repository[1] [1] https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/fixes&id=2c2025b41aeff57963f9ae2dd909fea704c625ab Thanks, Chanwoo Choi On 2015년 11월 20일 08:43, Heinrich Schuchardt wrote: > The current coding writes to memory before allocating it. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > drivers/usb/phy/phy-omap-otg.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/phy/phy-omap-otg.c b/drivers/usb/phy/phy-omap-otg.c > index 1270906..8bbf121 100644 > --- a/drivers/usb/phy/phy-omap-otg.c > +++ b/drivers/usb/phy/phy-omap-otg.c > @@ -105,12 +105,13 @@ static int omap_otg_probe(struct platform_device *pdev) > extcon = extcon_get_extcon_dev(config->extcon); > if (!extcon) > return -EPROBE_DEFER; > - otg_dev->extcon = extcon; > > otg_dev = devm_kzalloc(&pdev->dev, sizeof(*otg_dev), GFP_KERNEL); > if (!otg_dev) > return -ENOMEM; > > + otg_dev->extcon = extcon; > + > otg_dev->base = devm_ioremap_resource(&pdev->dev, &pdev->resource[0]); > if (IS_ERR(otg_dev->base)) > return PTR_ERR(otg_dev->base); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web