Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1270001 > unrolled thread

[PATCH v2 PART-RESEND 0/2] berlin sdhci clock clean up

Started byJisheng Zhang <jszhang@marvell.com>
First post2015-11-16 12:10 +0100
Last post2015-11-19 21:40 +0100
Articles 4 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH v2 PART-RESEND 0/2] berlin sdhci clock clean up Jisheng Zhang <jszhang@marvell.com> - 2015-11-16 12:10 +0100
    [PATCH v2 PART-RESEND 2/2] ARM: dts: berlin: add 2nd clock for BG2Q sdhci0 and sdhci1 Jisheng Zhang <jszhang@marvell.com> - 2015-11-16 12:10 +0100
    [PATCH v2 PART-RESEND 1/2] ARM: dts: berlin: correct BG2Q's sdhci2 2nd clock Jisheng Zhang <jszhang@marvell.com> - 2015-11-16 12:10 +0100
    Re: [PATCH v2 PART-RESEND 0/2] berlin sdhci clock clean up Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> - 2015-11-19 21:40 +0100

#1270001 — [PATCH v2 PART-RESEND 0/2] berlin sdhci clock clean up

FromJisheng Zhang <jszhang@marvell.com>
Date2015-11-16 12:10 +0100
Subject[PATCH v2 PART-RESEND 0/2] berlin sdhci clock clean up
Message-ID<qvpPA-6yp-7@gated-at.bofh.it>
Add or fix the optional clock property, then remove the CLK_IGNORE_UNUSED
flag for sdio clk(s).

This is a partialy resend of 
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-October/379457.html

patch3, patch4 has been merged.

Since v1:
 - remove the "mmc: sdhci-pxav3: fix optional clock name" patch to not
   block the clock clean up patches, will send another separate patch
   after talking with HW people.

Jisheng Zhang (2):
  ARM: dts: berlin: correct BG2Q's sdhci2 2nd clock
  ARM: dts: berlin: add 2nd clock for BG2Q sdhci0 and sdhci1

 arch/arm/boot/dts/berlin2q.dtsi | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

-- 
2.6.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1270002 — [PATCH v2 PART-RESEND 2/2] ARM: dts: berlin: add 2nd clock for BG2Q sdhci0 and sdhci1

FromJisheng Zhang <jszhang@marvell.com>
Date2015-11-16 12:10 +0100
Subject[PATCH v2 PART-RESEND 2/2] ARM: dts: berlin: add 2nd clock for BG2Q sdhci0 and sdhci1
Message-ID<qvpPA-6yp-21@gated-at.bofh.it>
In reply to#1270001
Add the optional 2nd clock for BG2Q's sdhci0 and sdhci1. This would let the
clock be disabled during runtime pm, so saves power a bit.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
 arch/arm/boot/dts/berlin2q.dtsi | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
index 145dd33..3920310 100644
--- a/arch/arm/boot/dts/berlin2q.dtsi
+++ b/arch/arm/boot/dts/berlin2q.dtsi
@@ -118,7 +118,8 @@
 		sdhci0: sdhci@ab0000 {
 			compatible = "mrvl,pxav3-mmc";
 			reg = <0xab0000 0x200>;
-			clocks = <&chip_clk CLKID_SDIO1XIN>;
+			clocks = <&chip_clk CLKID_SDIO1XIN>, <&chip_clk CLKID_SDIO>;
+			clock-names = "io", "core";
 			interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
 			status = "disabled";
 		};
@@ -126,7 +127,8 @@
 		sdhci1: sdhci@ab0800 {
 			compatible = "mrvl,pxav3-mmc";
 			reg = <0xab0800 0x200>;
-			clocks = <&chip_clk CLKID_SDIO1XIN>;
+			clocks = <&chip_clk CLKID_SDIO1XIN>, <&chip_clk CLKID_SDIO>;
+			clock-names = "io", "core";
 			interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
 			status = "disabled";
 		};
-- 
2.6.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1270009 — [PATCH v2 PART-RESEND 1/2] ARM: dts: berlin: correct BG2Q's sdhci2 2nd clock

FromJisheng Zhang <jszhang@marvell.com>
Date2015-11-16 12:10 +0100
Subject[PATCH v2 PART-RESEND 1/2] ARM: dts: berlin: correct BG2Q's sdhci2 2nd clock
Message-ID<qvpPB-6yp-41@gated-at.bofh.it>
In reply to#1270001
The optional 2nd clock is CLKID_SDIO.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
 arch/arm/boot/dts/berlin2q.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
index 155430a..145dd33 100644
--- a/arch/arm/boot/dts/berlin2q.dtsi
+++ b/arch/arm/boot/dts/berlin2q.dtsi
@@ -135,7 +135,7 @@
 			compatible = "mrvl,pxav3-mmc";
 			reg = <0xab1000 0x200>;
 			interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>;
-			clocks = <&chip_clk CLKID_NFC_ECC>, <&chip_clk CLKID_NFC>;
+			clocks = <&chip_clk CLKID_NFC_ECC>, <&chip_clk CLKID_SDIO>;
 			clock-names = "io", "core";
 			status = "disabled";
 		};
-- 
2.6.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1273478

FromSebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Date2015-11-19 21:40 +0100
Message-ID<qwE9Q-5PC-23@gated-at.bofh.it>
In reply to#1270001
On 16.11.2015 11:56, Jisheng Zhang wrote:
> Add or fix the optional clock property, then remove the CLK_IGNORE_UNUSED
> flag for sdio clk(s).
> 
> This is a partialy resend of 
> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-October/379457.html
> 
> patch3, patch4 has been merged.

Great! Really!

As they have been taken without my Acked-by, ignoring my request to
_not_ remove the CLK_IGNORE_UNUSED flags _before_ these two, the
remaining patches now become fixes.

Please resend the patches with a proper description what and why they
are fixes now.

Sebastian

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web