Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1270501 > unrolled thread

Re: [PATCH 8/8] stop_machine: cleanup the usage of preemption counter in cpu_stopper_thread()

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 8/8] stop_machine: cleanup the usage of preemption  counter in cpu_stopper_thread() Tejun Heo <tj@kernel.org> - 2015-11-16 20:20 +0100

#1270501 — Re: [PATCH 8/8] stop_machine: cleanup the usage of preemption counter in cpu_stopper_thread()

On Sun, Nov 15, 2015 at 08:33:32PM +0100, Oleg Nesterov wrote:
> 1. Change this code to use preempt_count_inc/preempt_count_dec; this way
>    it works even if CONFIG_PREEMPT_COUNT=n, and we avoid the unnecessary
>    __preempt_schedule() check (stop_sched_class is not preemptible).
> 
>    And this makes clear that we only want to make preempt_count() != 0
>    for __might_sleep() / schedule_debug().
> 
> 2. Change WARN_ONCE() to use %pf to print the function name and remove
>    kallsyms_lookup/ksym_buf.
> 
> 3. Move "int ret" into the "if (work)" block, this looks more consistent.
> 
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

The entire series looks good to me.  Please feel free to add

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web