Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1270195 > unrolled thread
| Started by | Mark Lord <kernel@start.ca> |
|---|---|
| First post | 2015-11-16 15:10 +0100 |
| Last post | 2015-11-16 16:40 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2] libata: add support for NCQ commands for SG interface Mark Lord <kernel@start.ca> - 2015-11-16 15:10 +0100
Re: [PATCH v2] libata: add support for NCQ commands for SG interface Tejun Heo <tj@kernel.org> - 2015-11-16 16:40 +0100
| From | Mark Lord <kernel@start.ca> |
|---|---|
| Date | 2015-11-16 15:10 +0100 |
| Subject | Re: [PATCH v2] libata: add support for NCQ commands for SG interface |
| Message-ID | <qvsDM-8kq-35@gated-at.bofh.it> |
On 15-10-27 01:49 AM, vinayak.kale@gmail.com wrote: > From: Vinayak Kale <vinayak.kale@seagate.com> > > This patch is needed to make NCQ commands with FPDMA protocol value > (eg READ/WRITE FPDMA) work over SCSI Generic (SG) interface. .. > + /* For NCQ commands with FPDMA protocol, copy the tag value */ > + if (tf->protocol == ATA_PROT_NCQ) > + tf->nsect = qc->tag << 3; > + What prevents the qc-tag value here from conflicting with in-flight I/O using the exact same qc-tag ?? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Date | 2015-11-16 16:40 +0100 |
| Message-ID | <qvu2S-EC-23@gated-at.bofh.it> |
| In reply to | #1270195 |
On Mon, Nov 16, 2015 at 08:47:19AM -0500, Mark Lord wrote: > On 15-10-27 01:49 AM, vinayak.kale@gmail.com wrote: > >From: Vinayak Kale <vinayak.kale@seagate.com> > > > >This patch is needed to make NCQ commands with FPDMA protocol value > >(eg READ/WRITE FPDMA) work over SCSI Generic (SG) interface. > .. > >+ /* For NCQ commands with FPDMA protocol, copy the tag value */ > >+ if (tf->protocol == ATA_PROT_NCQ) > >+ tf->nsect = qc->tag << 3; > >+ > > > What prevents the qc-tag value here from conflicting with in-flight I/O > using the exact same qc-tag ?? The SG command doesn't set the tag, it's being set from an allocated qc which can't otherwise be in-flight. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web