Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1268901 > unrolled thread

[PATCH] pstore: add support for 64 Bit address space

Started by"Wiebe, Wladislav (Nokia - DE/Ulm)" <wladislav.wiebe@nokia.com>
First post2015-11-13 13:20 +0100
Last post2015-11-16 12:40 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] pstore: add support for 64 Bit address space "Wiebe, Wladislav (Nokia - DE/Ulm)" <wladislav.wiebe@nokia.com> - 2015-11-13 13:20 +0100
    Re: [PATCH] pstore: add support for 64 Bit address space Kees Cook <keescook@chromium.org> - 2015-11-14 00:50 +0100
      Re: [PATCH] pstore: add support for 64 Bit address space Wladislav Wiebe <wladislav.wiebe@nokia.com> - 2015-11-16 12:40 +0100

#1268901 — [PATCH] pstore: add support for 64 Bit address space

From"Wiebe, Wladislav (Nokia - DE/Ulm)" <wladislav.wiebe@nokia.com>
Date2015-11-13 13:20 +0100
Subject[PATCH] pstore: add support for 64 Bit address space
Message-ID<quluG-6hC-21@gated-at.bofh.it>
Some architectures has there reserved RAM in 64 Bit address space.
Therefore converting mem_address module parameter to ullong.

Signed-off-by: Wladislav Wiebe <wladislav.wiebe@nokia.com>
---
 fs/pstore/ram.c            |    4 ++--
 include/linux/pstore_ram.h |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index 319c3a6..bd9812e 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -55,8 +55,8 @@ static ulong ramoops_pmsg_size = MIN_MEM_SIZE;
 module_param_named(pmsg_size, ramoops_pmsg_size, ulong, 0400);
 MODULE_PARM_DESC(pmsg_size, "size of user space message log");
 
-static ulong mem_address;
-module_param(mem_address, ulong, 0400);
+static unsigned long long mem_address;
+module_param(mem_address, ullong, 0400);
 MODULE_PARM_DESC(mem_address,
 		"start of reserved RAM used to store oops/panic logs");
 
diff --git a/include/linux/pstore_ram.h b/include/linux/pstore_ram.h
index 9c9d6c1..4660aaa 100644
--- a/include/linux/pstore_ram.h
+++ b/include/linux/pstore_ram.h
@@ -76,7 +76,7 @@ ssize_t persistent_ram_ecc_string(struct persistent_ram_zone *prz,
 
 struct ramoops_platform_data {
 	unsigned long	mem_size;
-	unsigned long	mem_address;
+	phys_addr_t	mem_address;
 	unsigned int	mem_type;
 	unsigned long	record_size;
 	unsigned long	console_size;
-- 
1.7.1

Regards,
Wladislav Wiebe


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1269361

FromKees Cook <keescook@chromium.org>
Date2015-11-14 00:50 +0100
Message-ID<quwgq-4yI-7@gated-at.bofh.it>
In reply to#1268901
On Fri, Nov 13, 2015 at 4:10 AM, Wiebe, Wladislav (Nokia - DE/Ulm)
<wladislav.wiebe@nokia.com> wrote:
> Some architectures has there reserved RAM in 64 Bit address space.
> Therefore converting mem_address module parameter to ullong.
>
> Signed-off-by: Wladislav Wiebe <wladislav.wiebe@nokia.com>

If this works correctly, I have no objection. :)

Acked-by: Kees Cook <keescook@chromium.org>

Thanks!

-Kees

> ---
>  fs/pstore/ram.c            |    4 ++--
>  include/linux/pstore_ram.h |    2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
> index 319c3a6..bd9812e 100644
> --- a/fs/pstore/ram.c
> +++ b/fs/pstore/ram.c
> @@ -55,8 +55,8 @@ static ulong ramoops_pmsg_size = MIN_MEM_SIZE;
>  module_param_named(pmsg_size, ramoops_pmsg_size, ulong, 0400);
>  MODULE_PARM_DESC(pmsg_size, "size of user space message log");
>
> -static ulong mem_address;
> -module_param(mem_address, ulong, 0400);
> +static unsigned long long mem_address;
> +module_param(mem_address, ullong, 0400);
>  MODULE_PARM_DESC(mem_address,
>                 "start of reserved RAM used to store oops/panic logs");
>
> diff --git a/include/linux/pstore_ram.h b/include/linux/pstore_ram.h
> index 9c9d6c1..4660aaa 100644
> --- a/include/linux/pstore_ram.h
> +++ b/include/linux/pstore_ram.h
> @@ -76,7 +76,7 @@ ssize_t persistent_ram_ecc_string(struct persistent_ram_zone *prz,
>
>  struct ramoops_platform_data {
>         unsigned long   mem_size;
> -       unsigned long   mem_address;
> +       phys_addr_t     mem_address;
>         unsigned int    mem_type;
>         unsigned long   record_size;
>         unsigned long   console_size;
> --
> 1.7.1
>
> Regards,
> Wladislav Wiebe
>
>



-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1270030

FromWladislav Wiebe <wladislav.wiebe@nokia.com>
Date2015-11-16 12:40 +0100
Message-ID<qvqiB-6Jb-15@gated-at.bofh.it>
In reply to#1269361
Am 14.11.2015 um 00:46 schrieb EXT Kees Cook:
> On Fri, Nov 13, 2015 at 4:10 AM, Wiebe, Wladislav (Nokia - DE/Ulm)
> <wladislav.wiebe@nokia.com> wrote:
>> Some architectures has there reserved RAM in 64 Bit address space.
>> Therefore converting mem_address module parameter to ullong.
>>
>> Signed-off-by: Wladislav Wiebe <wladislav.wiebe@nokia.com>
>
> If this works correctly, I have no objection. :)

I can confirm, it works fine :-)


Thanks!
- Wladislav Wiebe

>
> Acked-by: Kees Cook <keescook@chromium.org>
>
> Thanks!
>
> -Kees
>
>> ---
>>   fs/pstore/ram.c            |    4 ++--
>>   include/linux/pstore_ram.h |    2 +-
>>   2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
>> index 319c3a6..bd9812e 100644
>> --- a/fs/pstore/ram.c
>> +++ b/fs/pstore/ram.c
>> @@ -55,8 +55,8 @@ static ulong ramoops_pmsg_size = MIN_MEM_SIZE;
>>   module_param_named(pmsg_size, ramoops_pmsg_size, ulong, 0400);
>>   MODULE_PARM_DESC(pmsg_size, "size of user space message log");
>>
>> -static ulong mem_address;
>> -module_param(mem_address, ulong, 0400);
>> +static unsigned long long mem_address;
>> +module_param(mem_address, ullong, 0400);
>>   MODULE_PARM_DESC(mem_address,
>>                  "start of reserved RAM used to store oops/panic logs");
>>
>> diff --git a/include/linux/pstore_ram.h b/include/linux/pstore_ram.h
>> index 9c9d6c1..4660aaa 100644
>> --- a/include/linux/pstore_ram.h
>> +++ b/include/linux/pstore_ram.h
>> @@ -76,7 +76,7 @@ ssize_t persistent_ram_ecc_string(struct persistent_ram_zone *prz,
>>
>>   struct ramoops_platform_data {
>>          unsigned long   mem_size;
>> -       unsigned long   mem_address;
>> +       phys_addr_t     mem_address;
>>          unsigned int    mem_type;
>>          unsigned long   record_size;
>>          unsigned long   console_size;
>> --
>> 1.7.1
>>
>> Regards,
>> Wladislav Wiebe
>>
>>
>
>
>

-- 
Regards,
Wladislav Wiebe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web