Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1271375 > unrolled thread

[PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH] ieee802154-atusb: Delete an unnecessary check before the  function call "kfree_skb" Stefan Schmidt <stefan@osg.samsung.com> - 2015-11-17 17:20 +0100

#1271375 — [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 16 Nov 2015 13:50:23 +0100

The kfree_skb() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
  drivers/net/ieee802154/atusb.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
index 199a94a..b1cd865 100644
--- a/drivers/net/ieee802154/atusb.c
+++ b/drivers/net/ieee802154/atusb.c
@@ -310,8 +310,7 @@ static void atusb_free_urbs(struct atusb *atusb)
  		urb = usb_get_from_anchor(&atusb->idle_urbs);
  		if (!urb)
  			break;
-		if (urb->context)
-			kfree_skb(urb->context);
+		kfree_skb(urb->context);
  		usb_free_urb(urb);
  	}
  }
-- 
2.6.2

--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web