Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1271244 > unrolled thread
| Started by | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| First post | 2015-11-17 15:10 +0100 |
| Last post | 2015-11-17 15:10 +0100 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [RFC PATCH 4/7] pinctrl: sunxi: remove redundant "depends on RESET_CONTROLLER" Linus Walleij <linus.walleij@linaro.org> - 2015-11-17 15:10 +0100
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2015-11-17 15:10 +0100 |
| Subject | Re: [RFC PATCH 4/7] pinctrl: sunxi: remove redundant "depends on RESET_CONTROLLER" |
| Message-ID | <qvP7k-64d-39@gated-at.bofh.it> |
On Mon, Nov 16, 2015 at 4:40 AM, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > 2015-11-05 22:40 GMT+09:00 Linus Walleij <linus.walleij@linaro.org>: >> On Thu, Nov 5, 2015 at 12:15 PM, Masahiro Yamada >> <yamada.masahiro@socionext.com> wrote: >> >>> ARCH_SUNXI selects RESET_CONTROLLER. >>> The dependency "depends on RESET_CONTROLLER" is already met. >>> >>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> >> >> NACK, this pin controller needs that as dependency, I don't worry >> that it's overspecified. >> >> They both do this: >> #include <linux/reset.h> >> >> And the object should specify its dependencies, not rely on them >> being implicitly available. >> >> The dep is there for human readers too, not just machines. And to >> them, this is helpful information. > > How strict we should follow this rule? > > Many drivers depend on OF, but do they all have "depends on OF"? I think they should, and if they are in my subsystems I consider it a bug if they don't have this dependency. Also it is a very common reason why test compiles fail. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to top | Article view | linux.kernel
csiph-web