Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1270591 > unrolled thread

[PATCH] stm: select CONFIG_SRCU

Back to article view | Back to linux.kernel

Contents

  [PATCH] stm: select CONFIG_SRCU Arnd Bergmann <arnd@arndb.de> - 2015-11-16 22:20 +0100
    Re: [PATCH] stm: select CONFIG_SRCU Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-11-16 23:40 +0100
    Re: [PATCH] stm: select CONFIG_SRCU Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2015-11-17 15:00 +0100

#1270591 — [PATCH] stm: select CONFIG_SRCU

The newly added STM code uses SRCU, but does not ensure that
this code is part of the kernel:

drivers/built-in.o: In function `stm_source_link_show':
include/linux/srcu.h:221: undefined reference to `__srcu_read_lock'
include/linux/srcu.h:238: undefined reference to `__srcu_read_unlock'
drivers/built-in.o: In function `stm_source_link_drop':
include/linux/srcu.h:221: undefined reference to `__srcu_read_lock'
include/linux/srcu.h:238: undefined reference to `__srcu_read_unlock'

This adds a Kconfig 'select' statement like all the other SRCU using
drivers have.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 7bd1d4093c2f ("stm class: Introduce an abstraction for System Trace Module devices")
---

diff --git a/drivers/hwtracing/stm/Kconfig b/drivers/hwtracing/stm/Kconfig
index 83e9f591a54b..e7a348807f0c 100644
--- a/drivers/hwtracing/stm/Kconfig
+++ b/drivers/hwtracing/stm/Kconfig
@@ -1,6 +1,7 @@
 config STM
 	tristate "System Trace Module devices"
 	select CONFIGFS_FS
+	select SRCU
 	help
 	  A System Trace Module (STM) is a device exporting data in System
 	  Trace Protocol (STP) format as defined by MIPI STP standards.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1270661

On Mon, Nov 16, 2015 at 10:14:35PM +0100, Arnd Bergmann wrote:
> The newly added STM code uses SRCU, but does not ensure that
> this code is part of the kernel:
> 
> drivers/built-in.o: In function `stm_source_link_show':
> include/linux/srcu.h:221: undefined reference to `__srcu_read_lock'
> include/linux/srcu.h:238: undefined reference to `__srcu_read_unlock'
> drivers/built-in.o: In function `stm_source_link_drop':
> include/linux/srcu.h:221: undefined reference to `__srcu_read_lock'
> include/linux/srcu.h:238: undefined reference to `__srcu_read_unlock'
> 
> This adds a Kconfig 'select' statement like all the other SRCU using
> drivers have.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 7bd1d4093c2f ("stm class: Introduce an abstraction for System Trace Module devices")

Related to this, I have to ask why if I answer to N to STM, I'm then
presented with the STM driver options in this file.  It's not like
they'll be built, as drivers/Makefile has:

obj-$(CONFIG_STM)               += hwtracing/stm/

so it seems rather pointless..  Maybe the other options here should
be wrapped with if STM..endif ?

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1271217

Arnd Bergmann <arnd@arndb.de> writes:

> The newly added STM code uses SRCU, but does not ensure that
> this code is part of the kernel:
>
> drivers/built-in.o: In function `stm_source_link_show':
> include/linux/srcu.h:221: undefined reference to `__srcu_read_lock'
> include/linux/srcu.h:238: undefined reference to `__srcu_read_unlock'
> drivers/built-in.o: In function `stm_source_link_drop':
> include/linux/srcu.h:221: undefined reference to `__srcu_read_lock'
> include/linux/srcu.h:238: undefined reference to `__srcu_read_unlock'
>
> This adds a Kconfig 'select' statement like all the other SRCU using
> drivers have.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 7bd1d4093c2f ("stm class: Introduce an abstraction for System Trace Module devices")

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web