Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1269687 > unrolled thread
| Started by | Bogicevic Sasa <brutallesale@gmail.com> |
|---|---|
| First post | 2015-11-15 13:40 +0100 |
| Last post | 2015-11-15 18:10 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] drivers:pci:hotplug Fix space prohibited after function name Bogicevic Sasa <brutallesale@gmail.com> - 2015-11-15 13:40 +0100
Re: [PATCH] drivers:pci:hotplug Fix space prohibited after function name Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-15 18:10 +0100
| From | Bogicevic Sasa <brutallesale@gmail.com> |
|---|---|
| Date | 2015-11-15 13:40 +0100 |
| Subject | [PATCH] drivers:pci:hotplug Fix space prohibited after function name |
| Message-ID | <qv4L8-1oz-17@gated-at.bofh.it> |
This fixes warning that a space is prohibited after function name
Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com>
---
drivers/pci/hotplug/pci_hotplug_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c
index 2bac1b9..d379d49 100644
--- a/drivers/pci/hotplug/pci_hotplug_core.c
+++ b/drivers/pci/hotplug/pci_hotplug_core.c
@@ -226,7 +226,7 @@ static ssize_t test_write_file(struct pci_slot *pci_slot, const char *buf,
u32 test;
int retval = 0;
- ltest = simple_strtoul (buf, NULL, 10);
+ ltest = simple_strtoul(buf, NULL, 10);
test = (u32)(ltest & 0xffffffff);
dbg("test = %d\n", test);
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2015-11-15 18:10 +0100 |
| Message-ID | <qv8Yp-4d3-3@gated-at.bofh.it> |
| In reply to | #1269687 |
On Sun, Nov 15, 2015 at 2:37 PM, Bogicevic Sasa <brutallesale@gmail.com> wrote:
> This fixes warning that a space is prohibited after function name
>
> Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com>
> ---
> drivers/pci/hotplug/pci_hotplug_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c
> index 2bac1b9..d379d49 100644
> --- a/drivers/pci/hotplug/pci_hotplug_core.c
> +++ b/drivers/pci/hotplug/pci_hotplug_core.c
> @@ -226,7 +226,7 @@ static ssize_t test_write_file(struct pci_slot *pci_slot, const char *buf,
> u32 test;
> int retval = 0;
>
> - ltest = simple_strtoul (buf, NULL, 10);
> + ltest = simple_strtoul(buf, NULL, 10);
> test = (u32)(ltest & 0xffffffff);
Looks like all above could be replaced by
int retval;
retval = kstrtou32(… &test);
if (retval)
return retval;
> dbg("test = %d\n", test);
>
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web