Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1267094 > unrolled thread

[PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper

Started byShivani Bhardwaj <shivanib134@gmail.com>
First post2015-11-11 11:30 +0100
Last post2015-11-13 02:00 +0100
Articles 7 — 4 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper Shivani Bhardwaj <shivanib134@gmail.com> - 2015-11-11 11:30 +0100
    Re: [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper Shivani Bhardwaj <shivanib134@gmail.com> - 2015-11-11 18:30 +0100
      Re: [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper Shivani Bhardwaj <shivanib134@gmail.com> - 2015-11-11 18:40 +0100
        Re: [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper Shivani Bhardwaj <shivanib134@gmail.com> - 2015-11-13 14:10 +0100
        Re: [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init  wrapper Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-11-13 14:10 +0100
      Re: [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init  wrapper Greg KH <gregkh@linuxfoundation.org> - 2015-11-11 18:40 +0100
      Re: [lustre-devel] [PATCH] staging: lustre: cl_lock: Remove  cl_lock_lockdep_init wrapper "Dilger, Andreas" <andreas.dilger@intel.com> - 2015-11-13 02:00 +0100

#1267094 — [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper

FromShivani Bhardwaj <shivanib134@gmail.com>
Date2015-11-11 11:30 +0100
Subject[PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper
Message-ID<qtAP9-1we-31@gated-at.bofh.it>
Remove the wrapper function cl_lock_lockdep_init() and replace its only
call with the function it wrapped.

Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
 drivers/staging/lustre/lustre/obdclass/cl_lock.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/staging/lustre/lustre/obdclass/cl_lock.c b/drivers/staging/lustre/lustre/obdclass/cl_lock.c
index 1836dc0..813d0ab 100644
--- a/drivers/staging/lustre/lustre/obdclass/cl_lock.c
+++ b/drivers/staging/lustre/lustre/obdclass/cl_lock.c
@@ -147,11 +147,6 @@ static void cl_lock_trace0(int level, const struct lu_env *env,
 #ifdef CONFIG_LOCKDEP
 static struct lock_class_key cl_lock_key;
 
-static void cl_lock_lockdep_init(struct cl_lock *lock)
-{
-	lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
-}
-
 static void cl_lock_lockdep_acquire(const struct lu_env *env,
 				    struct cl_lock *lock, __u32 enqflags)
 {
@@ -381,7 +376,7 @@ static struct cl_lock *cl_lock_alloc(const struct lu_env *env,
 		CS_LOCKSTATE_INC(obj, CLS_NEW);
 		CS_LOCK_INC(obj, total);
 		CS_LOCK_INC(obj, create);
-		cl_lock_lockdep_init(lock);
+		lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
 		list_for_each_entry(obj, &head->loh_layers,
 					co_lu.lo_linkage) {
 			int err;
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1267335

FromShivani Bhardwaj <shivanib134@gmail.com>
Date2015-11-11 18:30 +0100
Message-ID<qtHnA-5Ks-25@gated-at.bofh.it>
In reply to#1267094
On Wed, Nov 11, 2015 at 4:24 PM, kbuild test robot <lkp@intel.com> wrote:
> Hi Shivani,
>
> [auto build test ERROR on staging/staging-testing]
> [also build test ERROR on v4.3 next-20151111]
>
> url:    https://github.com/0day-ci/linux/commits/Shivani-Bhardwaj/staging-lustre-cl_lock-Remove-cl_lock_lockdep_init-wrapper/20151111-182452
> config: m68k-allyesconfig (attached as .config)
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=m68k
>
> All errors (new ones prefixed by >>):
>
>    In file included from include/linux/spinlock_types.h:18:0,
>                     from include/linux/spinlock.h:81,
>                     from include/linux/mmzone.h:7,
>                     from include/linux/gfp.h:5,
>                     from include/linux/slab.h:14,
>                     from drivers/staging/lustre/lustre/obdclass/../include/obd_support.h:40,
>                     from drivers/staging/lustre/lustre/obdclass/../include/obd_class.h:39,
>                     from drivers/staging/lustre/lustre/obdclass/cl_lock.c:43:
>    drivers/staging/lustre/lustre/obdclass/cl_lock.c: In function 'cl_lock_alloc':
>>> drivers/staging/lustre/lustre/obdclass/cl_lock.c:379:37: error: 'cl_lock_key' undeclared (first use in this function)
>       lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
>                                         ^
>    include/linux/lockdep.h:401:15: note: in definition of macro 'lockdep_set_class_and_name'
>       do { (void)(key); (void)(name); } while (0)
>                   ^
>    drivers/staging/lustre/lustre/obdclass/cl_lock.c:379:37: note: each undeclared identifier is reported only once for each function it appears in
>       lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
>                                         ^
>    include/linux/lockdep.h:401:15: note: in definition of macro 'lockdep_set_class_and_name'
>       do { (void)(key); (void)(name); } while (0)
>                   ^
>    drivers/staging/lustre/lustre/obdclass/cl_lock.c: At top level:
>    drivers/staging/lustre/lustre/obdclass/cl_lock.c:166:13: warning: 'cl_lock_lockdep_init' defined but not used [-Wunused-function]
>     static void cl_lock_lockdep_init(struct cl_lock *lock)
>                 ^
>
> vim +/cl_lock_key +379 drivers/staging/lustre/lustre/obdclass/cl_lock.c
>
>    373                  lockdep_set_class(&lock->cll_guard, &cl_lock_guard_class);
>    374                  init_waitqueue_head(&lock->cll_wq);
>    375                  head = obj->co_lu.lo_header;
>    376                  CS_LOCKSTATE_INC(obj, CLS_NEW);
>    377                  CS_LOCK_INC(obj, total);
>    378                  CS_LOCK_INC(obj, create);
>  > 379                  lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
>    380                  list_for_each_entry(obj, &head->loh_layers,
>    381                                          co_lu.lo_linkage) {
>    382                          int err;
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Hi all,

I'm not getting any of these errors at compilation. I've checked
thrice. Could you please tell what am I doing wrong so that I can
avoid introducing errors in future patches?

Thank you
Shivani
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1267339

FromShivani Bhardwaj <shivanib134@gmail.com>
Date2015-11-11 18:40 +0100
Message-ID<qtHxg-5NS-13@gated-at.bofh.it>
In reply to#1267335
On Wed, Nov 11, 2015 at 11:01 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Wed, Nov 11, 2015 at 10:51:36PM +0530, Shivani Bhardwaj wrote:
>> On Wed, Nov 11, 2015 at 4:24 PM, kbuild test robot <lkp@intel.com> wrote:
>> > Hi Shivani,
>> >
>> > [auto build test ERROR on staging/staging-testing]
>> > [also build test ERROR on v4.3 next-20151111]
>> >
>> > url:    https://github.com/0day-ci/linux/commits/Shivani-Bhardwaj/staging-lustre-cl_lock-Remove-cl_lock_lockdep_init-wrapper/20151111-182452
>> > config: m68k-allyesconfig (attached as .config)
>> > reproduce:
>> >         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>> >         chmod +x ~/bin/make.cross
>> >         # save the attached .config to linux build tree
>> >         make.cross ARCH=m68k
>> >
>> > All errors (new ones prefixed by >>):
>> >
>> >    In file included from include/linux/spinlock_types.h:18:0,
>> >                     from include/linux/spinlock.h:81,
>> >                     from include/linux/mmzone.h:7,
>> >                     from include/linux/gfp.h:5,
>> >                     from include/linux/slab.h:14,
>> >                     from drivers/staging/lustre/lustre/obdclass/../include/obd_support.h:40,
>> >                     from drivers/staging/lustre/lustre/obdclass/../include/obd_class.h:39,
>> >                     from drivers/staging/lustre/lustre/obdclass/cl_lock.c:43:
>> >    drivers/staging/lustre/lustre/obdclass/cl_lock.c: In function 'cl_lock_alloc':
>> >>> drivers/staging/lustre/lustre/obdclass/cl_lock.c:379:37: error: 'cl_lock_key' undeclared (first use in this function)
>> >       lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
>> >                                         ^
>> >    include/linux/lockdep.h:401:15: note: in definition of macro 'lockdep_set_class_and_name'
>> >       do { (void)(key); (void)(name); } while (0)
>> >                   ^
>> >    drivers/staging/lustre/lustre/obdclass/cl_lock.c:379:37: note: each undeclared identifier is reported only once for each function it appears in
>> >       lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
>> >                                         ^
>> >    include/linux/lockdep.h:401:15: note: in definition of macro 'lockdep_set_class_and_name'
>> >       do { (void)(key); (void)(name); } while (0)
>> >                   ^
>> >    drivers/staging/lustre/lustre/obdclass/cl_lock.c: At top level:
>> >    drivers/staging/lustre/lustre/obdclass/cl_lock.c:166:13: warning: 'cl_lock_lockdep_init' defined but not used [-Wunused-function]
>> >     static void cl_lock_lockdep_init(struct cl_lock *lock)
>> >                 ^
>> >
>> > vim +/cl_lock_key +379 drivers/staging/lustre/lustre/obdclass/cl_lock.c
>> >
>> >    373                  lockdep_set_class(&lock->cll_guard, &cl_lock_guard_class);
>> >    374                  init_waitqueue_head(&lock->cll_wq);
>> >    375                  head = obj->co_lu.lo_header;
>> >    376                  CS_LOCKSTATE_INC(obj, CLS_NEW);
>> >    377                  CS_LOCK_INC(obj, total);
>> >    378                  CS_LOCK_INC(obj, create);
>> >  > 379                  lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
>> >    380                  list_for_each_entry(obj, &head->loh_layers,
>> >    381                                          co_lu.lo_linkage) {
>> >    382                          int err;
>> >
>> > ---
>> > 0-DAY kernel test infrastructure                Open Source Technology Center
>> > https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
>>
>> Hi all,
>>
>> I'm not getting any of these errors at compilation. I've checked
>> thrice. Could you please tell what am I doing wrong so that I can
>> avoid introducing errors in future patches?
>
> Use the .config provided, odds are you have lockdep enabled.

Thanks Greg.
I tried that. Still no errors. Any other suggestion?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1268933

FromShivani Bhardwaj <shivanib134@gmail.com>
Date2015-11-13 14:10 +0100
Message-ID<qumh3-6Pn-3@gated-at.bofh.it>
In reply to#1267339
On Fri, Nov 13, 2015 at 6:33 PM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
>
> On Wed, Nov 11, 2015 at 11:03:34PM +0530, Shivani Bhardwaj wrote:
> > On Wed, Nov 11, 2015 at 11:01 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > > On Wed, Nov 11, 2015 at 10:51:36PM +0530, Shivani Bhardwaj wrote:
> > >> On Wed, Nov 11, 2015 at 4:24 PM, kbuild test robot <lkp@intel.com> wrote:
> <snip>
> > >>
> > >> I'm not getting any of these errors at compilation. I've checked
> > >> thrice. Could you please tell what am I doing wrong so that I can
> > >> avoid introducing errors in future patches?
> > >
> > > Use the .config provided, odds are you have lockdep enabled.
> >
> > Thanks Greg.
> > I tried that. Still no errors. Any other suggestion?
>
> while removing the wrapper you missed that cl_lock_lockdep_init() is:
>
> static void cl_lock_lockdep_init(struct cl_lock *lock)
> {
>                 lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
> }
>
> if CONFIG_LOCKDEP is defined.
> and if CONFIG_LOCKDEP is not defined then:
>
> static void cl_lock_lockdep_init(struct cl_lock *lock)
> {}
>
> your patch is using lockdep_set_class_and_name() in both cases.
>

Yes! This is the problem.
Thank you Sudip.

> regards
> sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1268935 — Re: [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper

FromSudip Mukherjee <sudipm.mukherjee@gmail.com>
Date2015-11-13 14:10 +0100
SubjectRe: [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper
Message-ID<qumh3-6Pn-5@gated-at.bofh.it>
In reply to#1267339
On Wed, Nov 11, 2015 at 11:03:34PM +0530, Shivani Bhardwaj wrote:
> On Wed, Nov 11, 2015 at 11:01 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Wed, Nov 11, 2015 at 10:51:36PM +0530, Shivani Bhardwaj wrote:
> >> On Wed, Nov 11, 2015 at 4:24 PM, kbuild test robot <lkp@intel.com> wrote:
<snip>
> >>
> >> I'm not getting any of these errors at compilation. I've checked
> >> thrice. Could you please tell what am I doing wrong so that I can
> >> avoid introducing errors in future patches?
> >
> > Use the .config provided, odds are you have lockdep enabled.
> 
> Thanks Greg.
> I tried that. Still no errors. Any other suggestion?

while removing the wrapper you missed that cl_lock_lockdep_init() is:

static void cl_lock_lockdep_init(struct cl_lock *lock)
{
	        lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
}

if CONFIG_LOCKDEP is defined.
and if CONFIG_LOCKDEP is not defined then:

static void cl_lock_lockdep_init(struct cl_lock *lock)
{}

your patch is using lockdep_set_class_and_name() in both cases.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1267342 — Re: [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper

FromGreg KH <gregkh@linuxfoundation.org>
Date2015-11-11 18:40 +0100
SubjectRe: [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper
Message-ID<qtHxg-5NS-15@gated-at.bofh.it>
In reply to#1267335
On Wed, Nov 11, 2015 at 10:51:36PM +0530, Shivani Bhardwaj wrote:
> On Wed, Nov 11, 2015 at 4:24 PM, kbuild test robot <lkp@intel.com> wrote:
> > Hi Shivani,
> >
> > [auto build test ERROR on staging/staging-testing]
> > [also build test ERROR on v4.3 next-20151111]
> >
> > url:    https://github.com/0day-ci/linux/commits/Shivani-Bhardwaj/staging-lustre-cl_lock-Remove-cl_lock_lockdep_init-wrapper/20151111-182452
> > config: m68k-allyesconfig (attached as .config)
> > reproduce:
> >         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # save the attached .config to linux build tree
> >         make.cross ARCH=m68k
> >
> > All errors (new ones prefixed by >>):
> >
> >    In file included from include/linux/spinlock_types.h:18:0,
> >                     from include/linux/spinlock.h:81,
> >                     from include/linux/mmzone.h:7,
> >                     from include/linux/gfp.h:5,
> >                     from include/linux/slab.h:14,
> >                     from drivers/staging/lustre/lustre/obdclass/../include/obd_support.h:40,
> >                     from drivers/staging/lustre/lustre/obdclass/../include/obd_class.h:39,
> >                     from drivers/staging/lustre/lustre/obdclass/cl_lock.c:43:
> >    drivers/staging/lustre/lustre/obdclass/cl_lock.c: In function 'cl_lock_alloc':
> >>> drivers/staging/lustre/lustre/obdclass/cl_lock.c:379:37: error: 'cl_lock_key' undeclared (first use in this function)
> >       lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
> >                                         ^
> >    include/linux/lockdep.h:401:15: note: in definition of macro 'lockdep_set_class_and_name'
> >       do { (void)(key); (void)(name); } while (0)
> >                   ^
> >    drivers/staging/lustre/lustre/obdclass/cl_lock.c:379:37: note: each undeclared identifier is reported only once for each function it appears in
> >       lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
> >                                         ^
> >    include/linux/lockdep.h:401:15: note: in definition of macro 'lockdep_set_class_and_name'
> >       do { (void)(key); (void)(name); } while (0)
> >                   ^
> >    drivers/staging/lustre/lustre/obdclass/cl_lock.c: At top level:
> >    drivers/staging/lustre/lustre/obdclass/cl_lock.c:166:13: warning: 'cl_lock_lockdep_init' defined but not used [-Wunused-function]
> >     static void cl_lock_lockdep_init(struct cl_lock *lock)
> >                 ^
> >
> > vim +/cl_lock_key +379 drivers/staging/lustre/lustre/obdclass/cl_lock.c
> >
> >    373                  lockdep_set_class(&lock->cll_guard, &cl_lock_guard_class);
> >    374                  init_waitqueue_head(&lock->cll_wq);
> >    375                  head = obj->co_lu.lo_header;
> >    376                  CS_LOCKSTATE_INC(obj, CLS_NEW);
> >    377                  CS_LOCK_INC(obj, total);
> >    378                  CS_LOCK_INC(obj, create);
> >  > 379                  lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
> >    380                  list_for_each_entry(obj, &head->loh_layers,
> >    381                                          co_lu.lo_linkage) {
> >    382                          int err;
> >
> > ---
> > 0-DAY kernel test infrastructure                Open Source Technology Center
> > https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> 
> Hi all,
> 
> I'm not getting any of these errors at compilation. I've checked
> thrice. Could you please tell what am I doing wrong so that I can
> avoid introducing errors in future patches?

Use the .config provided, odds are you have lockdep enabled.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1268528 — Re: [lustre-devel] [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper

From"Dilger, Andreas" <andreas.dilger@intel.com>
Date2015-11-13 02:00 +0100
SubjectRe: [lustre-devel] [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper
Message-ID<quaSB-7Pw-5@gated-at.bofh.it>
In reply to#1267335
On 2015/11/11, 10:21, "lustre-devel on behalf of Shivani Bhardwaj"
<lustre-devel-bounces@lists.lustre.org on behalf of shivanib134@gmail.com>
wrote:

>On Wed, Nov 11, 2015 at 4:24 PM, kbuild test robot <lkp@intel.com> wrote:
>> Hi Shivani,
>>
>> [auto build test ERROR on staging/staging-testing]
>> [also build test ERROR on v4.3 next-20151111]
>>
>> url:    
>>https://github.com/0day-ci/linux/commits/Shivani-Bhardwaj/staging-lustre-
>>cl_lock-Remove-cl_lock_lockdep_init-wrapper/20151111-182452
>> config: m68k-allyesconfig (attached as .config)
>> reproduce:
>>         wget 
>>https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin
>>/make.cross -O ~/bin/make.cross
>>         chmod +x ~/bin/make.cross
>>         # save the attached .config to linux build tree
>>         make.cross ARCH=m68k
>>
>> All errors (new ones prefixed by >>):
>>
>>    In file included from include/linux/spinlock_types.h:18:0,
>>                     from include/linux/spinlock.h:81,
>>                     from include/linux/mmzone.h:7,
>>                     from include/linux/gfp.h:5,
>>                     from include/linux/slab.h:14,
>>                     from
>>drivers/staging/lustre/lustre/obdclass/../include/obd_support.h:40,
>>                     from
>>drivers/staging/lustre/lustre/obdclass/../include/obd_class.h:39,
>>                     from
>>drivers/staging/lustre/lustre/obdclass/cl_lock.c:43:
>>    drivers/staging/lustre/lustre/obdclass/cl_lock.c: In function
>>'cl_lock_alloc':
>>>> drivers/staging/lustre/lustre/obdclass/cl_lock.c:379:37: error:
>>>>'cl_lock_key' undeclared (first use in this function)
>>       lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
>>                                         ^
>>    include/linux/lockdep.h:401:15: note: in definition of macro
>>'lockdep_set_class_and_name'
>>       do { (void)(key); (void)(name); } while (0)
>>                   ^
>>    drivers/staging/lustre/lustre/obdclass/cl_lock.c:379:37: note: each
>>undeclared identifier is reported only once for each function it appears
>>in
>>       lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
>>                                         ^
>>    include/linux/lockdep.h:401:15: note: in definition of macro
>>'lockdep_set_class_and_name'
>>       do { (void)(key); (void)(name); } while (0)
>>                   ^
>>    drivers/staging/lustre/lustre/obdclass/cl_lock.c: At top level:
>>    drivers/staging/lustre/lustre/obdclass/cl_lock.c:166:13: warning:
>>'cl_lock_lockdep_init' defined but not used [-Wunused-function]
>>     static void cl_lock_lockdep_init(struct cl_lock *lock)
>>                 ^
>>
>> vim +/cl_lock_key +379 drivers/staging/lustre/lustre/obdclass/cl_lock.c
>>
>>    373                  lockdep_set_class(&lock->cll_guard,
>>&cl_lock_guard_class);
>>    374                  init_waitqueue_head(&lock->cll_wq);
>>    375                  head = obj->co_lu.lo_header;
>>    376                  CS_LOCKSTATE_INC(obj, CLS_NEW);
>>    377                  CS_LOCK_INC(obj, total);
>>    378                  CS_LOCK_INC(obj, create);
>>  > 379                  lockdep_set_class_and_name(lock, &cl_lock_key,
>>"EXT");
>>    380                  list_for_each_entry(obj, &head->loh_layers,
>>    381                                          co_lu.lo_linkage) {
>>    382                          int err;
>>
>> ---
>> 0-DAY kernel test infrastructure                Open Source Technology
>>Center
>> https://lists.01.org/pipermail/kbuild-all                   Intel
>>Corporation
>
>Hi all,
>
>I'm not getting any of these errors at compilation. I've checked
>thrice. Could you please tell what am I doing wrong so that I can
>avoid introducing errors in future patches?

You need to have CONFIG_LOCKDEP_SUPPORT=y in your kernel .config file.

Cheers, Andreas
-- 
Andreas Dilger

Lustre Principal Engineer
Intel High Performance Data Division


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web