Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1269490 > unrolled thread
| Started by | Nizam Haider <nizamhaider786@gmail.com> |
|---|---|
| First post | 2015-11-14 15:50 +0100 |
| Last post | 2015-11-14 17:10 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v3 2/5] Staging: dgnc: dgnc_neo.c: Logical continuations should be on the previous line Nizam Haider <nizamhaider786@gmail.com> - 2015-11-14 15:50 +0100
Re: [PATCH v3 2/5] Staging: dgnc: dgnc_neo.c: Logical continuations should be on the previous line Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-14 17:10 +0100
| From | Nizam Haider <nizamhaider786@gmail.com> |
|---|---|
| Date | 2015-11-14 15:50 +0100 |
| Subject | [PATCH v3 2/5] Staging: dgnc: dgnc_neo.c: Logical continuations should be on the previous line |
| Message-ID | <quKjo-5f6-15@gated-at.bofh.it> |
Fix Checkpatch warning
CHECK: Logical continuations should be on the previous line
Signed-off-by: Nizam Haider <nijamh@cdac.in>
---
drivers/staging/dgnc/dgnc_neo.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
index cf5bfc7..76d9376 100644
--- a/drivers/staging/dgnc/dgnc_neo.c
+++ b/drivers/staging/dgnc/dgnc_neo.c
@@ -351,8 +351,8 @@ static inline void neo_clear_break(struct channel_t *ch, int force)
/* Turn break off, and unset some variables */
if (ch->ch_flags & CH_BREAK_SENDING) {
- if (time_after_eq(jiffies, ch->ch_stop_sending_break)
- || force) {
+ if (time_after_eq(jiffies, ch->ch_stop_sending_break) ||
+ force) {
unsigned char temp = readb(&ch->ch_neo_uart->lcr);
writeb((temp & ~UART_LCR_SBC), &ch->ch_neo_uart->lcr);
@@ -1783,9 +1783,9 @@ static void neo_vpd(struct dgnc_board *brd)
brd->vpd[(i*2)+1] = (a >> 8) & 0xff;
}
- if (((brd->vpd[0x08] != 0x82) /* long resource name tag */
- && (brd->vpd[0x10] != 0x82)) /* long resource name tag (PCI-66 files)*/
- || (brd->vpd[0x7F] != 0x78)) { /* small resource end tag */
+ if (((brd->vpd[0x08] != 0x82) && /* long resource name tag */
+ (brd->vpd[0x10] != 0x82)) || /* long resource name tag (PCI-66 files)*/
+ (brd->vpd[0x7F] != 0x78)) { /* small resource end tag */
memset(brd->vpd, '\0', NEO_VPD_IMAGESIZE);
} else {
--
1.8.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2015-11-14 17:10 +0100 |
| Subject | Re: [PATCH v3 2/5] Staging: dgnc: dgnc_neo.c: Logical continuations should be on the previous line |
| Message-ID | <quLyN-6cT-3@gated-at.bofh.it> |
| In reply to | #1269490 |
On Sat, Nov 14, 2015 at 4:40 PM, Nizam Haider <nizamhaider786@gmail.com> wrote: > Fix Checkpatch warning > CHECK: Logical continuations should be on the previous line > + (brd->vpd[0x10] != 0x82)) || /* long resource name tag (PCI-66 files)*/ You may fix commentary line here (should be space before asterisk). -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web