Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1268168 > unrolled thread
| Started by | Sreekanth Reddy <sreekanth.reddy@avagotech.com> |
|---|---|
| First post | 2015-11-12 19:20 +0100 |
| Last post | 2015-11-13 21:50 +0100 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] mpt3sas: Fix use sas_is_tlr_enabled API before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag Sreekanth Reddy <sreekanth.reddy@avagotech.com> - 2015-11-12 19:20 +0100
Re: [PATCH] mpt3sas: Fix use sas_is_tlr_enabled API before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag Hannes Reinecke <hare@suse.de> - 2015-11-13 08:30 +0100
Re: [PATCH] mpt3sas: Fix use sas_is_tlr_enabled API before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag Tomas Henzl <thenzl@redhat.com> - 2015-11-13 16:10 +0100
Re: [PATCH] mpt3sas: Fix use sas_is_tlr_enabled API before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-11-13 21:50 +0100
| From | Sreekanth Reddy <sreekanth.reddy@avagotech.com> |
|---|---|
| Date | 2015-11-12 19:20 +0100 |
| Subject | [PATCH] mpt3sas: Fix use sas_is_tlr_enabled API before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag |
| Message-ID | <qu4Dw-3VM-11@gated-at.bofh.it> |
Before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag in MPI SCSI IO request message, check whether TLR is enabled on the drive using 'sas_is_tlr_enabled' API. Actually in the driver code, driver is using below API's 1. sas_enable_tlr() - to enable the TLR 2. sas_disable_tlr() - to disable the TLR 3. sas_is_tlr_enabled() - to check whether TLR is enabled or not. but in scsih_qcmd() we have missed to use sas_is_tlr_enabled() API, instead we checking for TLR bit from flag field of driver's 'struct MPT3SAS_DEVIC' structure. which is corrected with this patch. Signed-off-by: Sreekanth Reddy <Sreekanth.Reddy@avagotech.com> --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index d95206b..9ab77b0 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c @@ -3905,8 +3905,7 @@ scsih_qcmd(struct Scsi_Host *shost, struct scsi_cmnd *scmd) * We do not expose raid functionality to upper layer for warpdrive. */ if (!ioc->is_warpdrive && !scsih_is_raid(&scmd->device->sdev_gendev) - && (sas_device_priv_data->flags & MPT_DEVICE_TLR_ON) && - scmd->cmd_len != 32) + && sas_is_tlr_enabled(scmd->device) && scmd->cmd_len != 32) mpi_control |= MPI2_SCSIIO_CONTROL_TLR_ON; smid = mpt3sas_base_get_smid_scsiio(ioc, ioc->scsi_io_cb_idx, scmd); -- 2.0.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Hannes Reinecke <hare@suse.de> |
|---|---|
| Date | 2015-11-13 08:30 +0100 |
| Subject | Re: [PATCH] mpt3sas: Fix use sas_is_tlr_enabled API before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag |
| Message-ID | <qugY1-3nN-1@gated-at.bofh.it> |
| In reply to | #1268168 |
On 11/12/2015 07:10 PM, Sreekanth Reddy wrote: > Before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag in MPI SCSI IO > request message, check whether TLR is enabled on the drive using > 'sas_is_tlr_enabled' API. > > Actually in the driver code, driver is using below API's > > 1. sas_enable_tlr() - to enable the TLR > 2. sas_disable_tlr() - to disable the TLR > 3. sas_is_tlr_enabled() - to check whether TLR is enabled or not. > > but in scsih_qcmd() we have missed to use sas_is_tlr_enabled() API, > instead we checking for TLR bit from flag field of driver's > 'struct MPT3SAS_DEVIC' structure. which is corrected with this patch. > > Signed-off-by: Sreekanth Reddy <Sreekanth.Reddy@avagotech.com> > --- > drivers/scsi/mpt3sas/mpt3sas_scsih.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c > index d95206b..9ab77b0 100644 > --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c > +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c > @@ -3905,8 +3905,7 @@ scsih_qcmd(struct Scsi_Host *shost, struct scsi_cmnd *scmd) > * We do not expose raid functionality to upper layer for warpdrive. > */ > if (!ioc->is_warpdrive && !scsih_is_raid(&scmd->device->sdev_gendev) > - && (sas_device_priv_data->flags & MPT_DEVICE_TLR_ON) && > - scmd->cmd_len != 32) > + && sas_is_tlr_enabled(scmd->device) && scmd->cmd_len != 32) > mpi_control |= MPI2_SCSIIO_CONTROL_TLR_ON; > > smid = mpt3sas_base_get_smid_scsiio(ioc, ioc->scsi_io_cb_idx, scmd); > Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Tomas Henzl <thenzl@redhat.com> |
|---|---|
| Date | 2015-11-13 16:10 +0100 |
| Subject | Re: [PATCH] mpt3sas: Fix use sas_is_tlr_enabled API before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag |
| Message-ID | <quo9c-81t-19@gated-at.bofh.it> |
| In reply to | #1268168 |
On 12.11.2015 19:10, Sreekanth Reddy wrote: > Before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag in MPI SCSI IO > request message, check whether TLR is enabled on the drive using > 'sas_is_tlr_enabled' API. > > Actually in the driver code, driver is using below API's > > 1. sas_enable_tlr() - to enable the TLR > 2. sas_disable_tlr() - to disable the TLR > 3. sas_is_tlr_enabled() - to check whether TLR is enabled or not. > > but in scsih_qcmd() we have missed to use sas_is_tlr_enabled() API, > instead we checking for TLR bit from flag field of driver's > 'struct MPT3SAS_DEVIC' structure. which is corrected with this patch. > > Signed-off-by: Sreekanth Reddy <Sreekanth.Reddy@avagotech.com> Reviewed-by: Tomas Henzl <thenzl@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Martin K. Petersen" <martin.petersen@oracle.com> |
|---|---|
| Date | 2015-11-13 21:50 +0100 |
| Message-ID | <qutse-2O8-7@gated-at.bofh.it> |
| In reply to | #1268168 |
>>>>> "Sreekanth" == Sreekanth Reddy <sreekanth.reddy@avagotech.com> writes: Sreekanth> Before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag in MPI SCSI Sreekanth> IO request message, check whether TLR is enabled on the drive Sreekanth> using 'sas_is_tlr_enabled' API. Applied. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web