Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1267695 > unrolled thread
| Started by | yalin wang <yalin.wang2010@gmail.com> |
|---|---|
| First post | 2015-11-12 09:00 +0100 |
| Last post | 2015-11-16 03:40 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] mm: change mm_vmscan_lru_shrink_inactive() proto types yalin wang <yalin.wang2010@gmail.com> - 2015-11-12 09:00 +0100
Re: [PATCH] mm: change mm_vmscan_lru_shrink_inactive() proto types Steven Rostedt <rostedt@goodmis.org> - 2015-11-12 15:30 +0100
Re: [PATCH] mm: change mm_vmscan_lru_shrink_inactive() proto types Vlastimil Babka <vbabka@suse.cz> - 2015-11-13 14:20 +0100
Re: [PATCH] mm: change mm_vmscan_lru_shrink_inactive() proto types yalin wang <yalin.wang2010@gmail.com> - 2015-11-16 03:40 +0100
| From | yalin wang <yalin.wang2010@gmail.com> |
|---|---|
| Date | 2015-11-12 09:00 +0100 |
| Subject | [PATCH] mm: change mm_vmscan_lru_shrink_inactive() proto types |
| Message-ID | <qtUXw-62X-11@gated-at.bofh.it> |
Move node_id zone_idx shrink flags into trace function,
so thay we don't need caculate these args if the trace is disabled,
and will make this function have less arguments.
Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
---
include/trace/events/vmscan.h | 14 +++++++-------
mm/vmscan.c | 7 ++-----
2 files changed, 9 insertions(+), 12 deletions(-)
diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h
index dae7836..f8d6b34 100644
--- a/include/trace/events/vmscan.h
+++ b/include/trace/events/vmscan.h
@@ -352,11 +352,11 @@ TRACE_EVENT(mm_vmscan_writepage,
TRACE_EVENT(mm_vmscan_lru_shrink_inactive,
- TP_PROTO(int nid, int zid,
- unsigned long nr_scanned, unsigned long nr_reclaimed,
- int priority, int reclaim_flags),
+ TP_PROTO(struct zone *zone,
+ unsigned long nr_scanned, unsigned long nr_reclaimed,
+ int priority, int file),
- TP_ARGS(nid, zid, nr_scanned, nr_reclaimed, priority, reclaim_flags),
+ TP_ARGS(zone, nr_scanned, nr_reclaimed, priority, file),
TP_STRUCT__entry(
__field(int, nid)
@@ -368,12 +368,12 @@ TRACE_EVENT(mm_vmscan_lru_shrink_inactive,
),
TP_fast_assign(
- __entry->nid = nid;
- __entry->zid = zid;
+ __entry->nid = zone->zone_pgdat->node_id;
+ __entry->zid = zone_idx(zone);
__entry->nr_scanned = nr_scanned;
__entry->nr_reclaimed = nr_reclaimed;
__entry->priority = priority;
- __entry->reclaim_flags = reclaim_flags;
+ __entry->reclaim_flags = trace_shrink_flags(file);
),
TP_printk("nid=%d zid=%d nr_scanned=%ld nr_reclaimed=%ld priority=%d flags=%s",
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 83cea53..bd2918e 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1691,11 +1691,8 @@ shrink_inactive_list(unsigned long nr_to_scan, struct lruvec *lruvec,
current_may_throttle())
wait_iff_congested(zone, BLK_RW_ASYNC, HZ/10);
- trace_mm_vmscan_lru_shrink_inactive(zone->zone_pgdat->node_id,
- zone_idx(zone),
- nr_scanned, nr_reclaimed,
- sc->priority,
- trace_shrink_flags(file));
+ trace_mm_vmscan_lru_shrink_inactive(zone, nr_scanned, nr_reclaimed,
+ sc->priority, file);
return nr_reclaimed;
}
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Date | 2015-11-12 15:30 +0100 |
| Message-ID | <qu12W-1Bf-19@gated-at.bofh.it> |
| In reply to | #1267695 |
On Thu, 12 Nov 2015 15:54:56 +0800 yalin wang <yalin.wang2010@gmail.com> wrote: > Move node_id zone_idx shrink flags into trace function, > so thay we don't need caculate these args if the trace is disabled, > and will make this function have less arguments. > > Signed-off-by: yalin wang <yalin.wang2010@gmail.com> Reviewed-by: Steven Rostedt <rostedt@goodmis.org> -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Vlastimil Babka <vbabka@suse.cz> |
|---|---|
| Date | 2015-11-13 14:20 +0100 |
| Message-ID | <qumqJ-6Sx-11@gated-at.bofh.it> |
| In reply to | #1267695 |
On 11/12/2015 08:54 AM, yalin wang wrote: > Move node_id zone_idx shrink flags into trace function, > so thay we don't need caculate these args if the trace is disabled, > and will make this function have less arguments. > > Signed-off-by: yalin wang <yalin.wang2010@gmail.com> > --- > include/trace/events/vmscan.h | 14 +++++++------- > mm/vmscan.c | 7 ++----- > 2 files changed, 9 insertions(+), 12 deletions(-) > > diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h > index dae7836..f8d6b34 100644 > --- a/include/trace/events/vmscan.h > +++ b/include/trace/events/vmscan.h > @@ -352,11 +352,11 @@ TRACE_EVENT(mm_vmscan_writepage, > > TRACE_EVENT(mm_vmscan_lru_shrink_inactive, > > - TP_PROTO(int nid, int zid, > - unsigned long nr_scanned, unsigned long nr_reclaimed, > - int priority, int reclaim_flags), > + TP_PROTO(struct zone *zone, > + unsigned long nr_scanned, unsigned long nr_reclaimed, > + int priority, int file), > > - TP_ARGS(nid, zid, nr_scanned, nr_reclaimed, priority, reclaim_flags), > + TP_ARGS(zone, nr_scanned, nr_reclaimed, priority, file), > > TP_STRUCT__entry( > __field(int, nid) > @@ -368,12 +368,12 @@ TRACE_EVENT(mm_vmscan_lru_shrink_inactive, > ), > > TP_fast_assign( > - __entry->nid = nid; > - __entry->zid = zid; > + __entry->nid = zone->zone_pgdat->node_id; While at it, convert it to zone_to_nid()? It's not just encapsulation, but also one less pointer dereference. Then you can add my Acked-by. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | yalin wang <yalin.wang2010@gmail.com> |
|---|---|
| Date | 2015-11-16 03:40 +0100 |
| Message-ID | <qvhS1-1l6-1@gated-at.bofh.it> |
| In reply to | #1268941 |
> On Nov 13, 2015, at 21:16, Vlastimil Babka <vbabka@suse.cz> wrote: > > zone_to_nid make sense, i will send V2 patch , -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web