Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1266676 > unrolled thread

[PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface

Started by"Felipe F. Tonello" <eu@felipetonello.com>
First post2015-11-10 19:00 +0100
Last post2015-11-13 09:20 +0100
Articles 6 — 4 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface "Felipe F. Tonello" <eu@felipetonello.com> - 2015-11-10 19:00 +0100
    Re: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for  MIDIStreaming interface Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-11-10 19:50 +0100
      Re: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for  MIDIStreaming interface Felipe Ferreri Tonello <eu@felipetonello.com> - 2015-11-11 10:40 +0100
        Re: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for  MIDIStreaming interface Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-11-11 19:10 +0100
        Re: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for  MIDIStreaming interface Clemens Ladisch <clemens@ladisch.de> - 2015-11-13 09:20 +0100
    Re: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for  MIDIStreaming interface Clemens Ladisch <clemens@ladisch.de> - 2015-11-13 09:20 +0100

#1266676 — [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface

From"Felipe F. Tonello" <eu@felipetonello.com>
Date2015-11-10 19:00 +0100
Subject[PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface
Message-ID<qtln4-8aF-19@gated-at.bofh.it>
This avoids duplication of USB requests for OUT endpoint and
re-enabling endpoints.

Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---
 drivers/usb/gadget/function/f_midi.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
index 76ea53c..615d632 100644
--- a/drivers/usb/gadget/function/f_midi.c
+++ b/drivers/usb/gadget/function/f_midi.c
@@ -75,6 +75,7 @@ struct f_midi {
 	struct usb_ep		*in_ep, *out_ep;
 	struct snd_card		*card;
 	struct snd_rawmidi	*rmidi;
+	u8					ms_id;
 
 	struct snd_rawmidi_substream *in_substream[MAX_PORTS];
 	struct snd_rawmidi_substream *out_substream[MAX_PORTS];
@@ -322,7 +323,7 @@ static int f_midi_set_alt(struct usb_function *f, unsigned intf, unsigned alt)
 	int err;
 
 	/* For Control Device interface we do nothing */
-	if (intf == 0)
+	if (intf != midi->ms_id)
 		return 0;
 
 	err = f_midi_start_ep(midi, f, midi->in_ep);
@@ -730,6 +731,7 @@ static int f_midi_bind(struct usb_configuration *c, struct usb_function *f)
 		goto fail;
 	ms_interface_desc.bInterfaceNumber = status;
 	ac_header_desc.baInterfaceNr[0] = status;
+	midi->ms_id = status;
 
 	status = -ENODEV;
 
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1266719 — Re: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface

FromSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date2015-11-10 19:50 +0100
SubjectRe: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface
Message-ID<qtm9s-gB-11@gated-at.bofh.it>
In reply to#1266676
Hello.

On 11/10/2015 08:52 PM, Felipe F. Tonello wrote:

> This avoids duplication of USB requests for OUT endpoint and
> re-enabling endpoints.
>
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> ---
>   drivers/usb/gadget/function/f_midi.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
> index 76ea53c..615d632 100644
> --- a/drivers/usb/gadget/function/f_midi.c
> +++ b/drivers/usb/gadget/function/f_midi.c
> @@ -75,6 +75,7 @@ struct f_midi {
>   	struct usb_ep		*in_ep, *out_ep;
>   	struct snd_card		*card;
>   	struct snd_rawmidi	*rmidi;
> +	u8					ms_id;

   Why 'ms_id' is not aligned with the above field names?

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1267053 — Re: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface

FromFelipe Ferreri Tonello <eu@felipetonello.com>
Date2015-11-11 10:40 +0100
SubjectRe: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface
Message-ID<qtA2J-Xz-1@gated-at.bofh.it>
In reply to#1266719

[Multipart message — attachments visible in raw view] — view raw

Hi Sergei,

On 10/11/15 18:43, Sergei Shtylyov wrote:
> Hello.
> 
> On 11/10/2015 08:52 PM, Felipe F. Tonello wrote:
> 
>> This avoids duplication of USB requests for OUT endpoint and
>> re-enabling endpoints.
>>
>> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
>> ---
>>   drivers/usb/gadget/function/f_midi.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/gadget/function/f_midi.c
>> b/drivers/usb/gadget/function/f_midi.c
>> index 76ea53c..615d632 100644
>> --- a/drivers/usb/gadget/function/f_midi.c
>> +++ b/drivers/usb/gadget/function/f_midi.c
>> @@ -75,6 +75,7 @@ struct f_midi {
>>       struct usb_ep        *in_ep, *out_ep;
>>       struct snd_card        *card;
>>       struct snd_rawmidi    *rmidi;
>> +    u8                    ms_id;
> 
>   Why 'ms_id' is not aligned with the above field names?

It is actually aligned. Perhaps because of the +?

Here is from my local git diff:

--- a/drivers/usb/gadget/function/f_midi.c
+++ b/drivers/usb/gadget/function/f_midi.c
@@ -75,6 +75,7 @@ struct f_midi {
    struct usb_ep       *in_ep, *out_ep;
    struct snd_card     *card;
    struct snd_rawmidi  *rmidi;
+   u8                  ms_id;

    struct snd_rawmidi_substream *in_substream[MAX_PORTS];
    struct snd_rawmidi_substream *out_substream[MAX_PORTS];


-- 
Felipe

[toc] | [prev] | [next] | [standalone]

#1267360 — Re: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface

FromSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date2015-11-11 19:10 +0100
SubjectRe: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface
Message-ID<qtI0i-6el-25@gated-at.bofh.it>
In reply to#1267053
Hello.

On 11/11/2015 12:38 PM, Felipe Ferreri Tonello wrote:

>>> This avoids duplication of USB requests for OUT endpoint and
>>> re-enabling endpoints.
>>>
>>> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
>>> ---
>>>    drivers/usb/gadget/function/f_midi.c | 4 +++-
>>>    1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/usb/gadget/function/f_midi.c
>>> b/drivers/usb/gadget/function/f_midi.c
>>> index 76ea53c..615d632 100644
>>> --- a/drivers/usb/gadget/function/f_midi.c
>>> +++ b/drivers/usb/gadget/function/f_midi.c
>>> @@ -75,6 +75,7 @@ struct f_midi {
>>>        struct usb_ep        *in_ep, *out_ep;
>>>        struct snd_card        *card;
>>>        struct snd_rawmidi    *rmidi;
>>> +    u8                    ms_id;
>>
>>    Why 'ms_id' is not aligned with the above field names?
>
> It is actually aligned. Perhaps because of the +?

   No, + should not affect this, it only affects things when a line doesn't 
start with a tab.

> Here is from my local git diff:
>
> --- a/drivers/usb/gadget/function/f_midi.c
> +++ b/drivers/usb/gadget/function/f_midi.c
> @@ -75,6 +75,7 @@ struct f_midi {
>      struct usb_ep       *in_ep, *out_ep;
>      struct snd_card     *card;
>      struct snd_rawmidi  *rmidi;
> +   u8                  ms_id;

    Unfortunately, tabs got replaces with spaces in this fragment.

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1268681 — Re: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface

FromClemens Ladisch <clemens@ladisch.de>
Date2015-11-13 09:20 +0100
SubjectRe: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface
Message-ID<quhKq-3UK-9@gated-at.bofh.it>
In reply to#1267053
Felipe Ferreri Tonello wrote:
> On 10/11/15 18:43, Sergei Shtylyov wrote:
>> On 11/10/2015 08:52 PM, Felipe F. Tonello wrote:
>>> @@ -75,6 +75,7 @@ struct f_midi {
>>>       struct usb_ep        *in_ep, *out_ep;
>>>       struct snd_card        *card;
>>>       struct snd_rawmidi    *rmidi;
>>> +    u8                    ms_id;
>>
>>   Why 'ms_id' is not aligned with the above field names?
>
> It is actually aligned.

It's not in the original mail, which contains tab characters.

> Here is from my local git diff:
>
> @@ -75,6 +75,7 @@ struct f_midi {
>     struct usb_ep       *in_ep, *out_ep;
>     struct snd_card     *card;
>     struct snd_rawmidi  *rmidi;
> +   u8                  ms_id;

Apparently, you're using four spaces per tab.  Linux uses eight.


Regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1268679 — Re: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface

FromClemens Ladisch <clemens@ladisch.de>
Date2015-11-13 09:20 +0100
SubjectRe: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface
Message-ID<quhKp-3UK-3@gated-at.bofh.it>
In reply to#1266676
Felipe F. Tonello wrote:
> This avoids duplication of USB requests for OUT endpoint and
> re-enabling endpoints.

>  ...
>  	/* For Control Device interface we do nothing */
> -	if (intf == 0)
> +	if (intf != midi->ms_id)
>  		return 0;

The comment now is misleading.


Regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web