Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1266385 > unrolled thread

[PATCH] qed: select ZLIB_INFLATE

Back to article view | Back to linux.kernel

Contents

  [PATCH] qed: select ZLIB_INFLATE Arnd Bergmann <arnd@arndb.de> - 2015-11-10 11:30 +0100
    Re: [PATCH] qed: select ZLIB_INFLATE David Miller <davem@davemloft.net> - 2015-11-10 21:40 +0100

#1266385 — [PATCH] qed: select ZLIB_INFLATE

The newly added qlogic qed driver uses the zlib library, but
misses the dependency:

drivers/built-in.o: In function `qed_alloc_stream_mem':
drivers/net/ethernet/qlogic/qed/qed_main.c:707: undefined reference to `zlib_inflate_workspacesize'
drivers/built-in.o: In function `qed_unzip_data':
drivers/net/ethernet/qlogic/qed/qed_main.c:675: undefined reference to `zlib_inflateInit2'

This changes Kconfig to always select zlib when needed.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: fe56b9e6a8d9 ("qed: Add module with basic common support")
---
Found on ARM randconfig builds

diff --git a/drivers/net/ethernet/qlogic/Kconfig b/drivers/net/ethernet/qlogic/Kconfig
index 30a6f246dfc9..ddcfcab034c2 100644
--- a/drivers/net/ethernet/qlogic/Kconfig
+++ b/drivers/net/ethernet/qlogic/Kconfig
@@ -94,6 +94,7 @@ config NETXEN_NIC
 config QED
 	tristate "QLogic QED 25/40/100Gb core driver"
 	depends on PCI
+	select ZLIB_INFLATE
 	---help---
 	  This enables the support for ...
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1266770

From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 10 Nov 2015 11:28:15 +0100

> The newly added qlogic qed driver uses the zlib library, but
> misses the dependency:
> 
> drivers/built-in.o: In function `qed_alloc_stream_mem':
> drivers/net/ethernet/qlogic/qed/qed_main.c:707: undefined reference to `zlib_inflate_workspacesize'
> drivers/built-in.o: In function `qed_unzip_data':
> drivers/net/ethernet/qlogic/qed/qed_main.c:675: undefined reference to `zlib_inflateInit2'
> 
> This changes Kconfig to always select zlib when needed.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: fe56b9e6a8d9 ("qed: Add module with basic common support")
> ---
> Found on ARM randconfig builds

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web