Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1267251 > unrolled thread

[PATCH 0/3] drm/i2c: tda998x: Add support for atomic modesetting.

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/3] drm/i2c: tda998x: Add support for atomic modesetting. Liviu Dudau <Liviu.Dudau@arm.com> - 2015-11-11 16:40 +0100
    Re: [PATCH 0/3] drm/i2c: tda998x: Add support for atomic modesetting. Liviu Dudau <Liviu.Dudau@arm.com> - 2015-11-11 19:00 +0100
    Re: [PATCH 0/3] drm/i2c: tda998x: Add support for atomic modesetting. Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-11-11 19:00 +0100

#1267251 — [PATCH 0/3] drm/i2c: tda998x: Add support for atomic modesetting.

Hello,

While updating the HDLCD driver to support atomic modesetting I've encountered crashes
when using it with the tda998x driver because the later doesn't support the atomic
helper functions. While going through the code testing I've noticed an unbalanced
.unbind missing drm_connector_unregister() and updated the pixel clock support for
TDA19988.

These patches are to be applied on top of David Airlie's drm-next. I've used commit
816d2206f0f9 as that includes Russell's cleanup for tda998x that has gone into v4.4-rc1.

Best regards,
Liviu

Liviu Dudau (3):
  drm/i2c: tda998x: Unregister the connector in the unbind function.
  drm/i2c: tda998x: Increase the supported dotclock frequency to 165MHz for TDA19988.
  drm/i2c: tda998x: Add support for atomic modesetting.

 drivers/gpu/drm/i2c/tda998x_drv.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

-- 
2.6.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1267354

On Wed, Nov 11, 2015 at 05:51:52PM +0000, Russell King - ARM Linux wrote:
> On Wed, Nov 11, 2015 at 03:34:32PM +0000, Liviu Dudau wrote:
> > While going through the code testing I've noticed an unbalanced
> > .unbind missing drm_connector_unregister()
> 
> That actually doesn't matter, as DRM automatically tears them down anyway,
> so this isn't an urgent change.  However, it's good practice to do so.

It looks like it doesn't, or at least not if the error code is -EPROBE_DEFER.
On Juno, where the clocks are provided by SCPI and the load order is not
guaranteed, the first bind will fail with -EPROBE_DEFER but the sysfs entry
is not cleaned up, so on the next attempt the drm_connector_register() call
will fail.

Best regards,
Liviu

> 
> -- 
> FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
> according to speedtest.net.
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1267355

On Wed, Nov 11, 2015 at 03:34:32PM +0000, Liviu Dudau wrote:
> While going through the code testing I've noticed an unbalanced
> .unbind missing drm_connector_unregister()

That actually doesn't matter, as DRM automatically tears them down anyway,
so this isn't an urgent change.  However, it's good practice to do so.

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web