Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1267090 > unrolled thread
| Started by | Wang Nan <wangnan0@huawei.com> |
|---|---|
| First post | 2015-11-11 11:30 +0100 |
| Last post | 2015-11-11 15:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] perf probe: Clear probe_trace_event when probe_trace_event failure Wang Nan <wangnan0@huawei.com> - 2015-11-11 11:30 +0100
RE: [PATCH] perf probe: Clear probe_trace_event when probe_trace_event failure 平松雅巳 / HIRAMATU，MASAMI <masami.hiramatsu.pt@hitachi.com> - 2015-11-11 15:50 +0100
| From | Wang Nan <wangnan0@huawei.com> |
|---|---|
| Date | 2015-11-11 11:30 +0100 |
| Subject | [PATCH] perf probe: Clear probe_trace_event when probe_trace_event failure |
| Message-ID | <qtAP8-1we-9@gated-at.bofh.it> |
When failure occures in add_probe_trace_event(), to avoid potential dangling pointer and memory leak, resource attached to 'struct probe_trace_event' should be cleared. Signed-off-by: Wang Nan <wangnan0@huawei.com> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Zefan Li <lizefan@huawei.com> Cc: pi3orama@163.com --- tools/perf/util/probe-finder.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c index bd8f03d..e9e37ca 100644 --- a/tools/perf/util/probe-finder.c +++ b/tools/perf/util/probe-finder.c @@ -1235,6 +1235,8 @@ static int add_probe_trace_event(Dwarf_Die *sc_die, struct probe_finder *pf) end: free(args); + if (ret) + clear_probe_trace_event(tev); return ret; } -- 1.8.3.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | 平松雅巳 / HIRAMATU，MASAMI <masami.hiramatsu.pt@hitachi.com> |
|---|---|
| Date | 2015-11-11 15:50 +0100 |
| Subject | RE: [PATCH] perf probe: Clear probe_trace_event when probe_trace_event failure |
| Message-ID | <qtESK-434-9@gated-at.bofh.it> |
| In reply to | #1267090 |
RnJvbTogV2FuZyBOYW4gW21haWx0bzp3YW5nbmFuMEBodWF3ZWkuY29tXQ0KPg0KPldoZW4gZmFp bHVyZSBvY2N1cmVzIGluIGFkZF9wcm9iZV90cmFjZV9ldmVudCgpLCB0byBhdm9pZCBwb3RlbnRp YWwNCj5kYW5nbGluZyBwb2ludGVyIGFuZCBtZW1vcnkgbGVhaywgcmVzb3VyY2UgYXR0YWNoZWQg dG8gJ3N0cnVjdA0KPnByb2JlX3RyYWNlX2V2ZW50JyBzaG91bGQgYmUgY2xlYXJlZC4NCg0KT29w cywgcmlnaHQuIEkndmUgZm91bmQgYWN0dWFsIG1lbW9yeSBsZWFrIGFuZCB0aGlzIGZpeCBpcyBu b3QgZW5vdWdoLA0KYmVjYXVzZSBkZWJ1Z2luZm9fX2ZpbmRfdHJhY2VfZXZlbnRzKCkgcmVsZWFz ZXMgInRldnMiIGFycmF5IHdpdGhvdXQNCmNsZWFyaW5nIGV2ZXJ5dGhpbmcgaW4gdGhlIGFycmF5 IGlmIGl0IGZhaWxzLi4uDQoNClNpbmNlIGFkZF9wcm9iZV90cmFjZV9ldmVudCgpIG1heSBiZSBp bnZva2VkIHJlcGVhdGVkbHkgd2hpbGUgc2VhcmNoaW5nDQpwcm9iZSBwb2ludHMgZnJvbSBkZWJ1 Z2luZm8sIHRoZXJlIGNhbiBiZSB0aGUgY2FzZSB0aGF0IGZpcnN0IE4tMSB0aW1lcw0Kc3VjY2Vl ZHMsIGJ1dCBOdGggY2FsbCBmYWlscy4gSW4gdGhhdCBjYXNlLCBldmVuIGlmIHlvdSBjbGVhciB0 aGUgbGFzdA0Kb25lLCB3ZSBzdGlsbCBoYXZlIE4tMSB0ZXZzIGFuZCBkZWJ1Z2luZm9fX2ZpbmRf dHJhY2VfZXZlbnRzKCkgbGVha3MgdGhvc2UuDQpUaHVzLCB0aGUgY29ycmVjdCBmaXggaXMgY2xl YXJpbmcgYWxsIHRoZSB0ZXZzIHdoZW4gd2UgaGl0IGFueSBlcnJvci4NCg0KSSdsbCBzZW5kIG90 aGVyIHBhdGNoIHRvIGZpeCBpdC4NCg0KVGhhbmtzIQ0KDQo+DQo+U2lnbmVkLW9mZi1ieTogV2Fu ZyBOYW4gPHdhbmduYW4wQGh1YXdlaS5jb20+DQo+Q2M6IE1hc2FtaSBIaXJhbWF0c3UgPG1hc2Ft aS5oaXJhbWF0c3UucHRAaGl0YWNoaS5jb20+DQo+Q2M6IEFybmFsZG8gQ2FydmFsaG8gZGUgTWVs byA8YWNtZUByZWRoYXQuY29tPg0KPkNjOiBaZWZhbiBMaSA8bGl6ZWZhbkBodWF3ZWkuY29tPg0K PkNjOiBwaTNvcmFtYUAxNjMuY29tDQo+LS0tDQo+IHRvb2xzL3BlcmYvdXRpbC9wcm9iZS1maW5k ZXIuYyB8IDIgKysNCj4gMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKQ0KPg0KPmRpZmYg LS1naXQgYS90b29scy9wZXJmL3V0aWwvcHJvYmUtZmluZGVyLmMgYi90b29scy9wZXJmL3V0aWwv cHJvYmUtZmluZGVyLmMNCj5pbmRleCBiZDhmMDNkLi5lOWUzN2NhIDEwMDY0NA0KPi0tLSBhL3Rv b2xzL3BlcmYvdXRpbC9wcm9iZS1maW5kZXIuYw0KPisrKyBiL3Rvb2xzL3BlcmYvdXRpbC9wcm9i ZS1maW5kZXIuYw0KPkBAIC0xMjM1LDYgKzEyMzUsOCBAQCBzdGF0aWMgaW50IGFkZF9wcm9iZV90 cmFjZV9ldmVudChEd2FyZl9EaWUgKnNjX2RpZSwgc3RydWN0IHByb2JlX2ZpbmRlciAqcGYpDQo+ DQo+IGVuZDoNCj4gCWZyZWUoYXJncyk7DQo+KwlpZiAocmV0KQ0KPisJCWNsZWFyX3Byb2JlX3Ry YWNlX2V2ZW50KHRldik7DQo+IAlyZXR1cm4gcmV0Ow0KPiB9DQo+DQo+LS0NCj4xLjguMy40DQoN Cg== -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web