Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1266027 > unrolled thread

[PATCH] power: bq27xxx_battery: Add I2C module check dependency in Kconfig

Started by"Andrew F. Davis" <afd@ti.com>
First post2015-11-09 22:30 +0100
Last post2015-11-10 05:00 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] power: bq27xxx_battery: Add I2C module check dependency in Kconfig "Andrew F. Davis" <afd@ti.com> - 2015-11-09 22:30 +0100
    Re: [PATCH] power: bq27xxx_battery: Add I2C module check dependency in Kconfig Arnd Bergmann <arnd@arndb.de> - 2015-11-09 22:40 +0100
    Re: [PATCH] power: bq27xxx_battery: Add I2C module check dependency  in Kconfig Sebastian Reichel <sre@kernel.org> - 2015-11-10 05:00 +0100

#1266027 — [PATCH] power: bq27xxx_battery: Add I2C module check dependency in Kconfig

From"Andrew F. Davis" <afd@ti.com>
Date2015-11-09 22:30 +0100
Subject[PATCH] power: bq27xxx_battery: Add I2C module check dependency in Kconfig
Message-ID<qt2aJ-3vI-1@gated-at.bofh.it>
Check if I2C core has been built as a module when BATTERY_BQ27XXX
is built-in. If so disable I2C functionality.

Fixes: 6bd03ce3c12a ("power: bq27xxx_battery: Remove unneeded dependency in Kconfig")
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 drivers/power/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
index 237d7aa..2f944d7 100644
--- a/drivers/power/Kconfig
+++ b/drivers/power/Kconfig
@@ -166,6 +166,7 @@ config BATTERY_BQ27XXX_I2C
 	bool "BQ27xxx I2C support"
 	depends on BATTERY_BQ27XXX
 	depends on I2C
+	depends on !(I2C=m && BATTERY_BQ27XXX=y)
 	default y
 	help
 	  Say Y here to enable support for batteries with BQ27xxx (I2C) chips.
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1266037

FromArnd Bergmann <arnd@arndb.de>
Date2015-11-09 22:40 +0100
Message-ID<qt2kp-3Dy-7@gated-at.bofh.it>
In reply to#1266027
On Monday 09 November 2015 15:23:03 Andrew F. Davis wrote:
> Check if I2C core has been built as a module when BATTERY_BQ27XXX
> is built-in. If so disable I2C functionality.
> 
> Fixes: 6bd03ce3c12a ("power: bq27xxx_battery: Remove unneeded dependency in Kconfig")
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Andrew F. Davis <afd@ti.com>

Thanks for the fix!

Acked-by: Arnd Bergmann <arnd@arndb.de>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1266215 — Re: [PATCH] power: bq27xxx_battery: Add I2C module check dependency in Kconfig

FromSebastian Reichel <sre@kernel.org>
Date2015-11-10 05:00 +0100
SubjectRe: [PATCH] power: bq27xxx_battery: Add I2C module check dependency in Kconfig
Message-ID<qt8g9-8bk-1@gated-at.bofh.it>
In reply to#1266027

[Multipart message — attachments visible in raw view] — view raw

Hi,

On Mon, Nov 09, 2015 at 03:23:03PM -0600, Andrew F. Davis wrote:
> Check if I2C core has been built as a module when BATTERY_BQ27XXX
> is built-in. If so disable I2C functionality.
> 
> Fixes: 6bd03ce3c12a ("power: bq27xxx_battery: Remove unneeded dependency in Kconfig")
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Andrew F. Davis <afd@ti.com>

Thanks, queued.

-- Sebastian

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web