Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1266021 > unrolled thread

Re: [PATCH 25/38] staging: media: davinci_vpfe: fix ipipe_mode type

Started byLaurent Pinchart <laurent.pinchart@ideasonboard.com>
First post2015-11-09 22:20 +0100
Last post2015-11-09 22:20 +0100
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 25/38] staging: media: davinci_vpfe: fix ipipe_mode type Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2015-11-09 22:20 +0100

#1266021 — Re: [PATCH 25/38] staging: media: davinci_vpfe: fix ipipe_mode type

FromLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Date2015-11-09 22:20 +0100
SubjectRe: [PATCH 25/38] staging: media: davinci_vpfe: fix ipipe_mode type
Message-ID<qt215-3od-35@gated-at.bofh.it>
Hi Andrzej,

Thank you for the patch.

On Monday 21 September 2015 15:33:57 Andrzej Hajda wrote:
> The variable can take negative values.
> 
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
> 
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
> 
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

and applied to my tree.

> ---
>  drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
> b/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c index
> 2a3a56b..b1d5e23 100644
> --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
> +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
> @@ -254,7 +254,7 @@ int config_ipipe_hw(struct vpfe_ipipe_device *ipipe)
>  	void __iomem *ipipe_base = ipipe->base_addr;
>  	struct v4l2_mbus_framefmt *outformat;
>  	u32 color_pat;
> -	u32 ipipe_mode;
> +	int ipipe_mode;
>  	u32 data_path;
> 
>  	/* enable clock to IPIPE */

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web