Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1265758 > unrolled thread
| Started by | Ranjith <ranjithece24@gmail.com> |
|---|---|
| First post | 2015-11-09 16:20 +0100 |
| Last post | 2015-11-09 18:00 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] comedi: comedi_parport: Fix coding style - use BIT macro Ranjith <ranjithece24@gmail.com> - 2015-11-09 16:20 +0100
RE: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro Hartley Sweeten <HartleyS@visionengravers.com> - 2015-11-09 18:00 +0100
| From | Ranjith <ranjithece24@gmail.com> |
|---|---|
| Date | 2015-11-09 16:20 +0100 |
| Subject | [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro |
| Message-ID | <qsWoF-89v-7@gated-at.bofh.it> |
BIT macro is used for defining BIT location instead of shifting operator - coding style issue Signed-off-by: Ranjith <ranjithece24@gmail.com> --- drivers/staging/comedi/drivers/comedi_parport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/comedi_parport.c b/drivers/staging/comedi/drivers/comedi_parport.c index 15a4093..1bf8ddc 100644 --- a/drivers/staging/comedi/drivers/comedi_parport.c +++ b/drivers/staging/comedi/drivers/comedi_parport.c @@ -75,8 +75,8 @@ #define PARPORT_DATA_REG 0x00 #define PARPORT_STATUS_REG 0x01 #define PARPORT_CTRL_REG 0x02 -#define PARPORT_CTRL_IRQ_ENA (1 << 4) -#define PARPORT_CTRL_BIDIR_ENA (1 << 5) +#define PARPORT_CTRL_IRQ_ENA BIT(4) +#define PARPORT_CTRL_BIDIR_ENA BIT(5) static int parport_data_reg_insn_bits(struct comedi_device *dev, struct comedi_subdevice *s, -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Hartley Sweeten <HartleyS@visionengravers.com> |
|---|---|
| Date | 2015-11-09 18:00 +0100 |
| Message-ID | <qsXXt-xH-25@gated-at.bofh.it> |
| In reply to | #1265758 |
On Monday, November 09, 2015 8:17 AM, Ranjith wrote: > BIT macro is used for defining BIT location instead of > shifting operator - coding style issue > > Signed-off-by: Ranjith <ranjithece24@gmail.com> > --- > drivers/staging/comedi/drivers/comedi_parport.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/comedi_parport.c b/drivers/staging/comedi/drivers/comedi_parport.c > index 15a4093..1bf8ddc 100644 > --- a/drivers/staging/comedi/drivers/comedi_parport.c > +++ b/drivers/staging/comedi/drivers/comedi_parport.c > @@ -75,8 +75,8 @@ > #define PARPORT_DATA_REG 0x00 > #define PARPORT_STATUS_REG 0x01 > #define PARPORT_CTRL_REG 0x02 > -#define PARPORT_CTRL_IRQ_ENA (1 << 4) > -#define PARPORT_CTRL_BIDIR_ENA (1 << 5) > +#define PARPORT_CTRL_IRQ_ENA BIT(4) > +#define PARPORT_CTRL_BIDIR_ENA BIT(5) > > static int parport_data_reg_insn_bits(struct comedi_device *dev, > struct comedi_subdevice *s, Hello, No problems with the patch but your sign-off needs to include your full legal name. Regards, Hartley -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web