Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1263608 > unrolled thread
| Started by | Andrew Duggan <aduggan@synaptics.com> |
|---|---|
| First post | 2015-11-06 00:40 +0100 |
| Last post | 2015-11-09 14:10 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 07/26] Input: synaptics-rmi4 - f11: fix bitmap irq check Andrew Duggan <aduggan@synaptics.com> - 2015-11-06 00:40 +0100
Re: [PATCH 07/26] Input: synaptics-rmi4 - f11: fix bitmap irq check Linus Walleij <linus.walleij@linaro.org> - 2015-11-09 14:10 +0100
| From | Andrew Duggan <aduggan@synaptics.com> |
|---|---|
| Date | 2015-11-06 00:40 +0100 |
| Subject | [PATCH 07/26] Input: synaptics-rmi4 - f11: fix bitmap irq check |
| Message-ID | <qrCin-57c-43@gated-at.bofh.it> |
From: Benjamin Tissoires <benjamin.tissoires@redhat.com> num_irq_regs is the count of registers of 1 bytes that we use to check the irqs. bitmap_and() expects the number of bits. Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Tested-by: Andrew Duggan <aduggan@synaptics.com> --- drivers/input/rmi4/rmi_f11.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c index 0028176..7fd808f 100644 --- a/drivers/input/rmi4/rmi_f11.c +++ b/drivers/input/rmi4/rmi_f11.c @@ -726,12 +726,12 @@ static void rmi_f11_finger_handler(struct f11_data *f11, } abs_bits = bitmap_and(f11->result_bits, irq_bits, f11->abs_mask, - num_irq_regs); + num_irq_regs * 8); if (abs_bits) rmi_f11_abs_pos_report(f11, sensor, finger_state, i); rel_bits = bitmap_and(f11->result_bits, irq_bits, f11->rel_mask, - num_irq_regs); + num_irq_regs * 8); if (rel_bits) rmi_f11_rel_pos_report(sensor, i); } -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2015-11-09 14:10 +0100 |
| Message-ID | <qsUmT-6Ql-49@gated-at.bofh.it> |
| In reply to | #1263608 |
On Fri, Nov 6, 2015 at 12:38 AM, Andrew Duggan <aduggan@synaptics.com> wrote: > From: Benjamin Tissoires <benjamin.tissoires@redhat.com> > > num_irq_regs is the count of registers of 1 bytes that we use to check > the irqs. bitmap_and() expects the number of bits. > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > Tested-by: Andrew Duggan <aduggan@synaptics.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> This should just be squashed into the offending commit. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web