Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1265630 > unrolled thread

[PATCH] iio: adc: ad7793: removed unnecessary else.

Started byNizam Haider <nizamhaider786@gmail.com>
First post2015-11-09 14:00 +0100
Last post2015-11-15 12:20 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] iio: adc: ad7793: removed unnecessary else. Nizam Haider <nizamhaider786@gmail.com> - 2015-11-09 14:00 +0100
    Re: [PATCH] iio: adc: ad7793: removed unnecessary else. Jonathan Cameron <jic23@kernel.org> - 2015-11-15 12:20 +0100

#1265630 — [PATCH] iio: adc: ad7793: removed unnecessary else.

FromNizam Haider <nizamhaider786@gmail.com>
Date2015-11-09 14:00 +0100
Subject[PATCH] iio: adc: ad7793: removed unnecessary else.
Message-ID<qsUdc-6vT-11@gated-at.bofh.it>
Else is not generally useful after a break or return.

Signed-off-by: Nizam Haider <nijamh@cdac.in>
---
 drivers/iio/adc/ad7793.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/adc/ad7793.c b/drivers/iio/adc/ad7793.c
index eea0c79..3bc5655 100644
--- a/drivers/iio/adc/ad7793.c
+++ b/drivers/iio/adc/ad7793.c
@@ -478,10 +478,9 @@ static int ad7793_read_raw(struct iio_dev *indio_dev,
 				*val2 = st->
 					scale_avail[(st->conf >> 8) & 0x7][1];
 				return IIO_VAL_INT_PLUS_NANO;
-			} else {
-				/* 1170mV / 2^23 * 6 */
-				scale_uv = (1170ULL * 1000000000ULL * 6ULL);
 			}
+			/* 1170mV / 2^23 * 6 */
+			scale_uv = (1170ULL * 1000000000ULL * 6ULL);
 			break;
 		case IIO_TEMP:
 				/* 1170mV / 0.81 mV/C / 2^23 */
-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1269672

FromJonathan Cameron <jic23@kernel.org>
Date2015-11-15 12:20 +0100
Message-ID<qv3vI-DB-17@gated-at.bofh.it>
In reply to#1265630
On 09/11/15 12:50, Nizam Haider wrote:
> Else is not generally useful after a break or return.
> 
> Signed-off-by: Nizam Haider <nijamh@cdac.in>
Applied, thanks.

Jonathan
> ---
>  drivers/iio/adc/ad7793.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad7793.c b/drivers/iio/adc/ad7793.c
> index eea0c79..3bc5655 100644
> --- a/drivers/iio/adc/ad7793.c
> +++ b/drivers/iio/adc/ad7793.c
> @@ -478,10 +478,9 @@ static int ad7793_read_raw(struct iio_dev *indio_dev,
>  				*val2 = st->
>  					scale_avail[(st->conf >> 8) & 0x7][1];
>  				return IIO_VAL_INT_PLUS_NANO;
> -			} else {
> -				/* 1170mV / 2^23 * 6 */
> -				scale_uv = (1170ULL * 1000000000ULL * 6ULL);
>  			}
> +			/* 1170mV / 2^23 * 6 */
> +			scale_uv = (1170ULL * 1000000000ULL * 6ULL);
>  			break;
>  		case IIO_TEMP:
>  				/* 1170mV / 0.81 mV/C / 2^23 */
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web