Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1265485 > unrolled thread

[PATCH] mmc: MMC_GOLDFISH should depend on HAS_DMA

Started byGeert Uytterhoeven <geert@linux-m68k.org>
First post2015-11-09 10:40 +0100
Last post2015-11-09 13:50 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] mmc: MMC_GOLDFISH should depend on HAS_DMA Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-09 10:40 +0100
    Re: [PATCH] mmc: MMC_GOLDFISH should depend on HAS_DMA Ulf Hansson <ulf.hansson@linaro.org> - 2015-11-09 13:50 +0100

#1265485 — [PATCH] mmc: MMC_GOLDFISH should depend on HAS_DMA

FromGeert Uytterhoeven <geert@linux-m68k.org>
Date2015-11-09 10:40 +0100
Subject[PATCH] mmc: MMC_GOLDFISH should depend on HAS_DMA
Message-ID<qsR5E-4AF-31@gated-at.bofh.it>
If NO_DMA=y:

    ERROR: dma_unmap_sg [drivers/mmc/host/android-goldfish.ko] undefined!
    ERROR: dma_alloc_coherent [drivers/mmc/host/android-goldfish.ko] undefined!
    ERROR: dma_map_sg [drivers/mmc/host/android-goldfish.ko] undefined!
    ERROR: dma_free_coherent [drivers/mmc/host/android-goldfish.ko] undefined!

Add a dependency on HAS_DMA to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/mmc/host/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index af71de5fda3b48c9..1dee533634c986d7 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -473,6 +473,7 @@ config MMC_DAVINCI
 
 config MMC_GOLDFISH
 	tristate "goldfish qemu Multimedia Card Interface support"
+	depends on HAS_DMA
 	depends on GOLDFISH || COMPILE_TEST
 	help
 	  This selects the Goldfish Multimedia card Interface emulation
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1265623

FromUlf Hansson <ulf.hansson@linaro.org>
Date2015-11-09 13:50 +0100
Message-ID<qsU3w-6sg-17@gated-at.bofh.it>
In reply to#1265485
On 9 November 2015 at 10:36, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> If NO_DMA=y:
>
>     ERROR: dma_unmap_sg [drivers/mmc/host/android-goldfish.ko] undefined!
>     ERROR: dma_alloc_coherent [drivers/mmc/host/android-goldfish.ko] undefined!
>     ERROR: dma_map_sg [drivers/mmc/host/android-goldfish.ko] undefined!
>     ERROR: dma_free_coherent [drivers/mmc/host/android-goldfish.ko] undefined!
>
> Add a dependency on HAS_DMA to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Thanks, applied for fixes!

Kind regards
Uffe

> ---
>  drivers/mmc/host/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index af71de5fda3b48c9..1dee533634c986d7 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -473,6 +473,7 @@ config MMC_DAVINCI
>
>  config MMC_GOLDFISH
>         tristate "goldfish qemu Multimedia Card Interface support"
> +       depends on HAS_DMA
>         depends on GOLDFISH || COMPILE_TEST
>         help
>           This selects the Goldfish Multimedia card Interface emulation
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web