Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1265483 > unrolled thread

[PATCH] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA

Back to article view | Back to linux.kernel

Contents

  [PATCH] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-09 10:40 +0100
    Re: [PATCH] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA Moritz Fischer <moritz.fischer@ettus.com> - 2015-11-10 18:50 +0100

#1265483 — [PATCH] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA

If NO_DMA=y:

    ERROR: "dma_free_coherent" [drivers/fpga/zynq-fpga.ko] undefined!
    ERROR: "dma_alloc_coherent" [drivers/fpga/zynq-fpga.ko] undefined!

Add a dependency on HAS_DMA to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/fpga/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
index c9b9fdf6cfbbeb6d..d61410299ec0cf80 100644
--- a/drivers/fpga/Kconfig
+++ b/drivers/fpga/Kconfig
@@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA
 
 config FPGA_MGR_ZYNQ_FPGA
 	tristate "Xilinx Zynq FPGA"
+	depends on HAS_DMA
 	help
 	  FPGA manager driver support for Xilinx Zynq FPGAs.
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1266668

Hi Alan, Geert

On Tue, Nov 10, 2015 at 8:28 AM, atull <atull@opensource.altera.com> wrote:
> On Mon, 9 Nov 2015, Geert Uytterhoeven wrote:
>
> +Moritz
>
>> If NO_DMA=y:
>>
>>     ERROR: "dma_free_coherent" [drivers/fpga/zynq-fpga.ko] undefined!
>>     ERROR: "dma_alloc_coherent" [drivers/fpga/zynq-fpga.ko] undefined!
>>
>> Add a dependency on HAS_DMA to fix this.
>>
>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> ---
>>  drivers/fpga/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
>> index c9b9fdf6cfbbeb6d..d61410299ec0cf80 100644
>> --- a/drivers/fpga/Kconfig
>> +++ b/drivers/fpga/Kconfig
>> @@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA
>>
>>  config FPGA_MGR_ZYNQ_FPGA
>>       tristate "Xilinx Zynq FPGA"
>> +     depends on HAS_DMA
>>       help
>>         FPGA manager driver support for Xilinx Zynq FPGAs.
>>
>> --
>> 1.9.1
>>
>>

Good catch!

Reviewed-by: Moritz Fischer <moritz.fischer@ettus.com>

Alan,

if you don't mind I'll send you (or gregkh?) a patch with adding me as
(co) maintainer, or Reviewer to the MAINTAINERS file so you don't have
to forward manually next time
any more ;-) I doubt Geert's patch caught the last issue in zynq-fpga ;-)

Cheers,

Moritz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web