Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1264758 > unrolled thread

[PATCH 8/9] Staging: lustre: llite_lib: Remove wrapper function

Started byShivani Bhardwaj <shivanib134@gmail.com>
First post2015-11-07 08:50 +0100
Last post2015-11-10 04:10 +0100
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 8/9] Staging: lustre: llite_lib: Remove wrapper function Shivani Bhardwaj <shivanib134@gmail.com> - 2015-11-07 08:50 +0100
    Re: [PATCH 8/9] Staging: lustre: llite_lib: Remove wrapper function Michał Kępień <kernel@kempniu.pl> - 2015-11-09 14:40 +0100
      Re: [PATCH 8/9] Staging: lustre: llite_lib: Remove wrapper function Shivani Bhardwaj <shivanib134@gmail.com> - 2015-11-09 17:40 +0100
        RE: [PATCH 8/9] Staging: lustre: llite_lib: Remove wrapper function "Simmons, James A." <simmonsja@ornl.gov> - 2015-11-09 20:20 +0100
          Re: [PATCH 8/9] Staging: lustre: llite_lib: Remove wrapper function Shivani Bhardwaj <shivanib134@gmail.com> - 2015-11-10 04:10 +0100

#1264758 — [PATCH 8/9] Staging: lustre: llite_lib: Remove wrapper function

FromShivani Bhardwaj <shivanib134@gmail.com>
Date2015-11-07 08:50 +0100
Subject[PATCH 8/9] Staging: lustre: llite_lib: Remove wrapper function
Message-ID<qs6q5-7MH-19@gated-at.bofh.it>
Remove the function ll_finish_md_op_data() and replace all its calls
with the standrd function ll_finish_md_op_data().

Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
 drivers/staging/lustre/lustre/llite/llite_lib.c | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c b/drivers/staging/lustre/lustre/llite/llite_lib.c
index 4a8c759..143be87 100644
--- a/drivers/staging/lustre/lustre/llite/llite_lib.c
+++ b/drivers/staging/lustre/lustre/llite/llite_lib.c
@@ -1355,7 +1355,7 @@ out:
 		if (!rc)
 			rc = rc1;
 	}
-	ll_finish_md_op_data(op_data);
+	kfree(op_data);
 
 	if (!S_ISDIR(inode->i_mode)) {
 		mutex_lock(&inode->i_mutex);
@@ -1732,7 +1732,7 @@ int ll_iocontrol(struct inode *inode, struct file *file,
 
 		op_data->op_valid = OBD_MD_FLFLAGS;
 		rc = md_getattr(sbi->ll_md_exp, op_data, &req);
-		ll_finish_md_op_data(op_data);
+		kfree(op_data);
 		if (rc) {
 			CERROR("failure %d inode %lu\n", rc, inode->i_ino);
 			return -abs(rc);
@@ -1763,7 +1763,7 @@ int ll_iocontrol(struct inode *inode, struct file *file,
 		op_data->op_attr.ia_valid |= ATTR_ATTR_FLAG;
 		rc = md_setattr(sbi->ll_md_exp, op_data,
 				NULL, 0, NULL, 0, &req, NULL);
-		ll_finish_md_op_data(op_data);
+		kfree(op_data);
 		ptlrpc_req_finished(req);
 		if (rc)
 			return rc;
@@ -1934,7 +1934,7 @@ void ll_open_cleanup(struct super_block *sb, struct ptlrpc_request *open_req)
 	op_data->op_mod_time = get_seconds();
 	md_close(exp, op_data, NULL, &close_req);
 	ptlrpc_req_finished(close_req);
-	ll_finish_md_op_data(op_data);
+	kfree(op_data);
 }
 
 int ll_prep_inode(struct inode **inode, struct ptlrpc_request *req,
@@ -2170,11 +2170,6 @@ struct md_op_data *ll_prep_md_op_data(struct md_op_data *op_data,
 	return op_data;
 }
 
-void ll_finish_md_op_data(struct md_op_data *op_data)
-{
-	kfree(op_data);
-}
-
 int ll_show_options(struct seq_file *seq, struct dentry *dentry)
 {
 	struct ll_sb_info *sbi;
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1265673

FromMichał Kępień <kernel@kempniu.pl>
Date2015-11-09 14:40 +0100
Message-ID<qsUPV-70f-39@gated-at.bofh.it>
In reply to#1264758
> Remove the function ll_finish_md_op_data() and replace all its calls
> with the standrd function ll_finish_md_op_data().

I believe you meant to write "standard function kfree()".

-- 
Best regards,
Michał Kępień
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1265835

FromShivani Bhardwaj <shivanib134@gmail.com>
Date2015-11-09 17:40 +0100
Message-ID<qsXE6-pE-11@gated-at.bofh.it>
In reply to#1265673
On Mon, Nov 9, 2015 at 7:07 PM, Michał Kępień <kernel@kempniu.pl> wrote:
>> Remove the function ll_finish_md_op_data() and replace all its calls
>> with the standrd function ll_finish_md_op_data().
>
> I believe you meant to write "standard function kfree()".
>

Yes. I am so sorry. Should I be sending the whole series again?
Thank you
Shivani

> --
> Best regards,
> Michał Kępień
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1265956

From"Simmons, James A." <simmonsja@ornl.gov>
Date2015-11-09 20:20 +0100
Message-ID<qt08V-29B-15@gated-at.bofh.it>
In reply to#1265835
Pk9uIE1vbiwgTm92IDksIDIwMTUgYXQgNzowNyBQTSwgTWljaGHFgiBLxJlwaWXFhCA8a2VybmVs
QGtlbXBuaXUucGw+IHdyb3RlOg0KPj4+IFJlbW92ZSB0aGUgZnVuY3Rpb24gbGxfZmluaXNoX21k
X29wX2RhdGEoKSBhbmQgcmVwbGFjZSBhbGwgaXRzIGNhbGxzDQo+Pj4gd2l0aCB0aGUgc3RhbmRy
ZCBmdW5jdGlvbiBsbF9maW5pc2hfbWRfb3BfZGF0YSgpLg0KPj4NCj4+IEkgYmVsaWV2ZSB5b3Ug
bWVhbnQgdG8gd3JpdGUgInN0YW5kYXJkIGZ1bmN0aW9uIGtmcmVlKCkiLg0KPj4NCj4NCj5ZZXMu
IEkgYW0gc28gc29ycnkuIFNob3VsZCBJIGJlIHNlbmRpbmcgdGhlIHdob2xlIHNlcmllcyBhZ2Fp
bj8NCj5UaGFuayB5b3UNCj5TaGl2YW5pDQoNClllcyBwbGVhc2UgcmVkbyB0aGUgc2VyaWVzLiBJ
IHNhdyBPbGVnJ3MgY29uY2VybiBhbmQgSSB3b3VsZCByZWNvbW1lbmQgdGhhdA0KYmVzaWRlcyB0
aGUgY29udmVyc2lvbiB0byBrZnJlZSB0aGF0IHlvdSBhZGQgY29tbWVudHMgYWJvdXQgd2hhdCBp
cyBiZWluZyBkZWxldGVkLg0KSS5FDQoNCi8qIEZyZWUgc3RydWN0IG1kX29wX2RhdGEgIGRhdGEq
Lw0Ka2ZyZWUoLi4uKQ0K
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1266194

FromShivani Bhardwaj <shivanib134@gmail.com>
Date2015-11-10 04:10 +0100
Message-ID<qt7tM-7Nw-1@gated-at.bofh.it>
In reply to#1265956
On Tue, Nov 10, 2015 at 12:48 AM, Simmons, James A. <simmonsja@ornl.gov> wrote:
>>On Mon, Nov 9, 2015 at 7:07 PM, Michał Kępień <kernel@kempniu.pl> wrote:
>>>> Remove the function ll_finish_md_op_data() and replace all its calls
>>>> with the standrd function ll_finish_md_op_data().
>>>
>>> I believe you meant to write "standard function kfree()".
>>>
>>
>>Yes. I am so sorry. Should I be sending the whole series again?
>>Thank you
>>Shivani
>
> Yes please redo the series. I saw Oleg's concern and I would recommend that
> besides the conversion to kfree that you add comments about what is being deleted.
> I.E
>
> /* Free struct md_op_data  data*/
> kfree(...)

I'll do that.
Thank you
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web