Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1263391 > unrolled thread

Re: [RESEND PATCH] USB: usbmon: Use 64bit timestamp for mon_bin_hdr

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [RESEND PATCH] USB: usbmon: Use 64bit timestamp for mon_bin_hdr Arnd Bergmann <arnd@arndb.de> - 2015-11-05 17:20 +0100
    Re: [RESEND PATCH] USB: usbmon: Use 64bit timestamp for mon_bin_hdr Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-11-05 17:40 +0100
      Re: [RESEND PATCH] USB: usbmon: Use 64bit timestamp for mon_bin_hdr Arnd Bergmann <arnd@arndb.de> - 2015-11-05 20:10 +0100

#1263391 — Re: [RESEND PATCH] USB: usbmon: Use 64bit timestamp for mon_bin_hdr

On Thursday 29 October 2015 22:44:31 Tina Ruchandani wrote:
> struct mon_bin_hdr allows for a 64-bit seconds timestamp. The code
> currently uses 'struct timeval' to populate the timestamp in mon_bin_hdr,
> which has a 32-bit seconds field and will overflow in year 2038 and beyond.
> This patch replaces 'struct timeval' with 'struct timespec64' which is
> y2038 safe. This patch is part of a larger attempt to remove instances
> of struct timeval and other 32-bit timekeeping (time_t, struct timespec)
> from the kernel.
> 
> Signed-off-by: Tina Ruchandani <ruchandani.tina@gmail.com>

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

As the patch is a week old and Greg hasn't picked it up yet, I'm guessing
that he doesn't have it in his queue any more and you should send it once
more with my 'Reviewed-by' tag.

> @@ -494,7 +495,7 @@ static void mon_bin_event(struct mon_reader_bin *rp, struct urb *urb,
>         struct mon_bin_hdr *ep;
>         char data_tag = 0;
>  
> -       do_gettimeofday(&ts);
> +       getnstimeofday64(&ts);
>  
>         spin_lock_irqsave(&rp->b_lock, flags);
>  

This is a very minor comment I still have, and the patch is fine as it, but
I tend to prefer ktime_get_real_ts64() over getnstimeofday64() these days.
The two functions do the exact same thing, and I hope to remove the latter
eventually.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1263405

On Thu, Nov 05, 2015 at 05:18:41PM +0100, Arnd Bergmann wrote:
> On Thursday 29 October 2015 22:44:31 Tina Ruchandani wrote:
> > struct mon_bin_hdr allows for a 64-bit seconds timestamp. The code
> > currently uses 'struct timeval' to populate the timestamp in mon_bin_hdr,
> > which has a 32-bit seconds field and will overflow in year 2038 and beyond.
> > This patch replaces 'struct timeval' with 'struct timespec64' which is
> > y2038 safe. This patch is part of a larger attempt to remove instances
> > of struct timeval and other 32-bit timekeeping (time_t, struct timespec)
> > from the kernel.
> > 
> > Signed-off-by: Tina Ruchandani <ruchandani.tina@gmail.com>
> 
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> 
> As the patch is a week old and Greg hasn't picked it up yet, I'm guessing
> that he doesn't have it in his queue any more and you should send it once
> more with my 'Reviewed-by' tag.

It's the merge window, I can't pick anything new up, please be patient
and wait for 4.4-rc1 to come out first...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1263491

On Thursday 05 November 2015 08:37:39 Greg Kroah-Hartman wrote:
> On Thu, Nov 05, 2015 at 05:18:41PM +0100, Arnd Bergmann wrote:
> > On Thursday 29 October 2015 22:44:31 Tina Ruchandani wrote:
> > > struct mon_bin_hdr allows for a 64-bit seconds timestamp. The code
> > > currently uses 'struct timeval' to populate the timestamp in mon_bin_hdr,
> > > which has a 32-bit seconds field and will overflow in year 2038 and beyond.
> > > This patch replaces 'struct timeval' with 'struct timespec64' which is
> > > y2038 safe. This patch is part of a larger attempt to remove instances
> > > of struct timeval and other 32-bit timekeeping (time_t, struct timespec)
> > > from the kernel.
> > > 
> > > Signed-off-by: Tina Ruchandani <ruchandani.tina@gmail.com>
> > 
> > Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> > 
> > As the patch is a week old and Greg hasn't picked it up yet, I'm guessing
> > that he doesn't have it in his queue any more and you should send it once
> > more with my 'Reviewed-by' tag.
> 
> It's the merge window, I can't pick anything new up, please be patient
> and wait for 4.4-rc1 to come out first...

Sorry, I wasn't thinking straight.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web