Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1262109 > unrolled thread
| Started by | yalin wang <yalin.wang2010@gmail.com> |
|---|---|
| First post | 2015-11-04 09:00 +0100 |
| Last post | 2015-11-05 16:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[RFC] ext4: fix a BUG in ext4_mpage_readpages() yalin wang <yalin.wang2010@gmail.com> - 2015-11-04 09:00 +0100
Re: [RFC] ext4: fix a BUG in ext4_mpage_readpages() Jan Kara <jack@suse.cz> - 2015-11-05 16:50 +0100
| From | yalin wang <yalin.wang2010@gmail.com> |
|---|---|
| Date | 2015-11-04 09:00 +0100 |
| Subject | [RFC] ext4: fix a BUG in ext4_mpage_readpages() |
| Message-ID | <qr199-603-21@gated-at.bofh.it> |
The last block should be the total read pages last block, need adjust the block number when caculate every page. Signed-off-by: yalin wang <yalin.wang2010@gmail.com> --- fs/ext4/readpage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/readpage.c b/fs/ext4/readpage.c index 5dc5e95..d20c39d 100644 --- a/fs/ext4/readpage.c +++ b/fs/ext4/readpage.c @@ -174,7 +174,7 @@ int ext4_mpage_readpages(struct address_space *mapping, goto confused; block_in_file = (sector_t)page->index << (PAGE_CACHE_SHIFT - blkbits); - last_block = block_in_file + nr_pages * blocks_per_page; + last_block = block_in_file + (nr_pages - page_idx) * blocks_per_page; last_block_in_file = (i_size_read(inode) + blocksize - 1) >> blkbits; if (last_block > last_block_in_file) last_block = last_block_in_file; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Jan Kara <jack@suse.cz> |
|---|---|
| Date | 2015-11-05 16:50 +0100 |
| Message-ID | <qruXw-6f-19@gated-at.bofh.it> |
| In reply to | #1262109 |
On Wed 04-11-15 15:58:34, yalin wang wrote: > The last block should be the total read pages last block, > need adjust the block number when caculate every page. > > Signed-off-by: yalin wang <yalin.wang2010@gmail.com> > --- > fs/ext4/readpage.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext4/readpage.c b/fs/ext4/readpage.c > index 5dc5e95..d20c39d 100644 > --- a/fs/ext4/readpage.c > +++ b/fs/ext4/readpage.c > @@ -174,7 +174,7 @@ int ext4_mpage_readpages(struct address_space *mapping, > goto confused; > > block_in_file = (sector_t)page->index << (PAGE_CACHE_SHIFT - blkbits); > - last_block = block_in_file + nr_pages * blocks_per_page; > + last_block = block_in_file + (nr_pages - page_idx) * blocks_per_page; I don't think your patch is correct. The for loop decrements nr_pages at each iteration so the original code looks fine... Or which problems do you observe? Honza > last_block_in_file = (i_size_read(inode) + blocksize - 1) >> blkbits; > if (last_block > last_block_in_file) > last_block = last_block_in_file; > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Jan Kara <jack@suse.com> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web