Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1264603 > unrolled thread
| Started by | Javier Martinez Canillas <javier@dowhile0.org> |
|---|---|
| First post | 2015-11-06 23:20 +0100 |
| Last post | 2015-11-06 23:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] arm64: dts: Added syscon-reboot node for FSL's LS2080A SoC Javier Martinez Canillas <javier@dowhile0.org> - 2015-11-06 23:20 +0100
RE: [PATCH] arm64: dts: Added syscon-reboot node for FSL's LS2080A SoC Jose Rivera <German.Rivera@freescale.com> - 2015-11-06 23:50 +0100
| From | Javier Martinez Canillas <javier@dowhile0.org> |
|---|---|
| Date | 2015-11-06 23:20 +0100 |
| Subject | Re: [PATCH] arm64: dts: Added syscon-reboot node for FSL's LS2080A SoC |
| Message-ID | <qrXwu-25P-9@gated-at.bofh.it> |
Hello J. German,
On Fri, Nov 6, 2015 at 6:48 PM, J. German Rivera
<German.Rivera@freescale.com> wrote:
> Added sys-reboot node to the FSL's LS2080A SoC DT to leverage
> the ARM-generic reboot mechanism for this SoC. This mechanism
> is enabled through CONFIG_POWER_RESET_SYSCON.
>
What's in the changelog ends as a part of the commit message and
usually the change history is not added there...
> CHANGE HISTORY:
>
> Changes in v3:
> - Addressed comment from Stuart Yoder
> * Fixed commit message to refer to LS2080A instead of LS2085A.
>
> Changes in v2:
> - Addressed comment form Stuart Yoder:
> * Removed "@<address>" from reboot node
>
> Changes in v3:
> - Addressed comment form Stuart Yoder:
> * Expose only the reset register
>
> Changes in v4:
> - Addressed comment from Arnd Bergmann:
> * Changed compatible string to be more specific
> * Changed node name to 'syscon' instead of 'rstcr'
> * Changed address to lower case hex
> - Addressed comment form Stuart Yoder:
> * Rebase on top of branch arm-soc/for-next
>
> Signed-off-by: J. German Rivera <German.Rivera@freescale.com>
> ---
...so the change history should be added here, between the '---'
marker line and the patch diff since that section is omitted by tools
like git-am when applying patches.
> arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
> index e81cd48..a790a90 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
> @@ -153,6 +153,18 @@
> };
> };
>
> + rstcr: syscon@1e60000 {
> + compatible = "fsl,ls2085a-rstcr", "syscon";
> + reg = <0x0 0x1e60000 0x0 0x4>;
> + };
> +
> + reboot {
> + compatible ="syscon-reboot";
> + regmap = <&rstcr>;
> + offset = <0x0>;
> + mask = <0x2>;
> + };
> +
> timer {
> compatible = "arm,armv8-timer";
> interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */
> --
The patch looks good to me though.
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Jose Rivera <German.Rivera@freescale.com> |
|---|---|
| Date | 2015-11-06 23:50 +0100 |
| Subject | RE: [PATCH] arm64: dts: Added syscon-reboot node for FSL's LS2080A SoC |
| Message-ID | <qrXZv-2gc-9@gated-at.bofh.it> |
| In reply to | #1264603 |
PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBKYXZpZXIgTWFydGluZXogQ2Fu aWxsYXMgW21haWx0bzpqYXZpZXJAZG93aGlsZTAub3JnXQ0KPiBTZW50OiBGcmlkYXksIE5vdmVt YmVyIDA2LCAyMDE1IDQ6MTMgUE0NCj4gVG86IFJpdmVyYSBKb3NlLUI0NjQ4Mg0KPiBDYzogUm9i IEhlcnJpbmc7IE1hcmsgUnV0bGFuZDsgZGV2aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4 LWFybS0NCj4ga2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc7IExpbnV4IEtlcm5lbDsgU2hhcm1h IEJodXBlc2gtQjQ1MzcwOyBMaSBZYW5nLQ0KPiBMZW8tUjU4NDcyOyBZb2RlciBTdHVhcnQtQjA4 MjQ4DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIGFybTY0OiBkdHM6IEFkZGVkIHN5c2Nvbi1yZWJv b3Qgbm9kZSBmb3IgRlNMJ3MNCj4gTFMyMDgwQSBTb0MNCj4gDQo+IEhlbGxvIEouIEdlcm1hbiwN Cj4gDQo+IE9uIEZyaSwgTm92IDYsIDIwMTUgYXQgNjo0OCBQTSwgSi4gR2VybWFuIFJpdmVyYQ0K PiA8R2VybWFuLlJpdmVyYUBmcmVlc2NhbGUuY29tPiB3cm90ZToNCj4gPiBBZGRlZCBzeXMtcmVi b290IG5vZGUgdG8gdGhlIEZTTCdzIExTMjA4MEEgU29DIERUIHRvIGxldmVyYWdlIHRoZQ0KPiA+ IEFSTS1nZW5lcmljIHJlYm9vdCBtZWNoYW5pc20gZm9yIHRoaXMgU29DLiBUaGlzIG1lY2hhbmlz bSBpcyBlbmFibGVkDQo+ID4gdGhyb3VnaCBDT05GSUdfUE9XRVJfUkVTRVRfU1lTQ09OLg0KPiA+ DQo+IA0KPiBXaGF0J3MgaW4gdGhlIGNoYW5nZWxvZyBlbmRzIGFzIGEgcGFydCBvZiB0aGUgY29t bWl0IG1lc3NhZ2UgYW5kIHVzdWFsbHkNCj4gdGhlIGNoYW5nZSBoaXN0b3J5IGlzIG5vdCBhZGRl ZCB0aGVyZS4uLg0KPiANCllvdSBhcmUgcmlnaHQsIHRoYW5rcy4gSSBmb3Jnb3QgdG8gbW92ZSB0 aGUgQ0hBTkdFIEhJU1RPUlkgdG8gYmUgYmVsb3cgdGhlICItLS0iDQpNYXJrZXIuIEknbGwgcmVw b3N0IHRoZSBwYXRjaC4NCg0KPiA+IENIQU5HRSBISVNUT1JZOg0KPiA+DQo+ID4gQ2hhbmdlcyBp biB2MzoNCj4gPiAtIEFkZHJlc3NlZCBjb21tZW50IGZyb20gU3R1YXJ0IFlvZGVyDQo+ID4gICAq IEZpeGVkIGNvbW1pdCBtZXNzYWdlIHRvIHJlZmVyIHRvIExTMjA4MEEgaW5zdGVhZCBvZiBMUzIw ODVBLg0KPiA+DQo+ID4gQ2hhbmdlcyBpbiB2MjoNCj4gPiAtIEFkZHJlc3NlZCBjb21tZW50IGZv cm0gU3R1YXJ0IFlvZGVyOg0KPiA+ICAgKiBSZW1vdmVkICJAPGFkZHJlc3M+IiBmcm9tIHJlYm9v dCBub2RlDQo+ID4NCj4gPiBDaGFuZ2VzIGluIHYzOg0KPiA+IC0gQWRkcmVzc2VkIGNvbW1lbnQg Zm9ybSBTdHVhcnQgWW9kZXI6DQo+ID4gICAqIEV4cG9zZSBvbmx5IHRoZSByZXNldCByZWdpc3Rl cg0KPiA+DQo+ID4gQ2hhbmdlcyBpbiB2NDoNCj4gPiAtIEFkZHJlc3NlZCBjb21tZW50IGZyb20g QXJuZCBCZXJnbWFubjoNCj4gPiAgICogQ2hhbmdlZCBjb21wYXRpYmxlIHN0cmluZyB0byBiZSBt b3JlIHNwZWNpZmljDQo+ID4gICAqIENoYW5nZWQgbm9kZSBuYW1lIHRvICdzeXNjb24nIGluc3Rl YWQgb2YgJ3JzdGNyJw0KPiA+ICAgKiBDaGFuZ2VkIGFkZHJlc3MgdG8gbG93ZXIgY2FzZSBoZXgN Cj4gPiAtIEFkZHJlc3NlZCBjb21tZW50IGZvcm0gU3R1YXJ0IFlvZGVyOg0KPiA+ICAgKiBSZWJh c2Ugb24gdG9wIG9mIGJyYW5jaCBhcm0tc29jL2Zvci1uZXh0DQo+ID4NCj4gPiBTaWduZWQtb2Zm LWJ5OiBKLiBHZXJtYW4gUml2ZXJhIDxHZXJtYW4uUml2ZXJhQGZyZWVzY2FsZS5jb20+DQo+ID4g LS0tDQo+IA0KPiAuLi5zbyB0aGUgY2hhbmdlIGhpc3Rvcnkgc2hvdWxkIGJlIGFkZGVkIGhlcmUs IGJldHdlZW4gdGhlICctLS0nDQo+IG1hcmtlciBsaW5lIGFuZCB0aGUgcGF0Y2ggZGlmZiBzaW5j ZSB0aGF0IHNlY3Rpb24gaXMgb21pdHRlZCBieSB0b29scw0KPiBsaWtlIGdpdC1hbSB3aGVuIGFw cGx5aW5nIHBhdGNoZXMuDQo+IA0KPiA+ICBhcmNoL2FybTY0L2Jvb3QvZHRzL2ZyZWVzY2FsZS9m c2wtbHMyMDgwYS5kdHNpIHwgMTIgKysrKysrKysrKysrDQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAx MiBpbnNlcnRpb25zKCspDQo+ID4NCj4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0 cy9mcmVlc2NhbGUvZnNsLWxzMjA4MGEuZHRzaQ0KPiA+IGIvYXJjaC9hcm02NC9ib290L2R0cy9m cmVlc2NhbGUvZnNsLWxzMjA4MGEuZHRzaQ0KPiA+IGluZGV4IGU4MWNkNDguLmE3OTBhOTAgMTAw NjQ0DQo+ID4gLS0tIGEvYXJjaC9hcm02NC9ib290L2R0cy9mcmVlc2NhbGUvZnNsLWxzMjA4MGEu ZHRzaQ0KPiA+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvZnJlZXNjYWxlL2ZzbC1sczIwODBh LmR0c2kNCj4gPiBAQCAtMTUzLDYgKzE1MywxOCBAQA0KPiA+ICAgICAgICAgICAgICAgICB9Ow0K PiA+ICAgICAgICAgfTsNCj4gPg0KPiA+ICsgICAgICAgcnN0Y3I6IHN5c2NvbkAxZTYwMDAwIHsN Cj4gPiArICAgICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJmc2wsbHMyMDg1YS1yc3RjciIsICJz eXNjb24iOw0KPiA+ICsgICAgICAgICAgICAgICByZWcgPSA8MHgwIDB4MWU2MDAwMCAweDAgMHg0 PjsNCj4gPiArICAgICAgIH07DQo+ID4gKw0KPiA+ICsgICAgICAgcmVib290IHsNCj4gPiArICAg ICAgICAgICAgICAgY29tcGF0aWJsZSA9InN5c2Nvbi1yZWJvb3QiOw0KPiA+ICsgICAgICAgICAg ICAgICByZWdtYXAgPSA8JnJzdGNyPjsNCj4gPiArICAgICAgICAgICAgICAgb2Zmc2V0ID0gPDB4 MD47DQo+ID4gKyAgICAgICAgICAgICAgIG1hc2sgPSA8MHgyPjsNCj4gPiArICAgICAgIH07DQo+ ID4gKw0KPiA+ICAgICAgICAgdGltZXIgew0KPiA+ICAgICAgICAgICAgICAgICBjb21wYXRpYmxl ID0gImFybSxhcm12OC10aW1lciI7DQo+ID4gICAgICAgICAgICAgICAgIGludGVycnVwdHMgPSA8 MSAxMyAweDg+LCAvKiBQaHlzaWNhbCBTZWN1cmUgUFBJLA0KPiA+IGFjdGl2ZS1sb3cgKi8NCj4g PiAtLQ0KPiANCj4gVGhlIHBhdGNoIGxvb2tzIGdvb2QgdG8gbWUgdGhvdWdoLg0KPiANCj4gUmV2 aWV3ZWQtYnk6IEphdmllciBNYXJ0aW5leiBDYW5pbGxhcyA8amF2aWVyQG9zZy5zYW1zdW5nLmNv bT4NCj4gDQo+IEJlc3QgcmVnYXJkcywNCj4gSmF2aWVyDQo= -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web