Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1264197 > unrolled thread
| Started by | Shivani Bhardwaj <shivanib134@gmail.com> |
|---|---|
| First post | 2015-11-06 18:50 +0100 |
| Last post | 2015-11-06 23:10 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/3] Remove wrapper functions from ldlm_pool Shivani Bhardwaj <shivanib134@gmail.com> - 2015-11-06 18:50 +0100
[PATCH 2/3] Staging: lustre: ldlm_pool: Drop wrapper function Shivani Bhardwaj <shivanib134@gmail.com> - 2015-11-06 18:50 +0100
RE: [PATCH 2/3] Staging: lustre: ldlm_pool: Drop wrapper function "Simmons, James A." <simmonsja@ornl.gov> - 2015-11-06 23:10 +0100
| From | Shivani Bhardwaj <shivanib134@gmail.com> |
|---|---|
| Date | 2015-11-06 18:50 +0100 |
| Subject | [PATCH 0/3] Remove wrapper functions from ldlm_pool |
| Message-ID | <qrTjb-7zi-3@gated-at.bofh.it> |
This patchset removes different wrapper functions from the file ldlm_pool and replaces their calls with the function they wrapped. After applying this patchset, code becomes cleaner. Shivani Bhardwaj (3): Staging: lustre: ldlm_pool: Remove unneeded wrapper function Staging: lustre: ldlm_pool: Drop wrapper function Staging: lustre: ldlm_pool: Drop unneeded wrapper function drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 47 +++++++++----------------- 1 file changed, 16 insertions(+), 31 deletions(-) -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Shivani Bhardwaj <shivanib134@gmail.com> |
|---|---|
| Date | 2015-11-06 18:50 +0100 |
| Subject | [PATCH 2/3] Staging: lustre: ldlm_pool: Drop wrapper function |
| Message-ID | <qrTjc-7zi-15@gated-at.bofh.it> |
| In reply to | #1264197 |
Remove the function ldlm_pool_get_limit() and replace its calls with the
function it wrapped.
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c b/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
index 2beb36b..20cf389 100644
--- a/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
+++ b/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
@@ -208,14 +208,6 @@ static inline int ldlm_pool_t2gsp(unsigned int t)
}
/**
- * Returns current \a pl limit.
- */
-static __u32 ldlm_pool_get_limit(struct ldlm_pool *pl)
-{
- return atomic_read(&pl->pl_limit);
-}
-
-/**
* Sets passed \a limit to \a pl.
*/
static void ldlm_pool_set_limit(struct ldlm_pool *pl, __u32 limit)
@@ -452,7 +444,7 @@ static int lprocfs_pool_state_seq_show(struct seq_file *m, void *unused)
spin_lock(&pl->pl_lock);
slv = pl->pl_server_lock_volume;
clv = pl->pl_client_lock_volume;
- limit = ldlm_pool_get_limit(pl);
+ limit = atomic_read(&pl->pl_limit);
granted = atomic_read(&pl->pl_granted);
grant_rate = atomic_read(&pl->pl_grant_rate);
cancel_rate = atomic_read(&pl->pl_cancel_rate);
--
2.1.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Simmons, James A." <simmonsja@ornl.gov> |
|---|---|
| Date | 2015-11-06 23:10 +0100 |
| Subject | RE: [PATCH 2/3] Staging: lustre: ldlm_pool: Drop wrapper function |
| Message-ID | <qrXmO-21f-1@gated-at.bofh.it> |
| In reply to | #1264198 |
>-----Original Message-----
>From: devel [mailto:driverdev-devel-bounces@linuxdriverproject.org] On Behalf Of Shivani Bhardwaj
>Sent: Friday, November 06, 2015 12:44 PM
>To: gregkh@linuxfoundation.org
>Cc: oleg.drokin@intel.com; devel@driverdev.osuosl.org; andreas.dilger@intel.com; linux-kernel@vger.kernel.org
>Subject: [PATCH 2/3] Staging: lustre: ldlm_pool: Drop wrapper function
>
>Remove the function ldlm_pool_get_limit() and replace its calls with the
>function it wrapped.
>
>Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
>---
> drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
Acked-by: James Simmons <jsimmons@infradead.org>
diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c b/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
index 2beb36b..20cf389 100644
--- a/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
+++ b/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
@@ -208,14 +208,6 @@ static inline int ldlm_pool_t2gsp(unsigned int t)
}
/**
- * Returns current \a pl limit.
- */
-static __u32 ldlm_pool_get_limit(struct ldlm_pool *pl)
-{
- return atomic_read(&pl->pl_limit);
-}
-
-/**
* Sets passed \a limit to \a pl.
*/
static void ldlm_pool_set_limit(struct ldlm_pool *pl, __u32 limit)
@@ -452,7 +444,7 @@ static int lprocfs_pool_state_seq_show(struct seq_file *m, void *unused)
spin_lock(&pl->pl_lock);
slv = pl->pl_server_lock_volume;
clv = pl->pl_client_lock_volume;
- limit = ldlm_pool_get_limit(pl);
+ limit = atomic_read(&pl->pl_limit);
granted = atomic_read(&pl->pl_granted);
grant_rate = atomic_read(&pl->pl_grant_rate);
cancel_rate = atomic_read(&pl->pl_cancel_rate);
--
2.1.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web