Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1262421 > unrolled thread

[PATCH RESEND] toshiba_acpi: Initialize hotkey_event_type variable

Back to article view | Back to linux.kernel

Contents

  [PATCH RESEND] toshiba_acpi: Initialize hotkey_event_type variable Azael Avalos <coproscefalo@gmail.com> - 2015-11-04 17:30 +0100
    Re: [PATCH RESEND] toshiba_acpi: Initialize hotkey_event_type  variable Darren Hart <dvhart@infradead.org> - 2015-11-04 17:50 +0100
    Re: [PATCH RESEND] toshiba_acpi: Initialize hotkey_event_type  variable Darren Hart <dvhart@infradead.org> - 2015-11-06 01:20 +0100

#1262421 — [PATCH RESEND] toshiba_acpi: Initialize hotkey_event_type variable

Commit 23f8f4326a15 ("toshiba_acpi: Fix hotkeys registration on some
toshiba models") fixed an issue on some laptops regarding hotkeys
registration, however, if failed to address the initialization of the
hotkey_event_type variable, and thus, it can lead to potential
unwanted effects as the variable is being checked.

This patch initializes such variable to avoid such unwanted effects.

Cc: <stable@vger.kernel.org> # 4.1+
Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
---
 drivers/platform/x86/toshiba_acpi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c
index beb709f..c013029 100644
--- a/drivers/platform/x86/toshiba_acpi.c
+++ b/drivers/platform/x86/toshiba_acpi.c
@@ -2665,6 +2665,7 @@ static int toshiba_acpi_add(struct acpi_device *acpi_dev)
 	ret = toshiba_function_keys_get(dev, &dev->special_functions);
 	dev->kbd_function_keys_supported = !ret;
 
+	dev->hotkey_event_type = 0;
 	if (toshiba_acpi_setup_keyboard(dev))
 		pr_info("Unable to activate hotkeys\n");
 
-- 
2.6.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1262436 — Re: [PATCH RESEND] toshiba_acpi: Initialize hotkey_event_type variable

On Wed, Nov 04, 2015 at 09:28:26AM -0700, Azael Avalos wrote:
> Commit 23f8f4326a15 ("toshiba_acpi: Fix hotkeys registration on some
> toshiba models") fixed an issue on some laptops regarding hotkeys
> registration, however, if failed to address the initialization of the
> hotkey_event_type variable, and thus, it can lead to potential
> unwanted effects as the variable is being checked.
> 
> This patch initializes such variable to avoid such unwanted effects.
> 
> Cc: <stable@vger.kernel.org> # 4.1+
> Signed-off-by: Azael Avalos <coproscefalo@gmail.com>

Applied, thanks Azael.
-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1263651 — Re: [PATCH RESEND] toshiba_acpi: Initialize hotkey_event_type variable

On Wed, Nov 04, 2015 at 09:28:26AM -0700, Azael Avalos wrote:
> Commit 23f8f4326a15 ("toshiba_acpi: Fix hotkeys registration on some

Note that the above commit ID does not exist in mainline. The corresponding ID
is 53147b6cabee5e8d1997b5682fcc0c3b72ddf9c2. Please always use the mainling
commit ID (as opposed to one from your development tree) when referring to a
commit. I've corrected this it the version I'll submit to Linus.

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web