Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1261135 > unrolled thread
| Started by | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| First post | 2015-11-03 03:00 +0100 |
| Last post | 2015-11-06 01:40 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v3 3/7] ARCH: EXYNOS: split up exynos3250 SoC specific PMU data Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-03 03:00 +0100
Re: [PATCH v3 3/7] ARCH: EXYNOS: split up exynos3250 SoC specific PMU data Pankaj Dubey <pankaj.dubey@samsung.com> - 2015-11-05 06:40 +0100
Re: [PATCH v3 3/7] ARCH: EXYNOS: split up exynos3250 SoC specific PMU data Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-06 01:40 +0100
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2015-11-03 03:00 +0100 |
| Subject | Re: [PATCH v3 3/7] ARCH: EXYNOS: split up exynos3250 SoC specific PMU data |
| Message-ID | <qqz3d-4xe-25@gated-at.bofh.it> |
On 26.10.2015 21:55, Pankaj Dubey wrote:
> This patch splits up mach-exynos/pmu.c file, and moves exynos3250 PMU
> configuration data and functions handing those data into exynos3250
> SoC specific PMU file mach-exynos/exynos3250-pmu.c.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
> arch/arm/mach-exynos/Makefile | 2 +-
> arch/arm/mach-exynos/exynos-pmu.h | 47 +++++++++
> arch/arm/mach-exynos/exynos3250-pmu.c | 175 +++++++++++++++++++++++++++++++
> arch/arm/mach-exynos/pmu.c | 189 +---------------------------------
> 4 files changed, 224 insertions(+), 189 deletions(-)
> create mode 100644 arch/arm/mach-exynos/exynos-pmu.h
> create mode 100644 arch/arm/mach-exynos/exynos3250-pmu.c
>
> diff --git a/arch/arm/mach-exynos/Makefile b/arch/arm/mach-exynos/Makefile
> index 2f30676..e869f86 100644
> --- a/arch/arm/mach-exynos/Makefile
> +++ b/arch/arm/mach-exynos/Makefile
> @@ -9,7 +9,7 @@ ccflags-$(CONFIG_ARCH_MULTIPLATFORM) += -I$(srctree)/$(src)/include -I$(srctree)
>
> # Core
>
> -obj-$(CONFIG_ARCH_EXYNOS) += exynos.o pmu.o exynos-smc.o firmware.o
> +obj-$(CONFIG_ARCH_EXYNOS) += exynos.o pmu.o exynos-smc.o firmware.o exynos3250-pmu.o
>
> obj-$(CONFIG_EXYNOS_CPU_SUSPEND) += pm.o sleep.o
> obj-$(CONFIG_PM_SLEEP) += suspend.o
> diff --git a/arch/arm/mach-exynos/exynos-pmu.h b/arch/arm/mach-exynos/exynos-pmu.h
> new file mode 100644
> index 0000000..2da4964
> --- /dev/null
> +++ b/arch/arm/mach-exynos/exynos-pmu.h
> @@ -0,0 +1,47 @@
> +/*
> + * Copyright (c) 2015 Samsung Electronics Co., Ltd.
> + * http://www.samsung.com
> + *
> + * Header for EXYNOS PMU Driver support
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#ifndef __EXYNOSPMU_H
> +#define __EXYNOSPMU_H
__EXYNOS_PMU_H
(and rename it in last patch)
> +
> +#include <linux/io.h>
> +
> +#define PMU_TABLE_END (-1U)
> +
> +extern void __iomem *pmu_base_addr;
> +
> +struct exynos_pmu_conf {
> + unsigned int offset;
> + u8 val[NUM_SYS_POWERDOWN];
> +};
> +
> +struct exynos_pmu_data {
> + const struct exynos_pmu_conf *pmu_config;
> + const struct exynos_pmu_conf *pmu_config_extra;
> +
> + void (*pmu_init)(void);
> + void (*powerdown_conf)(enum sys_powerdown);
> + void (*powerdown_conf_extra)(enum sys_powerdown);
> +};
> +
> +static inline void pmu_raw_writel(u32 val, u32 offset)
> +{
> + writel_relaxed(val, pmu_base_addr + offset);
> +}
> +
> +static inline u32 pmu_raw_readl(u32 offset)
> +{
> + return readl_relaxed(pmu_base_addr + offset);
> +}
These shouldn't be static inlines in header because you will duplicate
it in each compiled object. Leave optimizations to compiler.
Rest looks good,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Pankaj Dubey <pankaj.dubey@samsung.com> |
|---|---|
| Date | 2015-11-05 06:40 +0100 |
| Message-ID | <qrlrb-2q8-5@gated-at.bofh.it> |
| In reply to | #1261135 |
Hi Krzysztof,
On Tuesday 03 November 2015 07:25 AM, Krzysztof Kozlowski wrote:
> On 26.10.2015 21:55, Pankaj Dubey wrote:
>> This patch splits up mach-exynos/pmu.c file, and moves exynos3250 PMU
>> configuration data and functions handing those data into exynos3250
>> SoC specific PMU file mach-exynos/exynos3250-pmu.c.
>>
>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>> ---
>> arch/arm/mach-exynos/Makefile | 2 +-
>> arch/arm/mach-exynos/exynos-pmu.h | 47 +++++++++
>> arch/arm/mach-exynos/exynos3250-pmu.c | 175 +++++++++++++++++++++++++++++++
>> arch/arm/mach-exynos/pmu.c | 189 +---------------------------------
>> 4 files changed, 224 insertions(+), 189 deletions(-)
>> create mode 100644 arch/arm/mach-exynos/exynos-pmu.h
>> create mode 100644 arch/arm/mach-exynos/exynos3250-pmu.c
>>
>> diff --git a/arch/arm/mach-exynos/Makefile b/arch/arm/mach-exynos/Makefile
>> index 2f30676..e869f86 100644
>> --- a/arch/arm/mach-exynos/Makefile
>> +++ b/arch/arm/mach-exynos/Makefile
>> @@ -9,7 +9,7 @@ ccflags-$(CONFIG_ARCH_MULTIPLATFORM) += -I$(srctree)/$(src)/include -I$(srctree)
>>
>> # Core
>>
>> -obj-$(CONFIG_ARCH_EXYNOS) += exynos.o pmu.o exynos-smc.o firmware.o
>> +obj-$(CONFIG_ARCH_EXYNOS) += exynos.o pmu.o exynos-smc.o firmware.o exynos3250-pmu.o
>>
>> obj-$(CONFIG_EXYNOS_CPU_SUSPEND) += pm.o sleep.o
>> obj-$(CONFIG_PM_SLEEP) += suspend.o
>> diff --git a/arch/arm/mach-exynos/exynos-pmu.h b/arch/arm/mach-exynos/exynos-pmu.h
>> new file mode 100644
>> index 0000000..2da4964
>> --- /dev/null
>> +++ b/arch/arm/mach-exynos/exynos-pmu.h
>> @@ -0,0 +1,47 @@
>> +/*
>> + * Copyright (c) 2015 Samsung Electronics Co., Ltd.
>> + * http://www.samsung.com
>> + *
>> + * Header for EXYNOS PMU Driver support
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + */
>> +
>> +#ifndef __EXYNOSPMU_H
>> +#define __EXYNOSPMU_H
>
> __EXYNOS_PMU_H
> (and rename it in last patch)
>
OK.
>> +
>> +#include <linux/io.h>
>> +
>> +#define PMU_TABLE_END (-1U)
>> +
>> +extern void __iomem *pmu_base_addr;
>> +
>> +struct exynos_pmu_conf {
>> + unsigned int offset;
>> + u8 val[NUM_SYS_POWERDOWN];
>> +};
>> +
>> +struct exynos_pmu_data {
>> + const struct exynos_pmu_conf *pmu_config;
>> + const struct exynos_pmu_conf *pmu_config_extra;
>> +
>> + void (*pmu_init)(void);
>> + void (*powerdown_conf)(enum sys_powerdown);
>> + void (*powerdown_conf_extra)(enum sys_powerdown);
>> +};
>> +
>> +static inline void pmu_raw_writel(u32 val, u32 offset)
>> +{
>> + writel_relaxed(val, pmu_base_addr + offset);
>> +}
>> +
>> +static inline u32 pmu_raw_readl(u32 offset)
>> +{
>> + return readl_relaxed(pmu_base_addr + offset);
>> +}
>
> These shouldn't be static inlines in header because you will duplicate
> it in each compiled object. Leave optimizations to compiler.
>
OK. Thanks for review.
Thanks,
Pankaj Dubey
> Rest looks good,
> Krzysztof
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2015-11-06 01:40 +0100 |
| Message-ID | <qrDeq-5Hv-1@gated-at.bofh.it> |
| In reply to | #1262932 |
On 05.11.2015 14:31, Pankaj Dubey wrote: > Hi Krzysztof, > > On Tuesday 03 November 2015 07:25 AM, Krzysztof Kozlowski wrote: >> On 26.10.2015 21:55, Pankaj Dubey wrote: >>> This patch splits up mach-exynos/pmu.c file, and moves exynos3250 PMU >>> configuration data and functions handing those data into exynos3250 >>> SoC specific PMU file mach-exynos/exynos3250-pmu.c. >>> >>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> >>> --- >>> arch/arm/mach-exynos/Makefile | 2 +- >>> arch/arm/mach-exynos/exynos-pmu.h | 47 +++++++++ >>> arch/arm/mach-exynos/exynos3250-pmu.c | 175 >>> +++++++++++++++++++++++++++++++ >>> arch/arm/mach-exynos/pmu.c | 189 >>> +--------------------------------- >>> 4 files changed, 224 insertions(+), 189 deletions(-) >>> create mode 100644 arch/arm/mach-exynos/exynos-pmu.h >>> create mode 100644 arch/arm/mach-exynos/exynos3250-pmu.c >>> I spotted it now - please fix subject prefix in patches 3-6. ARM: EXYNOS: BR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web