Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1260479 > unrolled thread

Re: [RESEND PATCH 4/4] crypto: rk_crypto - add DT bindings documentation

Started byZain <zain.wang@rock-chips.com>
First post2015-11-02 10:20 +0100
Last post2015-11-03 01:30 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [RESEND PATCH 4/4] crypto: rk_crypto - add DT bindings  documentation Zain <zain.wang@rock-chips.com> - 2015-11-02 10:20 +0100
    Re: [RESEND PATCH 4/4] crypto: rk_crypto - add DT bindings documentation Rob Herring <robh+dt@kernel.org> - 2015-11-02 16:50 +0100
      Re: [RESEND PATCH 4/4] crypto: rk_crypto - add DT bindings  documentation Zain <zain.wang@rock-chips.com> - 2015-11-03 01:30 +0100

#1260479 — Re: [RESEND PATCH 4/4] crypto: rk_crypto - add DT bindings documentation

FromZain <zain.wang@rock-chips.com>
Date2015-11-02 10:20 +0100
SubjectRe: [RESEND PATCH 4/4] crypto: rk_crypto - add DT bindings documentation
Message-ID<qqjrs-3wz-23@gated-at.bofh.it>
Hi Mark

On 2015年10月30日 22:03, Mark Rutland wrote:
> On Fri, Oct 30, 2015 at 04:22:49PM +0800, Zain Wang wrote:
>> Add DT bindings documentation for the rk3288 crypto drivers.
>>
>> Signed-off-by: Zain Wang <zain.wang@rock-chips.com>
>> ---
>>  .../devicetree/bindings/crypto/rk-crypto.txt       | 31 ++++++++++++++++++++++
>>  1 file changed, 31 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/crypto/rk-crypto.txt
>>
>> diff --git a/Documentation/devicetree/bindings/crypto/rk-crypto.txt b/Documentation/devicetree/bindings/crypto/rk-crypto.txt
>> new file mode 100644
>> index 0000000..1e50768
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/crypto/rk-crypto.txt
>> @@ -0,0 +1,31 @@
>> +Rockchip Electronics And Security Accelerator
>> +
>> +Required properties:
>> +- compatible: should be "rockchip,crypto"
> Choose a more specific name. Rockchip could easily come up with another
> crypto accelerator later.
ok! done.
rk3288_crypto may be better than crypto.
>> +- reg: base physical address of the engine and length of memory mapped
>> +       region.
>> +- interrupts: interrupt number
>> +- clocks: clock specifiers
>> +- clock-names: "aclk_crypto" used to clock data
>> +			   "hclk_crypto" used to clock data
>> +			   "srst_crypto" used to clock crypto accelerator
>> +			   "apb_pclk"    used to clock dma
>> +-status: Enable
> No need to mention the status property.
ok! done!
> Thanks,
> Mark.
>
>> +
>> +Examples:
>> +
>> +	crypto: cypto-controller@ff8a0000 {
>> +		compatible = "rockchip,crypto";
>> +		reg = <0xff8a0000 0x4000>;
>> +		interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
>> +		clocks = <&cru ACLK_CRYPTO>,
>> +			 <&cru HCLK_CRYPTO>,
>> +			 <&cru SRST_CRYPTO>,
>> +			 <&cru ACLK_DMAC1>;
>> +
>> +		clock-names = "aclk_crypto",
>> +			      "hclk_crypto",
>> +			      "srst_crypto",
>> +				  "apb_pclk";
>> +		status = "okay";
>> +	};
>> -- 
>> 1.9.1
>>
>>
>
Thanks
Zain

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1260735 — Re: [RESEND PATCH 4/4] crypto: rk_crypto - add DT bindings documentation

FromRob Herring <robh+dt@kernel.org>
Date2015-11-02 16:50 +0100
SubjectRe: [RESEND PATCH 4/4] crypto: rk_crypto - add DT bindings documentation
Message-ID<qqpwS-745-13@gated-at.bofh.it>
In reply to#1260479
On Mon, Nov 2, 2015 at 3:13 AM, Zain <zain.wang@rock-chips.com> wrote:
> Hi Mark
>
> On 2015年10月30日 22:03, Mark Rutland wrote:
>> On Fri, Oct 30, 2015 at 04:22:49PM +0800, Zain Wang wrote:
>>> Add DT bindings documentation for the rk3288 crypto drivers.
>>>
>>> Signed-off-by: Zain Wang <zain.wang@rock-chips.com>
>>> ---

>>> +Required properties:
>>> +- compatible: should be "rockchip,crypto"
>> Choose a more specific name. Rockchip could easily come up with another
>> crypto accelerator later.
> ok! done.
> rk3288_crypto may be better than crypto.

Yes, but use '-' not '_'.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1261084

FromZain <zain.wang@rock-chips.com>
Date2015-11-03 01:30 +0100
Message-ID<qqxE6-3M2-5@gated-at.bofh.it>
In reply to#1260735
Hi Mark,

On 2015年11月02日 23:39, Rob Herring wrote:
> On Mon, Nov 2, 2015 at 3:13 AM, Zain <zain.wang@rock-chips.com> wrote:
>> Hi Mark
>>
>> On 2015年10月30日 22:03, Mark Rutland wrote:
>>> On Fri, Oct 30, 2015 at 04:22:49PM +0800, Zain Wang wrote:
>>>> Add DT bindings documentation for the rk3288 crypto drivers.
>>>>
>>>> Signed-off-by: Zain Wang <zain.wang@rock-chips.com>
>>>> ---
>>>> +Required properties:
>>>> +- compatible: should be "rockchip,crypto"
>>> Choose a more specific name. Rockchip could easily come up with another
>>> crypto accelerator later.
>> ok! done.
>> rk3288_crypto may be better than crypto.
> Yes, but use '-' not '_'.
ok! done!
>
> Rob
>
>
>
Thanks
Zain

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web