Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1260714 > unrolled thread

Re: [PATCH 2/3] dt-bindings: gpio: Documentation for Hi6220 gpio driver

Started byRob Herring <robh+dt@kernel.org>
First post2015-11-02 16:20 +0100
Last post2015-11-05 04:10 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 2/3] dt-bindings: gpio: Documentation for Hi6220 gpio driver Rob Herring <robh+dt@kernel.org> - 2015-11-02 16:20 +0100
    Re: [PATCH 2/3] dt-bindings: gpio: Documentation for Hi6220 gpio  driver Zhong Kaihua <zhongkaihua@huawei.com> - 2015-11-05 04:10 +0100

#1260714 — Re: [PATCH 2/3] dt-bindings: gpio: Documentation for Hi6220 gpio driver

FromRob Herring <robh+dt@kernel.org>
Date2015-11-02 16:20 +0100
SubjectRe: [PATCH 2/3] dt-bindings: gpio: Documentation for Hi6220 gpio driver
Message-ID<qqp3Q-6Uf-15@gated-at.bofh.it>
On Fri, Oct 30, 2015 at 9:24 PM, Zhong Kaihua <zhongkaihua@huawei.com> wrote:
> dt-bindings: gpio: Documentation for Hi6220 gpio driver
>
> Signed-off-by: Zhong Kaihua <zhongkaihua@huawei.com>
> ---
>  .../devicetree/bindings/gpio/gpio-hi6220.txt       | 23 ++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
> new file mode 100644
> index 0000000..76a8932
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
> @@ -0,0 +1,23 @@
> +Hisilicon Hi6220 GPIO controller bindings
> +
> +Required properties:
> +  - compatible:        "arm,pl061", "arm,primecell"
> +  - gpio-controller: Marks the device node as a        GPIO controller.
> +  - #gpio-cells: Should        be 2. See gpio.txt in this directory for a

Some strange spacing in here. Otherwise,

Acked-by: Rob Herring <robh@kernel.org>

> +                description of the cells format.
> +  - interrupt-controller: Mark the device node as an interrupt controller
> +
> +Example:
> +
> +       gpio0: gpio@f8011000 {
> +               compatible = "arm,pl061", "arm,primecell";
> +               reg = <0x0 0xf8011000 0x0 0x1000>;
> +               interrupts = <0 52 0x4>;
> +               gpio-controller;
> +               #gpio-cells = <2>;
> +               interrupt-controller;
> +               #interrupt-cells = <2>;
> +               clocks = <&ao_ctrl 2>;
> +               clock-names = "apb_pclk";
> +               status = "ok";
> +       };
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1262866 — Re: [PATCH 2/3] dt-bindings: gpio: Documentation for Hi6220 gpio driver

FromZhong Kaihua <zhongkaihua@huawei.com>
Date2015-11-05 04:10 +0100
SubjectRe: [PATCH 2/3] dt-bindings: gpio: Documentation for Hi6220 gpio driver
Message-ID<qrj62-Vz-33@gated-at.bofh.it>
In reply to#1260714
On 2015/11/2 23:09, Rob Herring wrote:
> On Fri, Oct 30, 2015 at 9:24 PM, Zhong Kaihua <zhongkaihua@huawei.com> wrote:
>> dt-bindings: gpio: Documentation for Hi6220 gpio driver
>>
>> Signed-off-by: Zhong Kaihua <zhongkaihua@huawei.com>
>> ---
>>  .../devicetree/bindings/gpio/gpio-hi6220.txt       | 23 ++++++++++++++++++++++
>>  1 file changed, 23 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
>>
>> diff --git a/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
>> new file mode 100644
>> index 0000000..76a8932
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
>> @@ -0,0 +1,23 @@
>> +Hisilicon Hi6220 GPIO controller bindings
>> +
>> +Required properties:
>> +  - compatible:        "arm,pl061", "arm,primecell"
>> +  - gpio-controller: Marks the device node as a        GPIO controller.
>> +  - #gpio-cells: Should        be 2. See gpio.txt in this directory for a
> 
> Some strange spacing in here. Otherwise,
> 
> Acked-by: Rob Herring <robh@kernel.org>

Style problems have been fixed in V2 patch.

Rearrange the document patch to the first of patch set.

> 
>> +                description of the cells format.
>> +  - interrupt-controller: Mark the device node as an interrupt controller
>> +
>> +Example:
>> +
>> +       gpio0: gpio@f8011000 {
>> +               compatible = "arm,pl061", "arm,primecell";
>> +               reg = <0x0 0xf8011000 0x0 0x1000>;
>> +               interrupts = <0 52 0x4>;
>> +               gpio-controller;
>> +               #gpio-cells = <2>;
>> +               interrupt-controller;
>> +               #interrupt-cells = <2>;
>> +               clocks = <&ao_ctrl 2>;
>> +               clock-names = "apb_pclk";
>> +               status = "ok";
>> +       };
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> .
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web