Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1260485 > unrolled thread

[PATCH] wireless:b43: remove last reference on B43_PCMCIA

Started byValentin Rothberg <valentinrothberg@gmail.com>
First post2015-11-02 10:30 +0100
Last post2015-11-02 11:00 +0100
Articles 4 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] wireless:b43: remove last reference on B43_PCMCIA Valentin Rothberg <valentinrothberg@gmail.com> - 2015-11-02 10:30 +0100
    Re: [PATCH] wireless:b43: remove last reference on B43_PCMCIA Rafał Miłecki <zajec5@gmail.com> - 2015-11-02 10:40 +0100
      Re: [PATCH] wireless:b43: remove last reference on B43_PCMCIA Valentin Rothberg <valentinrothberg@gmail.com> - 2015-11-02 10:50 +0100
    [PATCH v2] wireless:b43: remove last reference on B43_PCMCIA Valentin Rothberg <valentinrothberg@gmail.com> - 2015-11-02 11:00 +0100

#1260485 — [PATCH] wireless:b43: remove last reference on B43_PCMCIA

FromValentin Rothberg <valentinrothberg@gmail.com>
Date2015-11-02 10:30 +0100
Subject[PATCH] wireless:b43: remove last reference on B43_PCMCIA
Message-ID<qqjB7-3zJ-1@gated-at.bofh.it>
Remove last reference on Kconfig option B43_PCMCIA, which has been
removed by commit 399500da18f7 ("ssb: pick PCMCIA host code support from
b43 driver").

Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
---
 drivers/net/wireless/b43/main.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
index ec013fbd6a81..190efd3160b7 100644
--- a/drivers/net/wireless/b43/main.c
+++ b/drivers/net/wireless/b43/main.c
@@ -5826,9 +5826,6 @@ static void b43_print_driverinfo(void)
 #ifdef CONFIG_B43_PCI_AUTOSELECT
 	feat_pci = "P";
 #endif
-#ifdef CONFIG_B43_PCMCIA
-	feat_pcmcia = "M";
-#endif
 #ifdef CONFIG_B43_PHY_N
 	feat_nphy = "N";
 #endif
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1260494

FromRafał Miłecki <zajec5@gmail.com>
Date2015-11-02 10:40 +0100
Message-ID<qqjKN-3CM-13@gated-at.bofh.it>
In reply to#1260485
On 2 November 2015 at 10:24, Valentin Rothberg
<valentinrothberg@gmail.com> wrote:
> Remove last reference on Kconfig option B43_PCMCIA, which has been
> removed by commit 399500da18f7 ("ssb: pick PCMCIA host code support from
> b43 driver").
>
> Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
> ---
>  drivers/net/wireless/b43/main.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
> index ec013fbd6a81..190efd3160b7 100644
> --- a/drivers/net/wireless/b43/main.c
> +++ b/drivers/net/wireless/b43/main.c
> @@ -5826,9 +5826,6 @@ static void b43_print_driverinfo(void)
>  #ifdef CONFIG_B43_PCI_AUTOSELECT
>         feat_pci = "P";
>  #endif
> -#ifdef CONFIG_B43_PCMCIA
> -       feat_pcmcia = "M";
> -#endif
>  #ifdef CONFIG_B43_PHY_N
>         feat_nphy = "N";
>  #endif

There is no point of leaving feat_pcmcia variable.

-- 
Rafał
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1260498

FromValentin Rothberg <valentinrothberg@gmail.com>
Date2015-11-02 10:50 +0100
Message-ID<qqjUt-3G6-3@gated-at.bofh.it>
In reply to#1260494
On Nov 02 '15 10:31, Rafał Miłecki wrote:
> On 2 November 2015 at 10:24, Valentin Rothberg
> <valentinrothberg@gmail.com> wrote:
> > Remove last reference on Kconfig option B43_PCMCIA, which has been
> > removed by commit 399500da18f7 ("ssb: pick PCMCIA host code support from
> > b43 driver").
> >
> > Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
> > ---
> >  drivers/net/wireless/b43/main.c | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
> > index ec013fbd6a81..190efd3160b7 100644
> > --- a/drivers/net/wireless/b43/main.c
> > +++ b/drivers/net/wireless/b43/main.c
> > @@ -5826,9 +5826,6 @@ static void b43_print_driverinfo(void)
> >  #ifdef CONFIG_B43_PCI_AUTOSELECT
> >         feat_pci = "P";
> >  #endif
> > -#ifdef CONFIG_B43_PCMCIA
> > -       feat_pcmcia = "M";
> > -#endif
> >  #ifdef CONFIG_B43_PHY_N
> >         feat_nphy = "N";
> >  #endif
> 
> There is no point of leaving feat_pcmcia variable.

Sorry, I will fix and resend the patch.

Thanks,
 Valentin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1260504 — [PATCH v2] wireless:b43: remove last reference on B43_PCMCIA

FromValentin Rothberg <valentinrothberg@gmail.com>
Date2015-11-02 11:00 +0100
Subject[PATCH v2] wireless:b43: remove last reference on B43_PCMCIA
Message-ID<qqk4a-3Jl-5@gated-at.bofh.it>
In reply to#1260485
Remove last reference on Kconfig option B43_PCMCIA, which has been
removed by commit 399500da18f7 ("ssb: pick PCMCIA host code support from
b43 driver").

Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
---
 drivers/net/wireless/b43/main.c | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
index ec013fbd6a81..524e5f4a07dd 100644
--- a/drivers/net/wireless/b43/main.c
+++ b/drivers/net/wireless/b43/main.c
@@ -5820,15 +5820,12 @@ void b43_controller_restart(struct b43_wldev *dev, const char *reason)
 
 static void b43_print_driverinfo(void)
 {
-	const char *feat_pci = "", *feat_pcmcia = "", *feat_nphy = "",
-		   *feat_leds = "", *feat_sdio = "";
+	const char *feat_pci = "", *feat_nphy = "", *feat_leds = "",
+		   *feat_sdio = "";
 
 #ifdef CONFIG_B43_PCI_AUTOSELECT
 	feat_pci = "P";
 #endif
-#ifdef CONFIG_B43_PCMCIA
-	feat_pcmcia = "M";
-#endif
 #ifdef CONFIG_B43_PHY_N
 	feat_nphy = "N";
 #endif
@@ -5838,10 +5835,8 @@ static void b43_print_driverinfo(void)
 #ifdef CONFIG_B43_SDIO
 	feat_sdio = "S";
 #endif
-	printk(KERN_INFO "Broadcom 43xx driver loaded "
-	       "[ Features: %s%s%s%s%s ]\n",
-	       feat_pci, feat_pcmcia, feat_nphy,
-	       feat_leds, feat_sdio);
+	printk(KERN_INFO "Broadcom 43xx driver loaded [ Features: %s%s%s%s ]\n",
+	       feat_pci, feat_nphy, feat_leds, feat_sdio);
 }
 
 static int __init b43_init(void)
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web