Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1253538 > unrolled thread

Re: [PATCH] mcb: Do not return zero on error path in mcb_pci_probe()

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] mcb: Do not return zero on error path in mcb_pci_probe() Johannes Thumshirn <morbidrsa@gmail.com> - 2015-10-22 09:30 +0200
    Re: [PATCH] mcb: Do not return zero on error path in mcb_pci_probe() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-11-02 04:20 +0100

#1253538 — Re: [PATCH] mcb: Do not return zero on error path in mcb_pci_probe()

On Sat, Oct 17, 2015 at 11:33 PM, Alexey Khoroshilov
<khoroshilov@ispras.ru> wrote:
> There is an error path in mcb_pci_probe() where
> it returns zero instead of error code.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
> ---
>  drivers/mcb/mcb-pci.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mcb/mcb-pci.c b/drivers/mcb/mcb-pci.c
> index 051645498b53..67d5e7d08df6 100644
> --- a/drivers/mcb/mcb-pci.c
> +++ b/drivers/mcb/mcb-pci.c
> @@ -51,6 +51,7 @@ static int mcb_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>         priv->mapbase = pci_resource_start(pdev, 0);
>         if (!priv->mapbase) {
>                 dev_err(&pdev->dev, "No PCI resource\n");
> +               ret = -ENODEV;
>                 goto out_disable;
>         }
>
> --
> 1.9.1
>

Applied, thanks.

@Greg, shall I forward you the patch or do a pull request?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1260321

On Thu, Oct 22, 2015 at 09:28:57AM +0200, Johannes Thumshirn wrote:
> On Sat, Oct 17, 2015 at 11:33 PM, Alexey Khoroshilov
> <khoroshilov@ispras.ru> wrote:
> > There is an error path in mcb_pci_probe() where
> > it returns zero instead of error code.
> >
> > Found by Linux Driver Verification project (linuxtesting.org).
> >
> > Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
> > ---
> >  drivers/mcb/mcb-pci.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mcb/mcb-pci.c b/drivers/mcb/mcb-pci.c
> > index 051645498b53..67d5e7d08df6 100644
> > --- a/drivers/mcb/mcb-pci.c
> > +++ b/drivers/mcb/mcb-pci.c
> > @@ -51,6 +51,7 @@ static int mcb_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> >         priv->mapbase = pci_resource_start(pdev, 0);
> >         if (!priv->mapbase) {
> >                 dev_err(&pdev->dev, "No PCI resource\n");
> > +               ret = -ENODEV;
> >                 goto out_disable;
> >         }
> >
> > --
> > 1.9.1
> >
> 
> Applied, thanks.
> 
> @Greg, shall I forward you the patch or do a pull request?

Please forward on, I don't do many pull requests.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web