Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1261733 > unrolled thread

Re: [PATCH v2 0/2] UBSan: run-time undefined behavior sanity checker

Started bySasha Levin <sasha.levin@oracle.com>
First post2015-11-03 18:30 +0100
Last post2015-11-03 19:50 +0100
Articles 6 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 0/2] UBSan: run-time undefined behavior sanity checker Sasha Levin <sasha.levin@oracle.com> - 2015-11-03 18:30 +0100
    Re: [PATCH v2 0/2] UBSan: run-time undefined behavior sanity checker Dmitry Vyukov <dvyukov@google.com> - 2015-11-03 18:40 +0100
      Re: [PATCH v2 0/2] UBSan: run-time undefined behavior sanity checker Dmitry Vyukov <dvyukov@google.com> - 2015-11-03 18:50 +0100
        Re: [PATCH v2 0/2] UBSan: run-time undefined behavior sanity checker Sasha Levin <sasha.levin@oracle.com> - 2015-11-03 19:00 +0100
    Re: [PATCH v2 0/2] UBSan: run-time undefined behavior sanity checker Andrey Ryabinin <ryabinin.a.a@gmail.com> - 2015-11-03 19:20 +0100
      Re: [PATCH v2 0/2] UBSan: run-time undefined behavior sanity checker Sasha Levin <sasha.levin@oracle.com> - 2015-11-03 19:50 +0100

#1261733 — Re: [PATCH v2 0/2] UBSan: run-time undefined behavior sanity checker

FromSasha Levin <sasha.levin@oracle.com>
Date2015-11-03 18:30 +0100
SubjectRe: [PATCH v2 0/2] UBSan: run-time undefined behavior sanity checker
Message-ID<qqNzc-5NA-19@gated-at.bofh.it>
Anyone knows why wasn't this merged a year ago? I didn't see any review comments, and it
ended up finding real bugs.

On 11/14/2014 07:50 AM, Andrey Ryabinin wrote:
> Next spin of UBSan and there are two patches from now.
> "Two there should be; no more, no less. One to embody the UBSan,
> the other to not deadlock it."
> 
> Patches on top of v3.18-rc4. As usual they are available in git:
> 	git://github.com/aryabinin/linux ubsan/v2
> 
> Changes since v1:
>    - Refactoring and cleanups in lib/ubsan.c including Sasha's complains.
>    - Some spelling fixes from Randy
>    - Fixed possible memory corruption on 64 big endian machines, spotted by Rasmus.
>    - Links to the relevant GCC documentation added into changelog (Peter).
>    - Added documentation.
>    - Fix deadlock caused by kernel/printk/printk.c instrumentation
>         (patch "kernel: printk: specify alignment for struct printk_log").
>    - Dropped useless 'Indirect call of a function through a function pointer of the wrong type'
>      checker. GCC doesn't support this, and as clang manual says it's for C++ only.
>    - Added checker for __builtin_unreachable() calls.
>    - Removed redundant -fno-sanitize=float-cast-overflow from CFLAGS.
>    - Added lock to prevent mixing reports.
> 
> Andrey Ryabinin (2):
>   kernel: printk: specify alignment for struct printk_log
>   UBSan: run-time undefined behavior sanity checker
> 
>  Documentation/ubsan.txt               |  69 +++++
>  Makefile                              |  10 +-
>  arch/x86/Kconfig                      |   1 +
>  arch/x86/boot/Makefile                |   1 +
>  arch/x86/boot/compressed/Makefile     |   1 +
>  arch/x86/realmode/rm/Makefile         |   1 +
>  arch/x86/vdso/Makefile                |   2 +
>  drivers/firmware/efi/libstub/Makefile |   1 +
>  include/linux/sched.h                 |   3 +
>  kernel/printk/printk.c                |  10 +-
>  lib/Kconfig.debug                     |  22 ++
>  lib/Makefile                          |   3 +
>  lib/ubsan.c                           | 567 ++++++++++++++++++++++++++++++++++
>  lib/ubsan.h                           |  84 +++++
>  scripts/Makefile.lib                  |   6 +
>  15 files changed, 775 insertions(+), 6 deletions(-)
>  create mode 100644 Documentation/ubsan.txt
>  create mode 100644 lib/ubsan.c
>  create mode 100644 lib/ubsan.h
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1261737

FromDmitry Vyukov <dvyukov@google.com>
Date2015-11-03 18:40 +0100
Message-ID<qqNIS-5QT-9@gated-at.bofh.it>
In reply to#1261733
I guess just nobody reviewed this. I would like to see this merged as well.



On Tue, Nov 3, 2015 at 6:20 PM, Sasha Levin <sasha.levin@oracle.com> wrote:
> Anyone knows why wasn't this merged a year ago? I didn't see any review comments, and it
> ended up finding real bugs.
>
> On 11/14/2014 07:50 AM, Andrey Ryabinin wrote:
>> Next spin of UBSan and there are two patches from now.
>> "Two there should be; no more, no less. One to embody the UBSan,
>> the other to not deadlock it."
>>
>> Patches on top of v3.18-rc4. As usual they are available in git:
>>       git://github.com/aryabinin/linux ubsan/v2
>>
>> Changes since v1:
>>    - Refactoring and cleanups in lib/ubsan.c including Sasha's complains.
>>    - Some spelling fixes from Randy
>>    - Fixed possible memory corruption on 64 big endian machines, spotted by Rasmus.
>>    - Links to the relevant GCC documentation added into changelog (Peter).
>>    - Added documentation.
>>    - Fix deadlock caused by kernel/printk/printk.c instrumentation
>>         (patch "kernel: printk: specify alignment for struct printk_log").
>>    - Dropped useless 'Indirect call of a function through a function pointer of the wrong type'
>>      checker. GCC doesn't support this, and as clang manual says it's for C++ only.
>>    - Added checker for __builtin_unreachable() calls.
>>    - Removed redundant -fno-sanitize=float-cast-overflow from CFLAGS.
>>    - Added lock to prevent mixing reports.
>>
>> Andrey Ryabinin (2):
>>   kernel: printk: specify alignment for struct printk_log
>>   UBSan: run-time undefined behavior sanity checker
>>
>>  Documentation/ubsan.txt               |  69 +++++
>>  Makefile                              |  10 +-
>>  arch/x86/Kconfig                      |   1 +
>>  arch/x86/boot/Makefile                |   1 +
>>  arch/x86/boot/compressed/Makefile     |   1 +
>>  arch/x86/realmode/rm/Makefile         |   1 +
>>  arch/x86/vdso/Makefile                |   2 +
>>  drivers/firmware/efi/libstub/Makefile |   1 +
>>  include/linux/sched.h                 |   3 +
>>  kernel/printk/printk.c                |  10 +-
>>  lib/Kconfig.debug                     |  22 ++
>>  lib/Makefile                          |   3 +
>>  lib/ubsan.c                           | 567 ++++++++++++++++++++++++++++++++++
>>  lib/ubsan.h                           |  84 +++++
>>  scripts/Makefile.lib                  |   6 +
>>  15 files changed, 775 insertions(+), 6 deletions(-)
>>  create mode 100644 Documentation/ubsan.txt
>>  create mode 100644 lib/ubsan.c
>>  create mode 100644 lib/ubsan.h
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1261741

FromDmitry Vyukov <dvyukov@google.com>
Date2015-11-03 18:50 +0100
Message-ID<qqNSy-5Uf-5@gated-at.bofh.it>
In reply to#1261737
+Andrey

On Tue, Nov 3, 2015 at 6:35 PM, Dmitry Vyukov <dvyukov@google.com> wrote:
> I guess just nobody reviewed this. I would like to see this merged as well.
>
>
>
> On Tue, Nov 3, 2015 at 6:20 PM, Sasha Levin <sasha.levin@oracle.com> wrote:
>> Anyone knows why wasn't this merged a year ago? I didn't see any review comments, and it
>> ended up finding real bugs.
>>
>> On 11/14/2014 07:50 AM, Andrey Ryabinin wrote:
>>> Next spin of UBSan and there are two patches from now.
>>> "Two there should be; no more, no less. One to embody the UBSan,
>>> the other to not deadlock it."
>>>
>>> Patches on top of v3.18-rc4. As usual they are available in git:
>>>       git://github.com/aryabinin/linux ubsan/v2
>>>
>>> Changes since v1:
>>>    - Refactoring and cleanups in lib/ubsan.c including Sasha's complains.
>>>    - Some spelling fixes from Randy
>>>    - Fixed possible memory corruption on 64 big endian machines, spotted by Rasmus.
>>>    - Links to the relevant GCC documentation added into changelog (Peter).
>>>    - Added documentation.
>>>    - Fix deadlock caused by kernel/printk/printk.c instrumentation
>>>         (patch "kernel: printk: specify alignment for struct printk_log").
>>>    - Dropped useless 'Indirect call of a function through a function pointer of the wrong type'
>>>      checker. GCC doesn't support this, and as clang manual says it's for C++ only.
>>>    - Added checker for __builtin_unreachable() calls.
>>>    - Removed redundant -fno-sanitize=float-cast-overflow from CFLAGS.
>>>    - Added lock to prevent mixing reports.
>>>
>>> Andrey Ryabinin (2):
>>>   kernel: printk: specify alignment for struct printk_log
>>>   UBSan: run-time undefined behavior sanity checker
>>>
>>>  Documentation/ubsan.txt               |  69 +++++
>>>  Makefile                              |  10 +-
>>>  arch/x86/Kconfig                      |   1 +
>>>  arch/x86/boot/Makefile                |   1 +
>>>  arch/x86/boot/compressed/Makefile     |   1 +
>>>  arch/x86/realmode/rm/Makefile         |   1 +
>>>  arch/x86/vdso/Makefile                |   2 +
>>>  drivers/firmware/efi/libstub/Makefile |   1 +
>>>  include/linux/sched.h                 |   3 +
>>>  kernel/printk/printk.c                |  10 +-
>>>  lib/Kconfig.debug                     |  22 ++
>>>  lib/Makefile                          |   3 +
>>>  lib/ubsan.c                           | 567 ++++++++++++++++++++++++++++++++++
>>>  lib/ubsan.h                           |  84 +++++
>>>  scripts/Makefile.lib                  |   6 +
>>>  15 files changed, 775 insertions(+), 6 deletions(-)
>>>  create mode 100644 Documentation/ubsan.txt
>>>  create mode 100644 lib/ubsan.c
>>>  create mode 100644 lib/ubsan.h
>>>
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1261747

FromSasha Levin <sasha.levin@oracle.com>
Date2015-11-03 19:00 +0100
Message-ID<qqO2e-5XS-11@gated-at.bofh.it>
In reply to#1261741
On 11/03/2015 12:45 PM, Dmitry Vyukov wrote:
> On Tue, Nov 3, 2015 at 6:35 PM, Dmitry Vyukov <dvyukov@google.com> wrote:
>> > I guess just nobody reviewed this. I would like to see this merged as well.

Hm, at v2 it was working pretty well and the feeling I got was that there are
no further review comments (rather than no one reviewed it).


Thanks,
Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1261775

FromAndrey Ryabinin <ryabinin.a.a@gmail.com>
Date2015-11-03 19:20 +0100
Message-ID<qqOlA-6kC-21@gated-at.bofh.it>
In reply to#1261733
2015-11-03 20:20 GMT+03:00 Sasha Levin <sasha.levin@oracle.com>:
> Anyone knows why wasn't this merged a year ago? I didn't see any review comments, and it
> ended up finding real bugs.
>

Probably because I didn't ping so it just lost.
I'll send v3 after the merge window.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1261795

FromSasha Levin <sasha.levin@oracle.com>
Date2015-11-03 19:50 +0100
Message-ID<qqOOC-6vo-25@gated-at.bofh.it>
In reply to#1261775
On 11/03/2015 01:15 PM, Andrey Ryabinin wrote:
> 2015-11-03 20:20 GMT+03:00 Sasha Levin <sasha.levin@oracle.com>:
>> Anyone knows why wasn't this merged a year ago? I didn't see any review comments, and it
>> ended up finding real bugs.
>>
> 
> Probably because I didn't ping so it just lost.
> I'll send v3 after the merge window.
> 

Thanks Andrey!

I've just tried v2 on -next, and that causes a hang during boot (seems like we're
hitting undefined behavior while already handling undefined behaviour.


Thanks,
Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web