Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1260079 > unrolled thread

Re: [PATCH] ipc/msg: Implement lockless pipelined wakeups

Started byManfred Spraul <manfred@colorfullife.com>
First post2015-11-01 05:40 +0100
Last post2015-11-03 16:00 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] ipc/msg: Implement lockless pipelined wakeups Manfred Spraul <manfred@colorfullife.com> - 2015-11-01 05:40 +0100
    Re: [PATCH] ipc/msg: Implement lockless pipelined wakeups Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2015-11-03 16:00 +0100

#1260079 — Re: [PATCH] ipc/msg: Implement lockless pipelined wakeups

FromManfred Spraul <manfred@colorfullife.com>
Date2015-11-01 05:40 +0100
SubjectRe: [PATCH] ipc/msg: Implement lockless pipelined wakeups
Message-ID<qpSAV-3Cq-1@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

Hi Sebastian,

On 10/30/2015 12:26 PM, Sebastian Andrzej Siewior wrote:
> This patch moves the wakeup_process() invocation so it is not done under
> the perm->lock by making use of a lockless wake_q. With this change, the
> waiter is woken up once the message has been assigned and it does not
> need to loop on SMP if the message points to NULL. In the signal case we
> still need to check the pointer under the lock to verify the state.
>
> This change should also avoid the introduction of preempt_disable() in
> -RT which avoids a busy-loop which pools for the NULL -> !NULL
> change if the waiter has a higher priority compared to the waker.
with regards to functional tests:
fakeroot is a heavy system V user (at least if it is configured for sysv).
"make -j" under fakeroot was a useful stresstest

with regards to benchmarks:
I've attached one of my files.

Otherwise: Nice!

--
     Manfred

[toc] | [next] | [standalone]


#1261553

FromSebastian Andrzej Siewior <bigeasy@linutronix.de>
Date2015-11-03 16:00 +0100
Message-ID<qqLe1-41D-1@gated-at.bofh.it>
In reply to#1260079
On 11/01/2015 05:32 AM, Manfred Spraul wrote:
> Hi Sebastian,

Hi Manfred,

> with regards to functional tests:
> fakeroot is a heavy system V user (at least if it is configured for sysv).
> "make -j" under fakeroot was a useful stresstest

I don't see the msgsnd/msgrcv syscalls here. I do see others, sem
related for instance….

> with regards to benchmarks:
> I've attached one of my files.

Thank you. On 'AMD A10-7800 Radeon R7, 12 Compute Cores 4C+8G' I have
here:

test             |  before    |   after    | diff
-----------------|------------|-------------
pmsg-shared 8 60 | 52,386,363 | 56,455,763 | + ~7.77%
pmsg-shared 2 60 | 69,200,531 | 73,346,420 | + ~5.99%

so it improved a little :)

> Otherwise: Nice!
> 
> -- 
>     Manfred
> 

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web