Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1260270 > unrolled thread
| Started by | Hugh Dickins <hughd@google.com> |
|---|---|
| First post | 2015-11-02 01:10 +0100 |
| Last post | 2015-11-03 03:40 +0100 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 3/8] arch: uapi: asm: mman.h: Let MADV_FREE have same value for all architectures Hugh Dickins <hughd@google.com> - 2015-11-02 01:10 +0100
Re: [PATCH 3/8] arch: uapi: asm: mman.h: Let MADV_FREE have same value for all architectures Minchan Kim <minchan@kernel.org> - 2015-11-03 03:40 +0100
Re: [PATCH 3/8] arch: uapi: asm: mman.h: Let MADV_FREE have same value for all architectures David Miller <davem@davemloft.net> - 2015-11-03 04:40 +0100
Re: [PATCH 3/8] arch: uapi: asm: mman.h: Let MADV_FREE have same value for all architectures Minchan Kim <minchan@kernel.org> - 2015-11-03 05:40 +0100
Re: [PATCH 3/8] arch: uapi: asm: mman.h: Let MADV_FREE have same value for all architectures Minchan Kim <minchan@kernel.org> - 2015-11-03 03:40 +0100
| From | Hugh Dickins <hughd@google.com> |
|---|---|
| Date | 2015-11-02 01:10 +0100 |
| Subject | Re: [PATCH 3/8] arch: uapi: asm: mman.h: Let MADV_FREE have same value for all architectures |
| Message-ID | <qqaRc-6FZ-19@gated-at.bofh.it> |
On Fri, 30 Oct 2015, Minchan Kim wrote: > From: Chen Gang <gang.chen.5i5j@gmail.com> > > For uapi, need try to let all macros have same value, and MADV_FREE is > added into main branch recently, so need redefine MADV_FREE for it. > > At present, '8' can be shared with all architectures, so redefine it to > '8'. > > Cc: rth@twiddle.net <rth@twiddle.net>, > Cc: ink@jurassic.park.msu.ru <ink@jurassic.park.msu.ru> > Cc: mattst88@gmail.com <mattst88@gmail.com> > Cc: Ralf Baechle <ralf@linux-mips.org> > Cc: jejb@parisc-linux.org <jejb@parisc-linux.org> > Cc: deller@gmx.de <deller@gmx.de> > Cc: chris@zankel.net <chris@zankel.net> > Cc: jcmvbkbc@gmail.com <jcmvbkbc@gmail.com> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: linux-arch@vger.kernel.org > Cc: linux-api@vger.kernel.org > Acked-by: Minchan Kim <minchan@kernel.org> > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> Let me add Acked-by: Hugh Dickins <hughd@google.com> to this one too. But I have extended your mail's Cc list: Darrick pointed out earlier that dietlibc has a Solaris #define MADV_FREE 0x5 in its mman.h, and that was in the kernel's sparc mman.h up until 2.6.25. I doubt that presents any obstacle nowadays, but Dave Miller should be Cc'ed. I was a little suspicious that 8 is available for MADV_FREE: why did the common/generic parameters start at 9 instead of 8 back in 2.6.16? I think the answer is that we had MADV_REMOVE coming in from one direction, and MADV_DONTFORK coming from another direction, and when Roland looked for where to start the commons for MADV_DONTFORK, it appeared that 8 was occupied - by MADV_REMOVE; then a little later MADV_REMOVE was shifted to become the first of the commons, at 9. Hugh > --- > arch/alpha/include/uapi/asm/mman.h | 2 +- > arch/mips/include/uapi/asm/mman.h | 2 +- > arch/parisc/include/uapi/asm/mman.h | 2 +- > arch/xtensa/include/uapi/asm/mman.h | 2 +- > include/uapi/asm-generic/mman-common.h | 2 +- > 5 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/alpha/include/uapi/asm/mman.h b/arch/alpha/include/uapi/asm/mman.h > index 836fbd44f65b..0b8a5de7aee3 100644 > --- a/arch/alpha/include/uapi/asm/mman.h > +++ b/arch/alpha/include/uapi/asm/mman.h > @@ -44,9 +44,9 @@ > #define MADV_WILLNEED 3 /* will need these pages */ > #define MADV_SPACEAVAIL 5 /* ensure resources are available */ > #define MADV_DONTNEED 6 /* don't need these pages */ > -#define MADV_FREE 7 /* free pages only if memory pressure */ > > /* common/generic parameters */ > +#define MADV_FREE 8 /* free pages only if memory pressure */ > #define MADV_REMOVE 9 /* remove these pages & resources */ > #define MADV_DONTFORK 10 /* don't inherit across fork */ > #define MADV_DOFORK 11 /* do inherit across fork */ > diff --git a/arch/mips/include/uapi/asm/mman.h b/arch/mips/include/uapi/asm/mman.h > index 106e741aa7ee..d247f5457944 100644 > --- a/arch/mips/include/uapi/asm/mman.h > +++ b/arch/mips/include/uapi/asm/mman.h > @@ -67,9 +67,9 @@ > #define MADV_SEQUENTIAL 2 /* expect sequential page references */ > #define MADV_WILLNEED 3 /* will need these pages */ > #define MADV_DONTNEED 4 /* don't need these pages */ > -#define MADV_FREE 5 /* free pages only if memory pressure */ > > /* common parameters: try to keep these consistent across architectures */ > +#define MADV_FREE 8 /* free pages only if memory pressure */ > #define MADV_REMOVE 9 /* remove these pages & resources */ > #define MADV_DONTFORK 10 /* don't inherit across fork */ > #define MADV_DOFORK 11 /* do inherit across fork */ > diff --git a/arch/parisc/include/uapi/asm/mman.h b/arch/parisc/include/uapi/asm/mman.h > index 6cb8db76fd4e..700d83fd9352 100644 > --- a/arch/parisc/include/uapi/asm/mman.h > +++ b/arch/parisc/include/uapi/asm/mman.h > @@ -40,9 +40,9 @@ > #define MADV_SPACEAVAIL 5 /* insure that resources are reserved */ > #define MADV_VPS_PURGE 6 /* Purge pages from VM page cache */ > #define MADV_VPS_INHERIT 7 /* Inherit parents page size */ > -#define MADV_FREE 8 /* free pages only if memory pressure */ > > /* common/generic parameters */ > +#define MADV_FREE 8 /* free pages only if memory pressure */ > #define MADV_REMOVE 9 /* remove these pages & resources */ > #define MADV_DONTFORK 10 /* don't inherit across fork */ > #define MADV_DOFORK 11 /* do inherit across fork */ > diff --git a/arch/xtensa/include/uapi/asm/mman.h b/arch/xtensa/include/uapi/asm/mman.h > index 1b19f25bc567..77eaca434071 100644 > --- a/arch/xtensa/include/uapi/asm/mman.h > +++ b/arch/xtensa/include/uapi/asm/mman.h > @@ -80,9 +80,9 @@ > #define MADV_SEQUENTIAL 2 /* expect sequential page references */ > #define MADV_WILLNEED 3 /* will need these pages */ > #define MADV_DONTNEED 4 /* don't need these pages */ > -#define MADV_FREE 5 /* free pages only if memory pressure */ > > /* common parameters: try to keep these consistent across architectures */ > +#define MADV_FREE 8 /* free pages only if memory pressure */ > #define MADV_REMOVE 9 /* remove these pages & resources */ > #define MADV_DONTFORK 10 /* don't inherit across fork */ > #define MADV_DOFORK 11 /* do inherit across fork */ > diff --git a/include/uapi/asm-generic/mman-common.h b/include/uapi/asm-generic/mman-common.h > index 7a94102b7a02..869595947873 100644 > --- a/include/uapi/asm-generic/mman-common.h > +++ b/include/uapi/asm-generic/mman-common.h > @@ -34,9 +34,9 @@ > #define MADV_SEQUENTIAL 2 /* expect sequential page references */ > #define MADV_WILLNEED 3 /* will need these pages */ > #define MADV_DONTNEED 4 /* don't need these pages */ > -#define MADV_FREE 5 /* free pages only if memory pressure */ > > /* common parameters: try to keep these consistent across architectures */ > +#define MADV_FREE 8 /* free pages only if memory pressure */ > #define MADV_REMOVE 9 /* remove these pages & resources */ > #define MADV_DONTFORK 10 /* don't inherit across fork */ > #define MADV_DOFORK 11 /* do inherit across fork */ > -- > 1.9.1 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Minchan Kim <minchan@kernel.org> |
|---|---|
| Date | 2015-11-03 03:40 +0100 |
| Message-ID | <qqzFT-50z-1@gated-at.bofh.it> |
| In reply to | #1260270 |
On Tue, Nov 03, 2015 at 11:32:51AM +0900, Minchan Kim wrote:
> On Sun, Nov 01, 2015 at 04:08:27PM -0800, Hugh Dickins wrote:
> > On Fri, 30 Oct 2015, Minchan Kim wrote:
> > > From: Chen Gang <gang.chen.5i5j@gmail.com>
> > >
> > > For uapi, need try to let all macros have same value, and MADV_FREE is
> > > added into main branch recently, so need redefine MADV_FREE for it.
> > >
> > > At present, '8' can be shared with all architectures, so redefine it to
> > > '8'.
> > >
> > > Cc: rth@twiddle.net <rth@twiddle.net>,
> > > Cc: ink@jurassic.park.msu.ru <ink@jurassic.park.msu.ru>
> > > Cc: mattst88@gmail.com <mattst88@gmail.com>
> > > Cc: Ralf Baechle <ralf@linux-mips.org>
> > > Cc: jejb@parisc-linux.org <jejb@parisc-linux.org>
> > > Cc: deller@gmx.de <deller@gmx.de>
> > > Cc: chris@zankel.net <chris@zankel.net>
> > > Cc: jcmvbkbc@gmail.com <jcmvbkbc@gmail.com>
> > > Cc: Arnd Bergmann <arnd@arndb.de>
> > > Cc: linux-arch@vger.kernel.org
> > > Cc: linux-api@vger.kernel.org
> > > Acked-by: Minchan Kim <minchan@kernel.org>
> > > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> >
> > Let me add
> > Acked-by: Hugh Dickins <hughd@google.com>
> > to this one too.
> >
> > But I have extended your mail's Cc list: Darrick pointed out earlier
> > that dietlibc has a Solaris #define MADV_FREE 0x5 in its mman.h,
> > and that was in the kernel's sparc mman.h up until 2.6.25. I doubt
> > that presents any obstacle nowadays, but Dave Miller should be Cc'ed.
For the convenience for Dave, I found this.
commit ec98c6b9b47df6df1c1fa6cf3d427414f8c2cf16
Author: David S. Miller <davem@davemloft.net>
Date: Sun Apr 20 02:14:23 2008 -0700
[SPARC]: Remove SunOS and Solaris binary support.
As per Documentation/feature-removal-schedule.txt
Signed-off-by: David S. Miller <davem@davemloft.net>
Hello Dave,
Could you confirm it?
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2015-11-03 04:40 +0100 |
| Message-ID | <qqABY-5Gc-7@gated-at.bofh.it> |
| In reply to | #1261163 |
From: Minchan Kim <minchan@kernel.org> Date: Tue, 3 Nov 2015 11:36:51 +0900 > For the convenience for Dave, I found this. > > commit ec98c6b9b47df6df1c1fa6cf3d427414f8c2cf16 > Author: David S. Miller <davem@davemloft.net> > Date: Sun Apr 20 02:14:23 2008 -0700 > > [SPARC]: Remove SunOS and Solaris binary support. > > As per Documentation/feature-removal-schedule.txt > > Signed-off-by: David S. Miller <davem@davemloft.net> > > Hello Dave, > Could you confirm it? I don't understand what you want me to confirm. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Minchan Kim <minchan@kernel.org> |
|---|---|
| Date | 2015-11-03 05:40 +0100 |
| Message-ID | <qqBy1-6hw-5@gated-at.bofh.it> |
| In reply to | #1261177 |
On Mon, Nov 02, 2015 at 10:36:52PM -0500, David Miller wrote: > From: Minchan Kim <minchan@kernel.org> > Date: Tue, 3 Nov 2015 11:36:51 +0900 > > > For the convenience for Dave, I found this. > > > > commit ec98c6b9b47df6df1c1fa6cf3d427414f8c2cf16 > > Author: David S. Miller <davem@davemloft.net> > > Date: Sun Apr 20 02:14:23 2008 -0700 > > > > [SPARC]: Remove SunOS and Solaris binary support. > > > > As per Documentation/feature-removal-schedule.txt > > > > Signed-off-by: David S. Miller <davem@davemloft.net> > > > > Hello Dave, > > Could you confirm it? > > I don't understand what you want me to confirm. Sorry for lacking of the information. Is it okay to use number 8 for upcoming madvise(addr, len, MADV_FREE) feature in sparc arch? The reason to ask is that Darrick pointed out earlier that dietlibc has a Solaris #define MADV_FREE 0x5 in its mman.h and Hugh pointed out that was in the kernel's sparc mman.h up until 2.6.25 but disappeared now so I guess it's okay to use the number 8 for MADV_FREE in sparc but want to confirm from you. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Minchan Kim <minchan@kernel.org> |
|---|---|
| Date | 2015-11-03 03:40 +0100 |
| Message-ID | <qqzFT-50z-3@gated-at.bofh.it> |
| In reply to | #1260270 |
On Sun, Nov 01, 2015 at 04:08:27PM -0800, Hugh Dickins wrote: > On Fri, 30 Oct 2015, Minchan Kim wrote: > > From: Chen Gang <gang.chen.5i5j@gmail.com> > > > > For uapi, need try to let all macros have same value, and MADV_FREE is > > added into main branch recently, so need redefine MADV_FREE for it. > > > > At present, '8' can be shared with all architectures, so redefine it to > > '8'. > > > > Cc: rth@twiddle.net <rth@twiddle.net>, > > Cc: ink@jurassic.park.msu.ru <ink@jurassic.park.msu.ru> > > Cc: mattst88@gmail.com <mattst88@gmail.com> > > Cc: Ralf Baechle <ralf@linux-mips.org> > > Cc: jejb@parisc-linux.org <jejb@parisc-linux.org> > > Cc: deller@gmx.de <deller@gmx.de> > > Cc: chris@zankel.net <chris@zankel.net> > > Cc: jcmvbkbc@gmail.com <jcmvbkbc@gmail.com> > > Cc: Arnd Bergmann <arnd@arndb.de> > > Cc: linux-arch@vger.kernel.org > > Cc: linux-api@vger.kernel.org > > Acked-by: Minchan Kim <minchan@kernel.org> > > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> > > Let me add > Acked-by: Hugh Dickins <hughd@google.com> > to this one too. > > But I have extended your mail's Cc list: Darrick pointed out earlier > that dietlibc has a Solaris #define MADV_FREE 0x5 in its mman.h, > and that was in the kernel's sparc mman.h up until 2.6.25. I doubt > that presents any obstacle nowadays, but Dave Miller should be Cc'ed. > > I was a little suspicious that 8 is available for MADV_FREE: why did > the common/generic parameters start at 9 instead of 8 back in 2.6.16? > I think the answer is that we had MADV_REMOVE coming in from one > direction, and MADV_DONTFORK coming from another direction, and when > Roland looked for where to start the commons for MADV_DONTFORK, it > appeared that 8 was occupied - by MADV_REMOVE; then a little later > MADV_REMOVE was shifted to become the first of the commons, at 9. Thanks for Ack, Ccing relevant people and history! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web