Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1260193 > unrolled thread

linux-next: build failure after merge of the akpm-current tree

Back to article view | Back to linux.kernel

Contents

  linux-next: build failure after merge of the akpm-current tree Stephen Rothwell <sfr@canb.auug.org.au> - 2015-11-01 17:20 +0100
    Re: linux-next: build failure after merge of the akpm-current tree kbuild test robot <lkp@intel.com> - 2015-11-01 17:30 +0100
      Re: linux-next: build failure after merge of the akpm-current tree Oleg Nesterov <oleg@redhat.com> - 2015-11-01 18:50 +0100
        Re: [kbuild-all] linux-next: build failure after merge of the  akpm-current tree Fengguang Wu <lkp@intel.com> - 2015-11-02 03:50 +0100
    Re: linux-next: build failure after merge of the akpm-current tree Oleg Nesterov <oleg@redhat.com> - 2015-11-01 18:40 +0100
      Re: linux-next: build failure after merge of the akpm-current tree Stephen Rothwell <sfr@canb.auug.org.au> - 2015-11-01 22:50 +0100

#1260193 — linux-next: build failure after merge of the akpm-current tree

Hi Andrew,

After merging the akpm-current tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/block/nbd.c: In function 'nbd_thread_send':
drivers/block/nbd.c:592:3: error: implicit declaration of function 'dequeue_signal_lock' [-Werror=implicit-function-declaration]
   dequeue_signal_lock(current, &current->blocked, &info);
   ^

Caused by commit

  ffcb8dc55a97 ("signal: turn dequeue_signal_lock() into kernel_dequeue_signal()")

interacting with commit

  dcc909d90ccd ("nbd: Add locking for tasks")

from Linus' tree.

I added this merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 2 Nov 2015 03:04:27 +1100
Subject: [PATCH] ndb: fix up for dequeue_signal_lock API change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/block/nbd.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 5101fd2aca77..93b3f99b6865 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -587,10 +587,8 @@ static int nbd_thread_send(void *data)
 	spin_unlock_irqrestore(&nbd->tasks_lock, flags);
 
 	/* Clear maybe pending signals */
-	if (signal_pending(current)) {
-		siginfo_t info;
-		dequeue_signal_lock(current, &current->blocked, &info);
-	}
+	if (signal_pending(current))
+		kernel_dequeue_signal(NULL);
 
 	return 0;
 }
-- 
2.6.1

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1260197

[Multipart message — attachments visible in raw view] — view raw

Hi Stephen,

[auto build test ERROR on v4.3-rc7 -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/Stephen-Rothwell/linux-next-build-failure-after-merge-of-the-akpm-current-tree/20151102-001657
config: i386-randconfig-x004-11010709 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/block/nbd.c: In function 'nbd_thread_send':
>> drivers/block/nbd.c:596:3: error: implicit declaration of function 'kernel_dequeue_signal' [-Werror=implicit-function-declaration]
      kernel_dequeue_signal(NULL);
      ^
   cc1: some warnings being treated as errors

vim +/kernel_dequeue_signal +596 drivers/block/nbd.c

   590		spin_lock_irqsave(&nbd->tasks_lock, flags);
   591		nbd->task_send = NULL;
   592		spin_unlock_irqrestore(&nbd->tasks_lock, flags);
   593	
   594		/* Clear maybe pending signals */
   595		if (signal_pending(current))
 > 596			kernel_dequeue_signal(NULL);
   597	
   598		return 0;
   599	}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [prev] | [next] | [standalone]

#1260210

On 11/02, kbuild test robot wrote:
>
> Hi Stephen,
>
> [auto build test ERROR on v4.3-rc7 -- if it's inappropriate base, please suggest rules for selecting the more suitable base]
>
> url:    https://github.com/0day-ci/linux/commits/Stephen-Rothwell/linux-next-build-failure-after-merge-of-the-akpm-current-tree/20151102-001657
> config: i386-randconfig-x004-11010709 (attached as .config)
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386
>
> All errors (new ones prefixed by >>):
>
>    drivers/block/nbd.c: In function 'nbd_thread_send':
> >> drivers/block/nbd.c:596:3: error: implicit declaration of function 'kernel_dequeue_signal' [-Werror=implicit-function-declaration]
>       kernel_dequeue_signal(NULL);
>       ^
>    cc1: some warnings being treated as errors
>
> vim +/kernel_dequeue_signal +596 drivers/block/nbd.c
>
>    590		spin_lock_irqsave(&nbd->tasks_lock, flags);
>    591		nbd->task_send = NULL;
>    592		spin_unlock_irqrestore(&nbd->tasks_lock, flags);
>    593
>    594		/* Clear maybe pending signals */
>    595		if (signal_pending(current))
>  > 596			kernel_dequeue_signal(NULL);
>    597
>    598		return 0;
>    599	}

Yes, de90fc653be60b4cec1a4d40f0e82164ec79f077 ("linux-next: build failure
after merge of the akpm-current tree") should be applied on top of -mm.

Hopefully this all was fixed by
signal-turn-dequeue_signal_lock-into-kernel_dequeue_signal-fix.patch
already in -mm.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1260308 — Re: [kbuild-all] linux-next: build failure after merge of the akpm-current tree

On Sun, Nov 01, 2015 at 07:37:55PM +0100, Oleg Nesterov wrote:
> On 11/02, kbuild test robot wrote:
> >
> > Hi Stephen,
> >
> > [auto build test ERROR on v4.3-rc7 -- if it's inappropriate base, please suggest rules for selecting the more suitable base]
> >
> > url:    https://github.com/0day-ci/linux/commits/Stephen-Rothwell/linux-next-build-failure-after-merge-of-the-akpm-current-tree/20151102-001657
> > config: i386-randconfig-x004-11010709 (attached as .config)
> > reproduce:
> >         # save the attached .config to linux build tree
> >         make ARCH=i386
> >
> > All errors (new ones prefixed by >>):
> >
> >    drivers/block/nbd.c: In function 'nbd_thread_send':
> > >> drivers/block/nbd.c:596:3: error: implicit declaration of function 'kernel_dequeue_signal' [-Werror=implicit-function-declaration]
> >       kernel_dequeue_signal(NULL);
> >       ^
> >    cc1: some warnings being treated as errors
> >
> > vim +/kernel_dequeue_signal +596 drivers/block/nbd.c
> >
> >    590		spin_lock_irqsave(&nbd->tasks_lock, flags);
> >    591		nbd->task_send = NULL;
> >    592		spin_unlock_irqrestore(&nbd->tasks_lock, flags);
> >    593
> >    594		/* Clear maybe pending signals */
> >    595		if (signal_pending(current))
> >  > 596			kernel_dequeue_signal(NULL);
> >    597
> >    598		return 0;
> >    599	}
> 
> Yes, de90fc653be60b4cec1a4d40f0e82164ec79f077 ("linux-next: build failure
> after merge of the akpm-current tree") should be applied on top of -mm.

Yes, sorry for the noise! I'll skip testing Stephen's linux-next fixup
patches. It turns out to be time sensitive: the robot might see the
build fix patch in mailing list before see the updated linux-next git
tree, which makes git-am to linux-next failed and fallback to git-am
to RC release.

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1260206

On 11/02, Stephen Rothwell wrote:
>
> Hi Andrew,
>
> After merging the akpm-current tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> drivers/block/nbd.c: In function 'nbd_thread_send':
> drivers/block/nbd.c:592:3: error: implicit declaration of function 'dequeue_signal_lock' [-Werror=implicit-function-declaration]
>    dequeue_signal_lock(current, &current->blocked, &info);
>    ^
>
> Caused by commit
>
>   ffcb8dc55a97 ("signal: turn dequeue_signal_lock() into kernel_dequeue_signal()")
>
> interacting with commit
>
>   dcc909d90ccd ("nbd: Add locking for tasks")
>
> from Linus' tree.

Yes, thanks, this should be fixed by

	signal-turn-dequeue_signal_lock-into-kernel_dequeue_signal-fix.patch

in -mm tree,

> I added this merge fix patch:

the same as the patch above, thanks.

> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 2 Nov 2015 03:04:27 +1100
> Subject: [PATCH] ndb: fix up for dequeue_signal_lock API change
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/block/nbd.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
> index 5101fd2aca77..93b3f99b6865 100644
> --- a/drivers/block/nbd.c
> +++ b/drivers/block/nbd.c
> @@ -587,10 +587,8 @@ static int nbd_thread_send(void *data)
>  	spin_unlock_irqrestore(&nbd->tasks_lock, flags);
>
>  	/* Clear maybe pending signals */
> -	if (signal_pending(current)) {
> -		siginfo_t info;
> -		dequeue_signal_lock(current, &current->blocked, &info);
> -	}
> +	if (signal_pending(current))
> +		kernel_dequeue_signal(NULL);
>
>  	return 0;
>  }
> --
> 2.6.1
>
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1260244

Hi Oleg,

On Sun, 1 Nov 2015 19:26:46 +0100 Oleg Nesterov <oleg@redhat.com> wrote:
>
> On 11/02, Stephen Rothwell wrote:
> >
> > After merging the akpm-current tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> >
> > drivers/block/nbd.c: In function 'nbd_thread_send':
> > drivers/block/nbd.c:592:3: error: implicit declaration of function 'dequeue_signal_lock' [-Werror=implicit-function-declaration]
> >    dequeue_signal_lock(current, &current->blocked, &info);
> >    ^
> >
> > Caused by commit
> >
> >   ffcb8dc55a97 ("signal: turn dequeue_signal_lock() into kernel_dequeue_signal()")
> >
> > interacting with commit
> >
> >   dcc909d90ccd ("nbd: Add locking for tasks")
> >
> > from Linus' tree.  
> 
> Yes, thanks, this should be fixed by
> 
> 	signal-turn-dequeue_signal_lock-into-kernel_dequeue_signal-fix.patch

But not published yet ... but thanks for the confirmation.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web