Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1256698 > unrolled thread
| Started by | huangdaode <huangdaode@hisilicon.com> |
|---|---|
| First post | 2015-10-27 12:10 +0100 |
| Last post | 2015-11-12 03:20 +0100 |
| Articles | 7 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH RESEND v2 net-next] net: hisilicon: updates HNS config and documents huangdaode <huangdaode@hisilicon.com> - 2015-10-27 12:10 +0100
Re: [PATCH RESEND v2 net-next] net: hisilicon: updates HNS config and documents David Miller <davem@davemloft.net> - 2015-10-28 04:10 +0100
Re: [PATCH RESEND v2 net-next] net: hisilicon: updates HNS config and documents Arnd Bergmann <arnd@arndb.de> - 2015-10-30 15:30 +0100
Re: [PATCH RESEND v2 net-next] net: hisilicon: updates HNS config and documents huangdaode <huangdaode@hisilicon.com> - 2015-10-31 02:50 +0100
Re: [PATCH RESEND v2 net-next] net: hisilicon: updates HNS config and documents Salil Mehta <salil.mehta@huawei.com> - 2015-10-31 03:20 +0100
Re: [PATCH RESEND v2 net-next] net: hisilicon: updates HNS config and documents Arnd Bergmann <arnd@arndb.de> - 2015-11-02 23:10 +0100
Re: [PATCH RESEND v2 net-next] net: hisilicon: updates HNS config and documents huangdaode <huangdaode@hisilicon.com> - 2015-11-12 03:20 +0100
| From | huangdaode <huangdaode@hisilicon.com> |
|---|---|
| Date | 2015-10-27 12:10 +0100 |
| Subject | [PATCH RESEND v2 net-next] net: hisilicon: updates HNS config and documents |
| Message-ID | <qoaiC-4ul-15@gated-at.bofh.it> |
From: yankejian <yankejian@huawei.com>
updates the bindings documents and dtsi file according to the review
comments[https://lkml.org/lkml/2015/9/21/670] from Rob Herring <robh@kernel.org>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: yankejian <yankejian@huawei.com>
Signed-off-by: huangdaode <huangdaode@hisilicon.com>
---
Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt | 2 +-
arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt b/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt
index 9940aa0..9c23fdf 100644
--- a/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt
+++ b/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt
@@ -12,7 +12,7 @@ Example:
mdio@803c0000 {
#address-cells = <1>;
#size-cells = <0>;
- compatible = "hisilicon,mdio","hisilicon,hns-mdio";
+ compatible = "hisilicon,hns-mdio","hisilicon,mdio";
reg = <0x0 0x803c0000 0x0 0x10000>;
ethernet-phy@0 {
diff --git a/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi b/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi
index 3500586..606dd5a 100644
--- a/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi
@@ -13,14 +13,12 @@ soc0: soc@000000000 {
reg = <0x0 0x803c0000 0x0 0x10000
0x0 0x80000000 0x0 0x10000>;
- soc0_phy4: ethernet-phy@4 {
+ soc0_phy0: ethernet-phy@0 {
reg = <0x0>;
- device_type = "ethernet-phy";
compatible = "ethernet-phy-ieee802.3-c22";
};
- soc0_phy5: ethernet-phy@5 {
+ soc0_phy1: ethernet-phy@1 {
reg = <0x1>;
- device_type = "ethernet-phy";
compatible = "ethernet-phy-ieee802.3-c22";
};
};
@@ -37,7 +35,7 @@ soc0: soc@000000000 {
0x0 0xc7000000 0x0 0x60000
>;
- phy-handle = <0 0 0 0 &soc0_phy4 &soc0_phy5 0 0>;
+ phy-handle = <0 0 0 0 &soc0_phy0 &soc0_phy1 0 0>;
interrupts = <
/* [14] ge fifo err 8 / xge 6**/
149 0x4 150 0x4 151 0x4 152 0x4
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2015-10-28 04:10 +0100 |
| Subject | Re: [PATCH RESEND v2 net-next] net: hisilicon: updates HNS config and documents |
| Message-ID | <qophD-5qX-5@gated-at.bofh.it> |
| In reply to | #1256698 |
From: huangdaode <huangdaode@hisilicon.com> Date: Tue, 27 Oct 2015 19:16:34 +0800 > From: yankejian <yankejian@huawei.com> > > updates the bindings documents and dtsi file according to the review > comments[https://lkml.org/lkml/2015/9/21/670] from Rob Herring <robh@kernel.org> > > Acked-by: Rob Herring <robh@kernel.org> > Signed-off-by: yankejian <yankejian@huawei.com> > Signed-off-by: huangdaode <huangdaode@hisilicon.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2015-10-30 15:30 +0100 |
| Message-ID | <qpiQO-6Tg-17@gated-at.bofh.it> |
| In reply to | #1256698 |
On Tuesday 27 October 2015 19:16:34 huangdaode wrote:
> mdio@803c0000 {
> #address-cells = <1>;
> #size-cells = <0>;
> - compatible = "hisilicon,mdio","hisilicon,hns-mdio";
> + compatible = "hisilicon,hns-mdio","hisilicon,mdio";
> reg = <0x0 0x803c0000 0x0 0x10000>;
>
>
Does "hisilicon,mdio" actually have a specific meaning? Is that just there
for legacy reasons?
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | huangdaode <huangdaode@hisilicon.com> |
|---|---|
| Date | 2015-10-31 02:50 +0100 |
| Subject | Re: [PATCH RESEND v2 net-next] net: hisilicon: updates HNS config and documents |
| Message-ID | <qptsR-4Wn-5@gated-at.bofh.it> |
| In reply to | #1259529 |
On 2015/10/30 22:20, Arnd Bergmann wrote:
> On Tuesday 27 October 2015 19:16:34 huangdaode wrote:
>> mdio@803c0000 {
>> #address-cells = <1>;
>> #size-cells = <0>;
>> - compatible = "hisilicon,mdio","hisilicon,hns-mdio";
>> + compatible = "hisilicon,hns-mdio","hisilicon,mdio";
>> reg = <0x0 0x803c0000 0x0 0x10000>;
>>
>>
> Does "hisilicon,mdio" actually have a specific meaning? Is that just there
> for legacy reasons?
>
> Arnd
>
> .
>
hi Arnd,
"hisilicon,mdio" is the gernerical configuation compatible for the
default hisilicon chip,
We use generic hisilicon since our MDIO/PHY is same across flavour of SoCs.
--
Best Regards
Daode Huang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Salil Mehta <salil.mehta@huawei.com> |
|---|---|
| Date | 2015-10-31 03:20 +0100 |
| Subject | Re: [PATCH RESEND v2 net-next] net: hisilicon: updates HNS config and documents |
| Message-ID | <qptVU-5mo-5@gated-at.bofh.it> |
| In reply to | #1259892 |
On 10/31/2015 1:40 AM, huangdaode wrote:
> On 2015/10/30 22:20, Arnd Bergmann wrote:
>> On Tuesday 27 October 2015 19:16:34 huangdaode wrote:
>>> mdio@803c0000 {
>>> #address-cells = <1>;
>>> #size-cells = <0>;
>>> - compatible = "hisilicon,mdio","hisilicon,hns-mdio";
>>> + compatible = "hisilicon,hns-mdio","hisilicon,mdio";
>>> reg = <0x0 0x803c0000 0x0 0x10000>;
>>>
>> Does "hisilicon,mdio" actually have a specific meaning? Is that just
>> there
>> for legacy reasons?
>>
>> Arnd
>>
>> .
>>
> hi Arnd,
> "hisilicon,mdio" is the gernerical configuation compatible for the
> default hisilicon chip,
> We use generic hisilicon since our MDIO/PHY is same across flavour of
> SoCs.
>
Hi Arnd,
Yes, "hisilicon,mdio" exists for the legacy reasons to support older SoC
Hip04.
Best Regards
Salil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2015-11-02 23:10 +0100 |
| Message-ID | <qqvsB-2u9-1@gated-at.bofh.it> |
| In reply to | #1259904 |
On Saturday 31 October 2015 02:18:19 Salil Mehta wrote:
> On 10/31/2015 1:40 AM, huangdaode wrote:
> > On 2015/10/30 22:20, Arnd Bergmann wrote:
> >> On Tuesday 27 October 2015 19:16:34 huangdaode wrote:
> >>> mdio@803c0000 {
> >>> #address-cells = <1>;
> >>> #size-cells = <0>;
> >>> - compatible = "hisilicon,mdio","hisilicon,hns-mdio";
> >>> + compatible = "hisilicon,hns-mdio","hisilicon,mdio";
> >>> reg = <0x0 0x803c0000 0x0 0x10000>;
> >>>
> >> Does "hisilicon,mdio" actually have a specific meaning? Is that just
> >> there
> >> for legacy reasons?
> >>
> >> Arnd
> >>
> >> .
> >>
> > hi Arnd,
> > "hisilicon,mdio" is the gernerical configuation compatible for the
> > default hisilicon chip,
> > We use generic hisilicon since our MDIO/PHY is same across flavour of
> > SoCs.
> >
> Hi Arnd,
> Yes, "hisilicon,mdio" exists for the legacy reasons to support older SoC
> Hip04.
I see. In that case, that compatible string should probably be mentioned
only as 'optional' in the binding, and not used for devices other than
hip04.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | huangdaode <huangdaode@hisilicon.com> |
|---|---|
| Date | 2015-11-12 03:20 +0100 |
| Subject | Re: [PATCH RESEND v2 net-next] net: hisilicon: updates HNS config and documents |
| Message-ID | <qtPEu-2Lj-11@gated-at.bofh.it> |
| In reply to | #1261014 |
On 2015/11/3 6:05, Arnd Bergmann wrote:
> On Saturday 31 October 2015 02:18:19 Salil Mehta wrote:
>> On 10/31/2015 1:40 AM, huangdaode wrote:
>>> On 2015/10/30 22:20, Arnd Bergmann wrote:
>>>> On Tuesday 27 October 2015 19:16:34 huangdaode wrote:
>>>>> mdio@803c0000 {
>>>>> #address-cells = <1>;
>>>>> #size-cells = <0>;
>>>>> - compatible = "hisilicon,mdio","hisilicon,hns-mdio";
>>>>> + compatible = "hisilicon,hns-mdio","hisilicon,mdio";
>>>>> reg = <0x0 0x803c0000 0x0 0x10000>;
>>>>>
>>>> Does "hisilicon,mdio" actually have a specific meaning? Is that just
>>>> there
>>>> for legacy reasons?
>>>>
>>>> Arnd
>>>>
>>>> .
>>>>
>>> hi Arnd,
>>> "hisilicon,mdio" is the gernerical configuation compatible for the
>>> default hisilicon chip,
>>> We use generic hisilicon since our MDIO/PHY is same across flavour of
>>> SoCs.
>>>
>> Hi Arnd,
>> Yes, "hisilicon,mdio" exists for the legacy reasons to support older SoC
>> Hip04.
> I see. In that case, that compatible string should probably be mentioned
> only as 'optional' in the binding, and not used for devices other than
> hip04.
>
> Arnd
>
> .
>
Hi, Arnd
ok, ill send a patch to specify it, please Ack then.
thanks
Daode.
--
Best Regards
Daode Huang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web