Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1258670 > unrolled thread

[PATCH] reset: sunxi: mark the of_device_id array as __initconst

Started byPhilipp Zabel <p.zabel@pengutronix.de>
First post2015-10-29 10:20 +0100
Last post2015-11-02 08:30 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] reset: sunxi: mark the of_device_id array as __initconst Philipp Zabel <p.zabel@pengutronix.de> - 2015-10-29 10:20 +0100
    Re: [PATCH] reset: sunxi: mark the of_device_id array as __initconst Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-30 17:50 +0100
    Re: [PATCH] reset: sunxi: mark the of_device_id array as __initconst Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2015-11-02 08:30 +0100

#1258670 — [PATCH] reset: sunxi: mark the of_device_id array as __initconst

FromPhilipp Zabel <p.zabel@pengutronix.de>
Date2015-10-29 10:20 +0100
Subject[PATCH] reset: sunxi: mark the of_device_id array as __initconst
Message-ID<qoRxg-6K9-11@gated-at.bofh.it>
Since this array is static const, it should be marked as __initconst.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/reset/reset-sunxi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/reset/reset-sunxi.c b/drivers/reset/reset-sunxi.c
index df58e71..58ddb26 100644
--- a/drivers/reset/reset-sunxi.c
+++ b/drivers/reset/reset-sunxi.c
@@ -140,7 +140,7 @@ static int sun8i_h3_bus_reset_xlate(struct reset_controller_dev *rcdev,
  * our system, before we can even think of using a regular device
  * driver for it.
  */
-static const struct of_device_id sunxi_early_reset_dt_ids[] __initdata = {
+static const struct of_device_id sunxi_early_reset_dt_ids[] __initconst = {
 	{ .compatible = "allwinner,sun6i-a31-ahb1-reset", },
 	{ .compatible = "allwinner,sun8i-h3-bus-reset", .data = sun8i_h3_bus_reset_xlate, },
 	{ /* sentinel */ },
-- 
2.6.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1259618

FromMaxime Ripard <maxime.ripard@free-electrons.com>
Date2015-10-30 17:50 +0100
Message-ID<qpl2i-8b8-9@gated-at.bofh.it>
In reply to#1258670

[Multipart message — attachments visible in raw view] — view raw

On Thu, Oct 29, 2015 at 10:10:17AM +0100, Philipp Zabel wrote:
> Since this array is static const, it should be marked as __initconst.
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]


#1260423

FromUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date2015-11-02 08:30 +0100
Message-ID<qqhIZ-2rX-1@gated-at.bofh.it>
In reply to#1258670
Hello Philipp,

On Thu, Oct 29, 2015 at 10:10:17AM +0100, Philipp Zabel wrote:
> Since this array is static const, it should be marked as __initconst.

independent of your change sunxi_reset_init can be moved to .init.text,
too.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web