Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1258235 > unrolled thread

[PATCH] ARM: fix bug in vdsomunge swab32 macro

Back to article view | Back to linux.kernel

Contents

  [PATCH] ARM: fix bug in vdsomunge swab32 macro "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-10-28 16:20 +0100
    Re: [PATCH] ARM: fix bug in vdsomunge swab32 macro Arnd Bergmann <arnd@arndb.de> - 2015-10-30 14:00 +0100
      Re: [PATCH] ARM: fix bug in vdsomunge swab32 macro Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-10-30 14:10 +0100

#1258235 — [PATCH] ARM: fix bug in vdsomunge swab32 macro

Commit Commit 8a603f91cc48 ("ARM: 8445/1: fix vdsomunge not to depend on glibc specific byteswap.h")

unfortunately introduced a bug created but not found during
discussion and patch simplification.

Reported-by: Efraim Yawitz <efraim.yawitz@gmail.com>
Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
 arch/arm/vdso/vdsomunge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/vdso/vdsomunge.c b/arch/arm/vdso/vdsomunge.c
index 0cebd98..f645527 100644
--- a/arch/arm/vdso/vdsomunge.c
+++ b/arch/arm/vdso/vdsomunge.c
@@ -66,7 +66,7 @@
 	((((x) & 0x000000ff) << 24) | \
 	 (((x) & 0x0000ff00) <<  8) | \
 	 (((x) & 0x00ff0000) >>  8) | \
-	 (((x) & 0xff000000) << 24))
+	 (((x) & 0xff000000) >> 24))
 
 #if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
 #define HOST_ORDER ELFDATA2LSB
-- 
2.5.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1259486

On Wednesday 28 October 2015 16:10:48 H. Nikolaus Schaller wrote:
> Commit Commit 8a603f91cc48 ("ARM: 8445/1: fix vdsomunge not to depend on glibc specific byteswap.h")
> 
> unfortunately introduced a bug created but not found during
> discussion and patch simplification.
> 
> Reported-by: Efraim Yawitz <efraim.yawitz@gmail.com>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> 

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

Please add it to Russell's patch tracker at
http://www.arm.linux.org.uk/developer/patches/

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1259488

On Fri, Oct 30, 2015 at 01:54:55PM +0100, Arnd Bergmann wrote:
> On Wednesday 28 October 2015 16:10:48 H. Nikolaus Schaller wrote:
> > Commit Commit 8a603f91cc48 ("ARM: 8445/1: fix vdsomunge not to depend on glibc specific byteswap.h")
> > 
> > unfortunately introduced a bug created but not found during
> > discussion and patch simplification.
> > 
> > Reported-by: Efraim Yawitz <efraim.yawitz@gmail.com>
> > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> > ---
> > 
> 
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> 
> Please add it to Russell's patch tracker at
> http://www.arm.linux.org.uk/developer/patches/

A patch very similar to this has already been merged (probably this
patch but submitted by Nathan.)

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web