Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1259565 > unrolled thread

[PATCH] drivers:staging:gdm724x Fix comparison to NULL could be written like

Back to article view | Back to linux.kernel

Contents

  [PATCH] drivers:staging:gdm724x Fix comparison to NULL could be written like Bogicevic Sasa <brutallesale@gmail.com> - 2015-10-30 16:00 +0100
    Re: [PATCH] drivers:staging:gdm724x Fix comparison to NULL could be  written like Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-31 09:00 +0100
      Re: [PATCH] drivers:staging:gdm724x Fix comparison to NULL could be  written like Bogicevic Sasa <brutallesale@gmail.com> - 2015-10-31 10:30 +0100

#1259565 — [PATCH] drivers:staging:gdm724x Fix comparison to NULL could be written like

This fixes all messages from checkpatch.pl about comparison to NULL
could be written according to coding style preferences

Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com>
---
 drivers/staging/gdm724x/gdm_mux.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c
index e416012..c70e8b8 100644
--- a/drivers/staging/gdm724x/gdm_mux.c
+++ b/drivers/staging/gdm724x/gdm_mux.c
@@ -489,7 +489,7 @@ static int init_usb(struct mux_dev *mux_dev)
 
 	for (i = 0; i < MAX_ISSUE_NUM * 2; i++) {
 		r = alloc_mux_rx();
-		if (r == NULL) {
+		if (!r) {
 			ret = -ENOMEM;
 			break;
 		}
@@ -657,7 +657,7 @@ static struct usb_driver gdm_mux_driver = {
 static int __init gdm_usb_mux_init(void)
 {
 	mux_rx_wq = create_workqueue("mux_rx_wq");
-	if (mux_rx_wq == NULL) {
+	if (!mux_rx_wq) {
 		pr_err("work queue create fail\n");
 		return -1;
 	}
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1259952 — Re: [PATCH] drivers:staging:gdm724x Fix comparison to NULL could be written like

On Fri, Oct 30, 2015 at 03:54:03PM +0100, Bogicevic Sasa wrote:
> This fixes all messages from checkpatch.pl about comparison to NULL
> could be written according to coding style preferences
> 
> Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com>
> ---

For all your next patches, either they have already deen done or they
will not apply because of some other change in that part.

Are you still using the stable tree?

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1259960 — Re: [PATCH] drivers:staging:gdm724x Fix comparison to NULL could be written like

On 10/31, Sudip Mukherjee wrote:
>On Fri, Oct 30, 2015 at 03:54:03PM +0100, Bogicevic Sasa wrote:
>> This fixes all messages from checkpatch.pl about comparison to NULL
>> could be written according to coding style preferences
>>
>> Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com>
>> ---
>
>For all your next patches, either they have already deen done or they
>will not apply because of some other change in that part.
>
>Are you still using the stable tree?
>
>regards
>sudip
Not a lot of work but all for nothing :) I cloned staging but didn't
switch to staging-testing branch :( No worries I will start again,
Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web