Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1257444 > unrolled thread

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE  event Richard Weinberger <richard.weinberger@gmail.com> - 2015-10-27 23:40 +0100
    RE: [PATCH net-next] hyperv: Add handler for  RNDIS_STATUS_NETWORK_CHANGE event Haiyang Zhang <haiyangz@microsoft.com> - 2015-10-28 19:10 +0100
    RE: [PATCH net-next] hyperv: Add handler for  RNDIS_STATUS_NETWORK_CHANGE event Haiyang Zhang <haiyangz@microsoft.com> - 2015-10-29 20:10 +0100
      Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event Vitaly Kuznetsov <vkuznets@redhat.com> - 2015-10-30 12:00 +0100
        Re: [PATCH net-next] hyperv: Add handler for  RNDIS_STATUS_NETWORK_CHANGE event Richard Weinberger <richard@nod.at> - 2015-10-30 23:20 +0100
        RE: [PATCH net-next] hyperv: Add handler for  RNDIS_STATUS_NETWORK_CHANGE event Haiyang Zhang <haiyangz@microsoft.com> - 2015-10-30 23:40 +0100

#1257444 — Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

On Mon, Jun 23, 2014 at 10:10 PM, David Miller <davem@davemloft.net> wrote:
> From: Haiyang Zhang <haiyangz@microsoft.com>
> Date: Mon, 23 Jun 2014 16:09:59 +0000
>
>> So, what's the equivalent or similar command to "network restart" on SLES12? Could
>> you update the command line for the usermodehelper when porting this patch to SLES
>> 12?
>
> No, you are not going to keep the usermodehelper invocation in your driver
> please remove it.  It is absolutely inappropriate, and I strictly do not want
> to keep it in there because other people will copy it and then we'll have a
> real mess on our hands.

Sorry for digging up this old thread.
While talking with some guys about usermodehelper abuses I came across this gem.
Mainline still contains that "/etc/init.d/network restart" code.
Haiyang, care to cleanup?

-- 
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1258343 — RE: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogUmljaGFyZCBXZWluYmVy
Z2VyIFttYWlsdG86cmljaGFyZC53ZWluYmVyZ2VyQGdtYWlsLmNvbV0NCj4gU2VudDogVHVlc2Rh
eSwgT2N0b2JlciAyNywgMjAxNSA2OjM2IFBNDQo+IFRvOiBEYXZpZCBNaWxsZXIgPGRhdmVtQGRh
dmVtbG9mdC5uZXQ+DQo+IENjOiBIYWl5YW5nIFpoYW5nIDxoYWl5YW5nekBtaWNyb3NvZnQuY29t
Pjsgb2xhZkBhZXBmbGUuZGU7IEdyZWcgS3JvYWgtDQo+IEhhcnRtYW4gPGdyZWdAa3JvYWguY29t
PjsgbmV0ZGV2QHZnZXIua2VybmVsLm9yZzsNCj4gamFzb3dhbmdAcmVkaGF0LmNvbTsgZHJpdmVy
ZGV2LWRldmVsQGxpbnV4ZHJpdmVycHJvamVjdC5vcmc7IExLTUwNCj4gPGxpbnV4LWtlcm5lbEB2
Z2VyLmtlcm5lbC5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggbmV0LW5leHRdIGh5cGVydjog
QWRkIGhhbmRsZXIgZm9yDQo+IFJORElTX1NUQVRVU19ORVRXT1JLX0NIQU5HRSBldmVudA0KPiAN
Cj4gT24gTW9uLCBKdW4gMjMsIDIwMTQgYXQgMTA6MTAgUE0sIERhdmlkIE1pbGxlciA8ZGF2ZW1A
ZGF2ZW1sb2Z0Lm5ldD4NCj4gd3JvdGU6DQo+ID4gRnJvbTogSGFpeWFuZyBaaGFuZyA8aGFpeWFu
Z3pAbWljcm9zb2Z0LmNvbT4NCj4gPiBEYXRlOiBNb24sIDIzIEp1biAyMDE0IDE2OjA5OjU5ICsw
MDAwDQo+ID4NCj4gPj4gU28sIHdoYXQncyB0aGUgZXF1aXZhbGVudCBvciBzaW1pbGFyIGNvbW1h
bmQgdG8gIm5ldHdvcmsgcmVzdGFydCIgb24NCj4gPj4gU0xFUzEyPyBDb3VsZCB5b3UgdXBkYXRl
IHRoZSBjb21tYW5kIGxpbmUgZm9yIHRoZSB1c2VybW9kZWhlbHBlcg0KPiB3aGVuDQo+ID4+IHBv
cnRpbmcgdGhpcyBwYXRjaCB0byBTTEVTIDEyPw0KPiA+DQo+ID4gTm8sIHlvdSBhcmUgbm90IGdv
aW5nIHRvIGtlZXAgdGhlIHVzZXJtb2RlaGVscGVyIGludm9jYXRpb24gaW4geW91cg0KPiA+IGRy
aXZlciBwbGVhc2UgcmVtb3ZlIGl0LiAgSXQgaXMgYWJzb2x1dGVseSBpbmFwcHJvcHJpYXRlLCBh
bmQgSQ0KPiA+IHN0cmljdGx5IGRvIG5vdCB3YW50IHRvIGtlZXAgaXQgaW4gdGhlcmUgYmVjYXVz
ZSBvdGhlciBwZW9wbGUgd2lsbA0KPiA+IGNvcHkgaXQgYW5kIHRoZW4gd2UnbGwgaGF2ZSBhIHJl
YWwgbWVzcyBvbiBvdXIgaGFuZHMuDQo+IA0KPiBTb3JyeSBmb3IgZGlnZ2luZyB1cCB0aGlzIG9s
ZCB0aHJlYWQuDQo+IFdoaWxlIHRhbGtpbmcgd2l0aCBzb21lIGd1eXMgYWJvdXQgdXNlcm1vZGVo
ZWxwZXIgYWJ1c2VzIEkgY2FtZSBhY3Jvc3MNCj4gdGhpcyBnZW0uDQo+IE1haW5saW5lIHN0aWxs
IGNvbnRhaW5zIHRoYXQgIi9ldGMvaW5pdC5kL25ldHdvcmsgcmVzdGFydCIgY29kZS4NCj4gSGFp
eWFuZywgY2FyZSB0byBjbGVhbnVwPw0KDQpJIHdpbGwgY2xlYW4gdXAgdGhlIHVzZXJtb2RlIGhl
bHBlciBzb29uLg0KDQpUaGFua3MsDQotIEhhaXlhbmcNCg0K
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1258956 — RE: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogUmljaGFyZCBXZWluYmVy
Z2VyIFttYWlsdG86cmljaGFyZC53ZWluYmVyZ2VyQGdtYWlsLmNvbV0NCj4gU2VudDogVHVlc2Rh
eSwgT2N0b2JlciAyNywgMjAxNSA2OjM2IFBNDQo+IFRvOiBEYXZpZCBNaWxsZXIgPGRhdmVtQGRh
dmVtbG9mdC5uZXQ+DQo+IENjOiBIYWl5YW5nIFpoYW5nIDxoYWl5YW5nekBtaWNyb3NvZnQuY29t
Pjsgb2xhZkBhZXBmbGUuZGU7IEdyZWcgS3JvYWgtDQo+IEhhcnRtYW4gPGdyZWdAa3JvYWguY29t
PjsgbmV0ZGV2QHZnZXIua2VybmVsLm9yZzsgamFzb3dhbmdAcmVkaGF0LmNvbTsNCj4gZHJpdmVy
ZGV2LWRldmVsQGxpbnV4ZHJpdmVycHJvamVjdC5vcmc7IExLTUwgPGxpbnV4LQ0KPiBrZXJuZWxA
dmdlci5rZXJuZWwub3JnPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIIG5ldC1uZXh0XSBoeXBlcnY6
IEFkZCBoYW5kbGVyIGZvcg0KPiBSTkRJU19TVEFUVVNfTkVUV09SS19DSEFOR0UgZXZlbnQNCj4g
DQo+IE9uIE1vbiwgSnVuIDIzLCAyMDE0IGF0IDEwOjEwIFBNLCBEYXZpZCBNaWxsZXIgPGRhdmVt
QGRhdmVtbG9mdC5uZXQ+DQo+IHdyb3RlOg0KPiA+IEZyb206IEhhaXlhbmcgWmhhbmcgPGhhaXlh
bmd6QG1pY3Jvc29mdC5jb20+DQo+ID4gRGF0ZTogTW9uLCAyMyBKdW4gMjAxNCAxNjowOTo1OSAr
MDAwMA0KPiA+DQo+ID4+IFNvLCB3aGF0J3MgdGhlIGVxdWl2YWxlbnQgb3Igc2ltaWxhciBjb21t
YW5kIHRvICJuZXR3b3JrIHJlc3RhcnQiIG9uDQo+IFNMRVMxMj8gQ291bGQNCj4gPj4geW91IHVw
ZGF0ZSB0aGUgY29tbWFuZCBsaW5lIGZvciB0aGUgdXNlcm1vZGVoZWxwZXIgd2hlbiBwb3J0aW5n
IHRoaXMNCj4gcGF0Y2ggdG8gU0xFUw0KPiA+PiAxMj8NCj4gPg0KPiA+IE5vLCB5b3UgYXJlIG5v
dCBnb2luZyB0byBrZWVwIHRoZSB1c2VybW9kZWhlbHBlciBpbnZvY2F0aW9uIGluIHlvdXINCj4g
ZHJpdmVyDQo+ID4gcGxlYXNlIHJlbW92ZSBpdC4gIEl0IGlzIGFic29sdXRlbHkgaW5hcHByb3By
aWF0ZSwgYW5kIEkgc3RyaWN0bHkgZG8NCj4gbm90IHdhbnQNCj4gPiB0byBrZWVwIGl0IGluIHRo
ZXJlIGJlY2F1c2Ugb3RoZXIgcGVvcGxlIHdpbGwgY29weSBpdCBhbmQgdGhlbiB3ZSdsbA0KPiBo
YXZlIGENCj4gPiByZWFsIG1lc3Mgb24gb3VyIGhhbmRzLg0KPiANCj4gU29ycnkgZm9yIGRpZ2dp
bmcgdXAgdGhpcyBvbGQgdGhyZWFkLg0KPiBXaGlsZSB0YWxraW5nIHdpdGggc29tZSBndXlzIGFi
b3V0IHVzZXJtb2RlaGVscGVyIGFidXNlcyBJIGNhbWUgYWNyb3NzDQo+IHRoaXMgZ2VtLg0KPiBN
YWlubGluZSBzdGlsbCBjb250YWlucyB0aGF0ICIvZXRjL2luaXQuZC9uZXR3b3JrIHJlc3RhcnQi
IGNvZGUuDQo+IEhhaXlhbmcsIGNhcmUgdG8gY2xlYW51cD8NCg0KSGkgUmljaGFyZCBhbmQgb3Ro
ZXJzLA0KDQpUaGFua3MgZm9yIHRoZSByZW1pbmRlci4gSSB3aWxsIGNsZWFuIHVwIHRoZSB1c2Vy
bW9kZSBoZWxwZXIuDQoNCkRvIHlvdSBoYXZlIHN1Z2dlc3Rpb25zIG9mIHRyaWdnZXIgREhDUCBy
ZWZyZXNoIGZyb20ga2VybmVsIG1vZGU/IEFueSANCnNhbXBsZSBjb2RlIGluIHRoZSBleGlzdGlu
ZyBrZXJuZWwgY29kZT8NCg0KVGhhbmtzLA0KLSBIYWl5YW5nDQoNCg==
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1259395 — Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

Haiyang Zhang <haiyangz@microsoft.com> writes:

>> -----Original Message-----
>> From: Richard Weinberger [mailto:richard.weinberger@gmail.com]
>> Sent: Tuesday, October 27, 2015 6:36 PM
>> To: David Miller <davem@davemloft.net>
>> Cc: Haiyang Zhang <haiyangz@microsoft.com>; olaf@aepfle.de; Greg Kroah-
>> Hartman <greg@kroah.com>; netdev@vger.kernel.org; jasowang@redhat.com;
>> driverdev-devel@linuxdriverproject.org; LKML <linux-
>> kernel@vger.kernel.org>
>> Subject: Re: [PATCH net-next] hyperv: Add handler for
>> RNDIS_STATUS_NETWORK_CHANGE event
>> 
>> On Mon, Jun 23, 2014 at 10:10 PM, David Miller <davem@davemloft.net>
>> wrote:
>> > From: Haiyang Zhang <haiyangz@microsoft.com>
>> > Date: Mon, 23 Jun 2014 16:09:59 +0000
>> >
>> >> So, what's the equivalent or similar command to "network restart" on
>> SLES12? Could
>> >> you update the command line for the usermodehelper when porting this
>> patch to SLES
>> >> 12?
>> >
>> > No, you are not going to keep the usermodehelper invocation in your
>> driver
>> > please remove it.  It is absolutely inappropriate, and I strictly do
>> not want
>> > to keep it in there because other people will copy it and then we'll
>> have a
>> > real mess on our hands.
>> 
>> Sorry for digging up this old thread.
>> While talking with some guys about usermodehelper abuses I came across
>> this gem.
>> Mainline still contains that "/etc/init.d/network restart" code.
>> Haiyang, care to cleanup?
>
> Hi Richard and others,
>
> Thanks for the reminder. I will clean up the usermode helper.
>
> Do you have suggestions of trigger DHCP refresh from kernel mode? Any 
> sample code in the existing kernel code?
>

I think it's wrong to call dhcp refresh from kernel. What happens when
we reconnect normal hardware adapter to another network? Link goes down
and then up and userspace is supposed to react accordingly. I think we
should emulate something similar for RNDIS_STATUS_NETWORK_CHANGE.

-- 
  Vitaly
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1259816 — Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

Am 30.10.2015 um 23:03 schrieb Haiyang Zhang:
> 
> 
>> -----Original Message-----
>> From: Vitaly Kuznetsov [mailto:vkuznets@redhat.com]
>> Sent: Friday, October 30, 2015 6:56 AM
>> To: Haiyang Zhang <haiyangz@microsoft.com>
>> Cc: Richard Weinberger <richard.weinberger@gmail.com>; David Miller
>> <davem@davemloft.net>; olaf@aepfle.de; jasowang@redhat.com; driverdev-
>> devel@linuxdriverproject.org; LKML <linux-kernel@vger.kernel.org>;
>> netdev@vger.kernel.org
>> Subject: Re: [PATCH net-next] hyperv: Add handler for
>> RNDIS_STATUS_NETWORK_CHANGE event
>>
>> Haiyang Zhang <haiyangz@microsoft.com> writes:
>>
>>>> -----Original Message-----
>>>> From: Richard Weinberger [mailto:richard.weinberger@gmail.com]
>>>> Sent: Tuesday, October 27, 2015 6:36 PM
>>>> To: David Miller <davem@davemloft.net>
>>>> Cc: Haiyang Zhang <haiyangz@microsoft.com>; olaf@aepfle.de; Greg
>> Kroah-
>>>> Hartman <greg@kroah.com>; netdev@vger.kernel.org; jasowang@redhat.com;
>>>> driverdev-devel@linuxdriverproject.org; LKML <linux-
>>>> kernel@vger.kernel.org>
>>>> Subject: Re: [PATCH net-next] hyperv: Add handler for
>>>> RNDIS_STATUS_NETWORK_CHANGE event
>>>>
>>>> On Mon, Jun 23, 2014 at 10:10 PM, David Miller <davem@davemloft.net>
>>>> wrote:
>>>>> From: Haiyang Zhang <haiyangz@microsoft.com>
>>>>> Date: Mon, 23 Jun 2014 16:09:59 +0000
>>>>>
>>>>>> So, what's the equivalent or similar command to "network restart"
>> on
>>>> SLES12? Could
>>>>>> you update the command line for the usermodehelper when porting
>> this
>>>> patch to SLES
>>>>>> 12?
>>>>>
>>>>> No, you are not going to keep the usermodehelper invocation in your
>>>> driver
>>>>> please remove it.  It is absolutely inappropriate, and I strictly
>> do
>>>> not want
>>>>> to keep it in there because other people will copy it and then
>> we'll
>>>> have a
>>>>> real mess on our hands.
>>>>
>>>> Sorry for digging up this old thread.
>>>> While talking with some guys about usermodehelper abuses I came
>> across
>>>> this gem.
>>>> Mainline still contains that "/etc/init.d/network restart" code.
>>>> Haiyang, care to cleanup?
>>>
>>> Hi Richard and others,
>>>
>>> Thanks for the reminder. I will clean up the usermode helper.
>>>
>>> Do you have suggestions of trigger DHCP refresh from kernel mode? Any
>>> sample code in the existing kernel code?
>>>
>>
>> I think it's wrong to call dhcp refresh from kernel. What happens when
>> we reconnect normal hardware adapter to another network? Link goes down
>> and then up and userspace is supposed to react accordingly. I think we
>> should emulate something similar for RNDIS_STATUS_NETWORK_CHANGE.
> 
> When link is down physically for a few seconds, the DHCP will automatically 
> refresh. I will add code to emulate this. There were some discussions around 
> this and other possibilities previously... I agree emulating what happens 
> with physically plug/unplug a cable is a reasonable way to trigger the DHCP 
> refresh.

Can't you propagate the event to userspace and let it take an appropriate
action?

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1259828 — RE: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

> -----Original Message-----
> From: Vitaly Kuznetsov [mailto:vkuznets@redhat.com]
> Sent: Friday, October 30, 2015 6:56 AM
> To: Haiyang Zhang <haiyangz@microsoft.com>
> Cc: Richard Weinberger <richard.weinberger@gmail.com>; David Miller
> <davem@davemloft.net>; olaf@aepfle.de; jasowang@redhat.com; driverdev-
> devel@linuxdriverproject.org; LKML <linux-kernel@vger.kernel.org>;
> netdev@vger.kernel.org
> Subject: Re: [PATCH net-next] hyperv: Add handler for
> RNDIS_STATUS_NETWORK_CHANGE event
> 
> Haiyang Zhang <haiyangz@microsoft.com> writes:
> 
> >> -----Original Message-----
> >> From: Richard Weinberger [mailto:richard.weinberger@gmail.com]
> >> Sent: Tuesday, October 27, 2015 6:36 PM
> >> To: David Miller <davem@davemloft.net>
> >> Cc: Haiyang Zhang <haiyangz@microsoft.com>; olaf@aepfle.de; Greg
> Kroah-
> >> Hartman <greg@kroah.com>; netdev@vger.kernel.org; jasowang@redhat.com;
> >> driverdev-devel@linuxdriverproject.org; LKML <linux-
> >> kernel@vger.kernel.org>
> >> Subject: Re: [PATCH net-next] hyperv: Add handler for
> >> RNDIS_STATUS_NETWORK_CHANGE event
> >>
> >> On Mon, Jun 23, 2014 at 10:10 PM, David Miller <davem@davemloft.net>
> >> wrote:
> >> > From: Haiyang Zhang <haiyangz@microsoft.com>
> >> > Date: Mon, 23 Jun 2014 16:09:59 +0000
> >> >
> >> >> So, what's the equivalent or similar command to "network restart"
> on
> >> SLES12? Could
> >> >> you update the command line for the usermodehelper when porting
> this
> >> patch to SLES
> >> >> 12?
> >> >
> >> > No, you are not going to keep the usermodehelper invocation in your
> >> driver
> >> > please remove it.  It is absolutely inappropriate, and I strictly
> do
> >> not want
> >> > to keep it in there because other people will copy it and then
> we'll
> >> have a
> >> > real mess on our hands.
> >>
> >> Sorry for digging up this old thread.
> >> While talking with some guys about usermodehelper abuses I came
> across
> >> this gem.
> >> Mainline still contains that "/etc/init.d/network restart" code.
> >> Haiyang, care to cleanup?
> >
> > Hi Richard and others,
> >
> > Thanks for the reminder. I will clean up the usermode helper.
> >
> > Do you have suggestions of trigger DHCP refresh from kernel mode? Any
> > sample code in the existing kernel code?
> >
> 
> I think it's wrong to call dhcp refresh from kernel. What happens when
> we reconnect normal hardware adapter to another network? Link goes down
> and then up and userspace is supposed to react accordingly. I think we
> should emulate something similar for RNDIS_STATUS_NETWORK_CHANGE.

When link is down physically for a few seconds, the DHCP will automatically 
refresh. I will add code to emulate this. There were some discussions around 
this and other possibilities previously... I agree emulating what happens 
with physically plug/unplug a cable is a reasonable way to trigger the DHCP 
refresh.

Thanks,
- Haiyang



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web