Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1257748 > unrolled thread

Re: [PATCH V2 4/5] cpufreq: create cpu/cpufreq/policyX directories

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH V2 4/5] cpufreq: create cpu/cpufreq/policyX directories "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-10-28 08:50 +0100
    Re: [PATCH V2 4/5] cpufreq: create cpu/cpufreq/policyX directories Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-28 09:30 +0100

#1257748 — Re: [PATCH V2 4/5] cpufreq: create cpu/cpufreq/policyX directories

On Friday, October 16, 2015 11:21:18 AM Viresh Kumar wrote:
> On 15-10-15, 12:25, Saravana Kannan wrote:
> > Btw, does a Review-by have an implicit Acked-by?
> 
> I have attended a session at Linaro Connect where this was discussed
> and the answer was:
> 
> Acked-by: is more of a general agreement from the person that he is
> fine with the patch, but he might not have done a very careful review
> and he isn't really responsible for the patch's content.
> 
> Reviewed-by: is a more strict tag and implies that the reviewer has
> reviewed it at his best and he is as much responsible for the content
> of the patch as the author.

That's a bit too much IMO.  It means "I have carried out a detailed review
of this patch and haven't found problems in it."  How much responsibility
that implies is not so clear (evidently, there are differing opinions
regarding that).

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1257784

On 28-10-15, 09:16, Rafael J. Wysocki wrote:
> That's a bit too much IMO.  It means "I have carried out a detailed review
> of this patch and haven't found problems in it."  How much responsibility
> that implies is not so clear (evidently, there are differing opinions
> regarding that).

Right. I agree.

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web