Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1257527 > unrolled thread
| Started by | Olof Johansson <olof@lixom.net> |
|---|---|
| First post | 2015-10-28 01:50 +0100 |
| Last post | 2015-10-28 07:10 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 03/10] merge_config.sh: minor argument parsing refactoring Olof Johansson <olof@lixom.net> - 2015-10-28 01:50 +0100
Re: [PATCH 03/10] merge_config.sh: minor argument parsing refactoring Darren Hart <dvhart@infradead.org> - 2015-10-28 07:10 +0100
| From | Olof Johansson <olof@lixom.net> |
|---|---|
| Date | 2015-10-28 01:50 +0100 |
| Subject | [PATCH 03/10] merge_config.sh: minor argument parsing refactoring |
| Message-ID | <qon6a-3PX-19@gated-at.bofh.it> |
Every case that continues iterating needs a shift, so move it to common location. Also, the continues are redundant. Signed-off-by: Olof Johansson <olof@lixom.net> --- scripts/kconfig/merge_config.sh | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh index 0e98619..fd0d537 100755 --- a/scripts/kconfig/merge_config.sh +++ b/scripts/kconfig/merge_config.sh @@ -48,13 +48,9 @@ while true; do case $1 in "-n") ALLTARGET=allnoconfig - shift - continue ;; "-m") RUNMAKE=false - shift - continue ;; "-h") usage @@ -62,8 +58,6 @@ while true; do ;; "-r") WARNREDUN=true - shift - continue ;; "-O") if [ -d $2 ];then @@ -72,13 +66,14 @@ while true; do echo "output directory $2 does not exist" 1>&2 exit 1 fi - shift 2 - continue + shift ;; *) break ;; esac + + shift done if [ "$#" -lt 1 ] ; then -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Darren Hart <dvhart@infradead.org> |
|---|---|
| Date | 2015-10-28 07:10 +0100 |
| Message-ID | <qos5P-7j5-1@gated-at.bofh.it> |
| In reply to | #1257527 |
On Wed, Oct 28, 2015 at 09:42:04AM +0900, Olof Johansson wrote: > Every case that continues iterating needs a shift, so move it to common location. > Also, the continues are redundant. > > Signed-off-by: Olof Johansson <olof@lixom.net> Nice cleanup, thanks Olof. Reviewed-by: Darren Hart <dvhart@linux.intel.com> -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web